Issue: VW4 Gamma 5 Upgrade Crash

Issue Tools
- View Changes

April 18, 2014 4:07 PM
Ptah

Junior Member
VW4 Gamma 5 Upgrade Crash

Parse Error when trying to run install script for upgrade

When I try to run /vault/install/index.php to upgrade to Gamma 5 (from Gamma 4), I get this error:

Code:

Parse error: syntax error, unexpected '=' in /home/intpcomp/public_html/forums/vault/core/controller/cp/install/vb3.php on line 73

..right away, crashing the whole thing from going any further.

I copied the files over, tweaked the config.php, and tried to run the install -- crash, as above.

Help?

Issue Details

Issue Number 3690

Issue Type Bug

Project VaultWiki 4.x Series

Category Install / Upgrade

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.0.0 Gamma 5

Fixed Version 4.0.0 Gamma 5

Milestone VaultWiki 4 Gamma X

Software DependencyvBulletin 4.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 18, 2014 4:19 PM

Ptah

Junior Member

FYI, I re-uploaded and manually checked various files, including the one it said it has a parse error on, to ensure they were correct and current (with respect to Gamma 5 upload content), which they are.

Still can't run the install script to upgrade to Gamma 5?

Reply
April 18, 2014 4:58 PM

Ptah

Junior Member

Until/unless I can resolve this, since the upgrade/install script for Gamma 5 never even got started, is it safe for me to restore the forum directory to how it was beforehand and/or basically just re-upload my Gamma 4 as-was , so I can use my wiki as it was in the meantime?

Right now, I've taken my wiki down since I don't want it used in some interim state of having Gamma 5 code uploaded but not installed, etc.

Reply
April 18, 2014 5:25 PM

Ptah

Junior Member

I am by no means a PHP expert, but it seems there is an attempt to assign to the Class Constant "MIN_PACKET"? So perhaps it is confusing the PHP parser when it sees an assignment attempt against this name?

For instance, just hacking around, I could get it to parse (in a syntax checker) by removing the two lines which attempt to assign to "self::MIN_PACKET".

Reply
April 18, 2014 10:15 PM
Ptah

Junior Member
Pushing Though... To Test... More Problems

Taking a backup of my site and its database, I decided to just comment out the aforementioned lines which tried to assign to self::MIN_PACKET, and run the installer with that tweak (since it seemed all that code was just about checking for minimum MySql packet size?) ... now, when loading the install script, it jumps immediately to a vault-wiki shelled page with nothing but the following error message:

Code:

Fatal error: Class 'vw_Install_UpgradePath_Steps_400gamma5_base_Controller' not found in /home/intpcomp/public_html/forums/vault/core/controller/install/upgradepath/steps/4/0/0/gamma/5/3X/vb3.php on line 20

With all due respect, it would seem that there are some problems with the Gamma 5 upgrade process?

Any insight or help would be great.
Thank you.
Reply
April 19, 2014 10:52 AM

pegasus

VaultWiki Team

I have just finished refactoring this code. Please let me know if you still have issues. In the future when you encounter Parse Errors in PHP, it is also helpful if you post your PHP version with the bug report. I believe our development server uses PHP 5.5 currently, so sometimes a dev might use newer syntax that simply does not work on earlier PHP versions.

We try to keep a lookout for this, but sometimes it is not obvious. For example, according to my reading assigning class constants during instantiation should always cause an error, yet the code you reported was able to pass QA when running the upgrader on our dev site.

Reply
April 19, 2014 11:05 AM

Ptah

Junior Member

Many thanks for the insight.

I was remiss not to include the PHP version, sorry.
PHP 5.3.27 is what I'm running now.

Reply
April 19, 2014 3:23 PM
Ptah

Junior Member
I downloaded the patch from Gamma5 001 to 002, uploaded it, and now when I try to run the installer I get another immediate fatal crash:

Code:

Fatal error: Access to undeclared static property: vw_CP_Install_Controller_vB3::$MIN_PACKET in /home/intpcomp/public_html/forums/vault/core/controller/cp/install/vb3.php on line 71
Reply
This petition for a change to Unconfirmed was rejected
April 19, 2014 3:32 PM

Ptah

Junior Member

Wiped and re-installed a full Gamma 5 002 from scratch. Same exact error
April 19, 2014 5:37 PM
pegasus

VaultWiki Team
In vault/core/controller/cp/install/vw.php, find:

Code:

protected $MIN_PACKET

Replace with:

Code:

protected static $MIN_PACKET
Reply

April 19, 2014 5:55 PM

Ptah

Junior Member

Ok, thank you.

I did that, got to Step 8 and then got this fatal crash

Code:

Installing VaultWiki v4.0.0 Gamma 5
Step 8

creating_wiki_index
creating_example_area

Fatal error: Call to a member function update() on a non-object in /home/intpcomp/public_html/forums/vault/core/controller/dm/area/vw.php on line 307

April 19, 2014 6:28 PM

pegasus

VaultWiki Team

This occurs because a required field is missing from one of the new inserts that the installer makes. I think the most effective means of getting around this is reworking the DM so that it uses a default value if the field is omitted.

Please try the new vault/core/controller/dm/area/vw.php. I'm not sure, but I think you will have a URL conflict after completing the install since the Step 8 error fails when building the route for a new area. After successfully installing, you should probably uninstall and reinstall to avoid issues with duplicate default data.

Reply
April 19, 2014 6:57 PM

Ptah

Junior Member

So I should just upload that from the 003 and try to re-run the install script? Will it try to pick up where it left off?

Reply

April 19, 2014 7:01 PM

Ptah

Junior Member

Ok, so I updated that script from 003, gave the install another run. Step 8 completed, but now it hard crashes on Step 14:

Code:

Database error in vBulletin 4.2.2:

Invalid SQL:
REPLACE INTO `phrasetype` (`rawfield`, `fieldname`, `title`, `editrows`, `product`)  VALUES (vw_admin,'vw_admin','VaultWiki: Admin Panel',3,'vaultwiki'),
	(vw_help,'vw_help','VaultWiki: Help Text',3,'vaultwiki'),
	(vw_index,'vw_index','VaultWiki: Content',3,'vaultwiki');

MySQL Error   : Unknown column 'vw_admin' in 'field list'
Error Number  : 1054
Request Date  : Saturday, April 19th 2014 @ 10:59:49 PM
Error Date    : Saturday, April 19th 2014 @ 10:59:51 PM
Script        : [url]http://forums.intpcomplex.com/vault/install/index.php[/url]
Referrer      : [url]http://forums.intpcomplex.com/vault/install/index.php[/url]
IP Address    : 71.201.229.147
Username      : Ptah
Classname     : vB_Database
MySQL Version : 5.5.36-cll

April 19, 2014 7:03 PM

Ptah

Junior Member

this has left my forum all screwed up. Hard crashes when attempting to get to PMs, Settings or UserCP... :/

Reply

April 19, 2014 7:06 PM

pegasus

VaultWiki Team

In vault/core/controller/install/common/vb3.php, find:

Code:

				foreach ($newtypes AS $type)
				{
					$dbalter->add_field(array(
						'name' => 'phrasegroup_' . strtolower($type['rawfield']),
						'type' => 'MEDIUMTEXT'
					));
					unset($type['rawfield']);
				}

Replace with:

Code:

				foreach ($newtypes AS $key => $type)
				{
					$dbalter->add_field(array(
						'name' => 'phrasegroup_' . strtolower($type['rawfield']),
						'type' => 'MEDIUMTEXT'
					));
					unset($newtypes["$key"]['rawfield']);
				}

+ Reply

All times are GMT -4. The time now is 5:20 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: VW4 Gamma 5 Upgrade Crash

Issue Tools