Issue: Errors after upgrade to vBulletin 4.2.2

Issue Tools
- View Changes

January 29, 2014 12:21 AM

DragonSigh DragonSigh is offline

Junior Member

Errors after upgrade to vBulletin 4.2.2

This errors appears on the top of the pages. Wiki's Main page and others:

Code:

Warning: Declaration of vB_WikiCodeParser::handle_bbcode_img() should be compatible with that of vB_BbCodeParser::handle_bbcode_img() in ..../vault/class/bbcode.php on line 34

Articles pages:

Code:

Warning: Only variables should be passed by reference in ..../vault/functions/bbcode/image.php on line 295

Forum pages:

Code:

Warning: Declaration of vB_WikiCodeParser::handle_bbcode_img() should be compatible with that of vB_BbCodeParser::handle_bbcode_img() in ..../vault/class/bbcode.php on line 2307

Maybe there is some other. Using VaultWiki v3.0.20 PL 1.

Issue Details

Issue Number 3551

Issue Type Bug

Project VaultWiki 3.x Series

Category Wiki Pages

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 3.0.20

Fixed Version (none)

Milestone (none)

Software DependencyvBulletin 4.x

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags upgrade, vbulletin 4.2.2

January 29, 2014 11:31 AM

pegasus

VaultWiki Team

If you are using vBulletin 4.2.2, you must use VaultWiki 4. If you need to import from MediaWiki, do that first though. Based on the last update, VaultWiki 3 has reached End-of-Life. If you can't upgrade yet, follow vBulletin support's instructions to disable error output for old mods.

We might eventually fix these for the new errors but it is unlikely since development is full steam ahead on new updates to version 4.

Reply
January 29, 2014 11:37 AM

DragonSigh

Junior Member

Thanks. Сan I safely install VaultWiki 4 over VaultWiki 3 now? I waited because I saw that all versions of 4 are unstable.

Reply
January 29, 2014 12:21 PM

DragonSigh

Junior Member

Trying to upgrade, but with no luck. Uploaded all files, but when I run /vault/install/index.php it only display "Install" button, not "Upgrade". If I click install it hangs on "Install Progress: 1%" and nothing happens. Followed this instruction: https://www.vaultwiki.org/blogs/56/ as well.

If I logged out from a forum and open /vault/install/index.php again then I see a title:

"VaultWiki v4.0 Upgrader - Permissions Error".

But when I logged in:

"VaultWiki v4.0 Installer - Welcome"

Reply
January 30, 2014 1:07 AM

pegasus

VaultWiki Team

There is a mistake in that blog. Yes, the button should say "Install" or "Continue". If it only gets to install progress 1%, it sounds like there is an error. You will have to look at your logs or try to look at the source for the progress details box. If you have PHP error displays turned off, you might want to turn them on temporarily so you can see the error message.

You can install VaultWiki 4 next to VaultWiki 3, but VaultWiki 3 must be disabled first or the installer will fail almost immediately. This might be the issue.

Reply

January 30, 2014 3:49 AM

DragonSigh DragonSigh is offline

Junior Member

Enabled display of PHP errors and now the progress bar works, but it stopped at 28%:

Code:

Step 5

creating_special_prefix

Step 6

creating_wiki_index

Fatal error: Call to undefined method vw_Parser_Link_Model::build_parse_array() in /var/www/user****/data/www/rpgmaker.su/vault/core/controller/hook/handle/vb3.php(36) : eval()'d code on line 23

January 30, 2014 10:45 AM

pegasus

VaultWiki Team

This occurs when another mod exists tries to use methods from vB's parser that don't exist in VW's parser. We can try to wrap the calls to suppress errors:

In vault/core/model/parser/base/vw.php, find:

Code:

	public function _construct_delayed(&$instance)
	{
		$this->instance =& $instance;
		$this->create_tag_list();
	}

Add after:

Code:

	public function __call($func, $args)
	{
		if (method_exists($this->instance->_default, $func))
		{
			$argCount = count($args);

			if ($argCount == 3)
			{
				return $this->instance->_default->{$func}($args[0], $args[1], $args[2]);
			}
			else if ($argCount == 2)
			{
				return $this->instance->_default->{$func}($args[0], $args[1]);
			}
			else if ($argCount == 1)
			{
				return $this->instance->_default->{$func}($args[0]);
			}
			else
			{
				return $this->instance->_default->{$func}();
			}
		}
		else
		{
			return null;
		}
	}

January 30, 2014 11:22 AM

DragonSigh DragonSigh is offline

Junior Member

pegasus, thanks for your support. Now I installed it successfully. But while Import:

1) It has a lot of:

Could not find phrase 'step_x'.

Could not find phrase 'vw_importing_articles'.

etc.

2) It stopped with this error:

Code:

Database error in vBulletin 4.2.2:

Invalid SQL:
REPLACE INTO `vb_vw_import` (`sourceid`, `targetid`, `name`, `hash`)  VALUES (698,,'attachment','1eb73f22a18e90ede0f5ceacf38fe570'),
	(696,,'attachment','1eb73f22a18e90ede0f5ceacf38fe570'),
	(697,,'attachment','1eb73f22a18e90ede0f5ceacf38fe570');

MySQL Error   : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ''attachment','1eb73f22a18e90ede0f5ceacf38fe570'),
	(696,,'attachment','1eb73f22a' at line 1
Error Number  : 1064
Request Date  : Thursday, January 30th 2014 @ 08:16:32 PM
Error Date    : Thursday, January 30th 2014 @ 08:16:34 PM
Script        : http://rpgmaker.su/admincp/wiki_cp.php?panel=impex&do=import&step=13&nostyle=1
Referrer      : http://rpgmaker.su/admincp/wiki_cp.php?panel=impex&do=import&step=12&nostyle=1
IP Address    : 89.23.203.244
Username      : Arnon
Classname     : vB_Database
MySQL Version : 5.1.49-3

So... I need your help again.

January 30, 2014 11:32 AM

pegasus

VaultWiki Team

In vault/core/controller/dm/attach/vw.php, find:

Code:

	protected function internal_pre_save(&$dm, &$retval)
	{
		$dm->pre_save();

		$errors = $dm->get_errors();

		if (!$errors)
		{
			return;
		}

		$retval = false;

		foreach ($errors AS $errormessage)
		{
			$this->instance->error($errormessage);
		}
	}

Replace it all with:

Code:

	protected function internal_pre_save(&$dm, &$retval)
	{
		if ($retval === null)
		{
			$retval = true;
		}

		$dm->pre_save();

		$errors = $dm->get_errors();

		if (!$errors)
		{
			return $retval;
		}

		$retval = false;

		foreach ($errors AS $errormessage)
		{
			$this->instance->error($errormessage);
		}

		return false;
	}

This should also fix some issues of not being able to upload attachments to the wiki, as noted in other bug reports.

After making the page, reload the importer and it should start where it left off from.

January 30, 2014 11:35 AM

DragonSigh DragonSigh is offline

Junior Member

Thank you. Now I've got this error at the same place:

Code:

Fatal error: Call to undefined method vw_Hard_Core::fetch_hook() in /var/www/user****/data/www/rpgmaker.su/vault/core/model/parser/handle/link/vw.php on line 48

Seems they endless, but I'll hope they not

January 30, 2014 11:47 AM

pegasus

VaultWiki Team

In vault/core/model/parser/handle/link/vw.php, find:

Code:

		$plugin = vw_Hard_Core::fetch_hook('vw_bbcode_linkoption');
		require($plugin->get_controller());

Replace with:

Code:

		vw_Effect::cause('vw_bbcode_linkoption', array(
			'handler' => &$this,
			'tag' => &$open,
			'value' => &$value,
			'option' => &$option,
			'got_option' => &$got_option
		));

January 30, 2014 11:58 AM

DragonSigh

Junior Member

The import process has been successfully completed. You will now be returned to the Admin Panel.

How I am glad to see this message!

Thanks for the super fast responses.

I'll let you know if I'll find any other issues.

Reply
January 30, 2014 12:02 PM

pegasus

VaultWiki Team

Great! Leave VaultWiki 3 installed until you are positive the import didn't mess up. When you do remove the old version, make sure you follow the instructions in that blog or you might remove data that is shared between both versions.

Reply

+ Reply

All times are GMT -4. The time now is 12:43 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Errors after upgrade to vBulletin 4.2.2

Issue Tools