Issue: Deleting language leads to server error

Issue Tools
- View Changes

October 6, 2013 11:20 AM

Alfa1

Distinguished Member

Deleting language leads to server error

My error log shows multiple instances of these:

Code:

ErrorException: Undefined variable: children - vault/core/controller/dm/language/vw.php:77 
Generated By: Alfa1, Today at 2:31 PM

Stack Trace
#0 /vault/core/controller/dm/language/vw.php(77): XenForo_Application::handlePhpError(8, 'Undefined varia...', '/home/myforu...', 77, Array)
#1 /vault/core/controller/dm/language/xf.php(56): vw_DM_Language_Controller->post_delete()
#2 /library/XenForo/DataWriter.php(1767): vw_DM_Language_Controller_XF->_postDelete()
#3 /vault/core/controller/dm/xf.php(416): XenForo_DataWriter->delete()
#4 /vault/core/controller/cp/language/vw.php(116): vw_DM_Controller_XF->delete()
#5 /vault/core/controller/cp/language/vw.php(33): vw_CP_Language_Controller->kill()
#6 /library/vw/XenForo/ControllerAdmin/Wiki.php(94): vw_CP_Language_Controller->execute('kill', 'post')
#7 /library/XenForo/FrontController.php(337): vw_XenForo_ControllerAdmin_Wiki->actionIndex()
#8 /library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#9 /admin.php(13): XenForo_FrontController->run()
#10 {main}
Request State
array(3) {
  ["url"] => string(72) "http://area51.myforum.eu/test4/admin.php?wiki/&panel=language&do=kill"
  ["_GET"] => array(3) {
    ["wiki/"] => string(0) ""
    ["panel"] => string(8) "language"
    ["do"] => string(4) "kill"
  }
  ["_POST"] => array(6) {
    ["panel"] => string(8) "language"
    ["do"] => string(4) "kill"
    ["_xfToken"] => string(8) "********"
    ["languageid"] => string(1) "2"
    ["submit"] => string(3) "Yes"
    ["url"] => string(64) "http://area51.myforum.eu/test4/admin.php?wiki/&panel=language"
  }
}

Code:

ErrorException: Undefined variable: prefixlist - vault/core/controller/dm/language/vw.php:97 
Generated By: Alfa1, Today at 2:31 PM

Stack Trace
#0 /vault/core/controller/dm/language/vw.php(97): XenForo_Application::handlePhpError(8, 'Undefined varia...', '/home/myforu...', 97, Array)
#1 /vault/core/controller/dm/language/xf.php(56): vw_DM_Language_Controller->post_delete()
#2 /library/XenForo/DataWriter.php(1767): vw_DM_Language_Controller_XF->_postDelete()
#3 /vault/core/controller/dm/xf.php(416): XenForo_DataWriter->delete()
#4 /vault/core/controller/cp/language/vw.php(116): vw_DM_Controller_XF->delete()
#5 /vault/core/controller/cp/language/vw.php(33): vw_CP_Language_Controller->kill()
#6 /library/vw/XenForo/ControllerAdmin/Wiki.php(94): vw_CP_Language_Controller->execute('kill', 'post')
#7 /library/XenForo/FrontController.php(337): vw_XenForo_ControllerAdmin_Wiki->actionIndex()
#8 /library/XenForo/FrontController.php(134): XenForo_FrontController->dispatch(Object(XenForo_RouteMatch))
#9 /admin.php(13): XenForo_FrontController->run()
#10 {main}
Request State
array(3) {
  ["url"] => string(72) "http://area51.myforum.eu/test4/admin.php?wiki/&panel=language&do=kill"
  ["_GET"] => array(3) {
    ["wiki/"] => string(0) ""
    ["panel"] => string(8) "language"
    ["do"] => string(4) "kill"
  }
  ["_POST"] => array(6) {
    ["panel"] => string(8) "language"
    ["do"] => string(4) "kill"
    ["_xfToken"] => string(8) "********"
    ["languageid"] => string(1) "2"
    ["submit"] => string(3) "Yes"
    ["url"] => string(64) "http://area51.myforum.eu/test4/admin.php?wiki/&panel=language"
  }
}

Issue Details

Issue Number 3367

Issue Type Bug

Project VaultWiki 4.x Series

Category Languages / Translations

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.0.0 Beta 6

Fixed Version 4.0.0 Beta 7

Milestone VaultWiki 4 Beta X

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 6, 2013 1:15 PM

pegasus

VaultWiki Team

Fixed in the next release. However, I would be wary of removing languages created by the importer. Doing so may make the translations for some imported pages map to the wrong pages or none at all (if translations were used in VW3).

The VW4 importer tries to use the language code of languages to determine if the target database already contains a language before importing it. It is possible that the default language for XenForo would have had a different language code than the default language for vBulletin 3 (maybe 'en' versus 'en-US'). On the other hand the VW3 importer doesn't use this check, and imports all languages anyway.

I have fixed this for the next release, and fixed a bug in the VW4 importer where colliding language codes don't properly map translations.

In the next release, I have added an option when deleting languages to move all pages in that language to a different language. This should allow admins to fix issues where there are three different languages imported for 'de', 'deu', and 'ger', which are all perfectly valid ISO codes for vanilla German, yet all refer to the same language and should be treated as such in the wiki without losing translation links for each one.

So thanks to this report, 2 bugs have been fixed, including potential import data loss, and the admin tool for removing languages has been improved.

Reply
October 19, 2013 7:29 PM

Alfa1

Distinguished Member

In which release will this be fixed? Beta 7 or Beta 6 build 2/3?

Reply

+ Reply

All times are GMT -4. The time now is 6:18 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Deleting language leads to server error

Issue Tools