Issue: Tables no longer sortable after upgrade?

Issue Tools
- View Changes

August 12, 2013 9:49 AM
beernuts

Junior Member
Tables no longer sortable after upgrade?

We just upgraded to PL1 about a week ago. A user has pointed out that since that upgrade, tables are no longer sortable using the

Code:

[table]class="wikitable sortable"

tag.

Please advise.

Issue Details

Issue Number 3291

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Not a Bug

Priority 3 - Loss of Functionality

Affected Version 3.0.20

Fixed Version (none)

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 12, 2013 9:55 AM

pegasus

VaultWiki Team

What version of VaultWiki were you using before the upgrade? PL 1 on its own doesn't change anything about the parser or BB-Codes. It patches bugs in 2 unrelated files.

Reply
August 12, 2013 9:57 AM

beernuts

Junior Member

4.0.20 before the upgrade.

Reply

August 12, 2013 10:11 AM

pegasus

VaultWiki Team

Here is the fix from 4.0.0, which you can safely paste into 3.0.20. In vault/class/bbcode/cleaner.php, find:

Code:

		while (($pos = strpos($attributes, $name . '="', $start)) !== false)
		{
			$start = $pos;
			$remaining = substr($attributes, $pos + 7);
			$pos = strpos($remaining, '"');
			$plus = $pos ? $pos : strlen($remaining);
			$start += $plus + 7;

Replace with:

Code:

		$len = strlen($name);

		while (($pos = strpos($attributes, $name . '="', $start)) !== false)
		{
			$start = $pos;
			$remaining = substr($attributes, $pos + $len + 2);
			$pos = strpos($remaining, '"');
			$plus = $pos ? $pos : strlen($remaining);
			$start += $plus;

August 12, 2013 10:15 AM

pegasus

VaultWiki Team

If there is a problem with the Javascript or the table isn't missing the class in the final output, then I need more to go on. A link to an affected page would help.

Reply
August 12, 2013 10:27 AM
beernuts

Junior Member
I applied that patch to cleaner.php but they're still not working.

The table has the sortable class in the final output, but still no luck.

Code:

http://wiki.badgerandblade.com/Advanced_Wiki_Syntax?redirect=no

has an example table that isn't working.
Reply
August 12, 2013 10:59 AM

pegasus

VaultWiki Team

This was an error in our download area. A blank file called sorttable.js was being included in the ZIP. This is fixed now, so you can download PL 1 again and replace the file clientscript/vault/sorttable.js

Reply
August 12, 2013 6:33 PM

beernuts

Junior Member

That fixed it. Thanks.

Reply
September 3, 2013 5:16 PM

Delfi_r1

Junior Member

I have downladed the patch from 3.20 to 3.2o pl1 and the vB admin says there is an update after uploading the included files

I need to upload the complete package?

Reply
September 4, 2013 10:02 AM

pegasus

VaultWiki Team

No, it is just that the version numbering does not include PL releases, so it thinks you have a different version from the new one. You shouldn't have to do anything if you are already running 3.0.20 PL 1.

Reply

+ Reply

All times are GMT -4. The time now is 1:01 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Tables no longer sortable after upgrade?

Issue Tools