• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 3.x Series
    • Bug
    • Tables no longer sortable after upgrade?

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: Tables no longer sortable after upgrade?

    • Issue Tools
      • View Changes
    1. issueid=3291 August 12, 2013 9:49 AM
      beernuts beernuts is offline
      Junior Member
      Tables no longer sortable after upgrade?

      We just upgraded to PL1 about a week ago. A user has pointed out that since that upgrade, tables are no longer sortable using the

      Code:
      [table]class="wikitable sortable"
      tag.

      Please advise.
    Issue Details
    Issue Number 3291
    Issue Type Bug
    Project VaultWiki 3.x Series
    Category BB-Code Parsing
    Status Not a Bug
    Priority 3 - Loss of Functionality
    Affected Version 3.0.20
    Fixed Version (none)
    Milestone (none)
    Software DependencyAny
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. August 12, 2013 9:55 AM
      pegasus pegasus is offline
      VaultWiki Team
      What version of VaultWiki were you using before the upgrade? PL 1 on its own doesn't change anything about the parser or BB-Codes. It patches bugs in 2 unrelated files.
      Reply Reply  
    2. August 12, 2013 9:57 AM
      beernuts beernuts is offline
      Junior Member
      4.0.20 before the upgrade.
      Reply Reply  
    3. August 12, 2013 10:11 AM
      pegasus pegasus is offline
      VaultWiki Team
      Here is the fix from 4.0.0, which you can safely paste into 3.0.20. In vault/class/bbcode/cleaner.php, find:
      Code:
      		while (($pos = strpos($attributes, $name . '="', $start)) !== false)
      		{
      			$start = $pos;
      			$remaining = substr($attributes, $pos + 7);
      			$pos = strpos($remaining, '"');
      			$plus = $pos ? $pos : strlen($remaining);
      			$start += $plus + 7;
      Replace with:
      Code:
      		$len = strlen($name);
      
      		while (($pos = strpos($attributes, $name . '="', $start)) !== false)
      		{
      			$start = $pos;
      			$remaining = substr($attributes, $pos + $len + 2);
      			$pos = strpos($remaining, '"');
      			$plus = $pos ? $pos : strlen($remaining);
      			$start += $plus;
      Reply Reply  
    4. August 12, 2013 10:15 AM
      pegasus pegasus is offline
      VaultWiki Team
      If there is a problem with the Javascript or the table isn't missing the class in the final output, then I need more to go on. A link to an affected page would help.
      Reply Reply  
    5. August 12, 2013 10:27 AM
      beernuts beernuts is offline
      Junior Member
      I applied that patch to cleaner.php but they're still not working.

      The table has the sortable class in the final output, but still no luck.

      Code:
      http://wiki.badgerandblade.com/Advanced_Wiki_Syntax?redirect=no
      has an example table that isn't working.
      Reply Reply  
    6. August 12, 2013 10:59 AM
      pegasus pegasus is offline
      VaultWiki Team
      This was an error in our download area. A blank file called sorttable.js was being included in the ZIP. This is fixed now, so you can download PL 1 again and replace the file clientscript/vault/sorttable.js
      Reply Reply  
    7. August 12, 2013 6:33 PM
      beernuts beernuts is offline
      Junior Member
      That fixed it. Thanks.
      Reply Reply  
    8. September 3, 2013 5:16 PM
      Delfi_r1 Delfi_r1 is offline
      Junior Member
      I have downladed the patch from 3.20 to 3.2o pl1 and the vB admin says there is an update after uploading the included files

      I need to upload the complete package?
      Reply Reply  
    9. September 4, 2013 10:02 AM
      pegasus pegasus is offline
      VaultWiki Team
      No, it is just that the version numbering does not include PL releases, so it thinks you have a different version from the new one. You shouldn't have to do anything if you are already running 3.0.20 PL 1.
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 1:01 AM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2023 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2023 DragonByte Technologies Ltd.
    Copyright © 2008 - 2013 VaultWiki Team, Cracked Egg Studios, LLC.