Issue: UI and permissions issues in Beta 2

Issue Tools
- View Changes

July 5, 2013 12:30 PM

rizwank

New Member

UI and permissions issues in Beta 2

Code:

An exception occurred: Undefined index: areaids in /home/farearch/site/vault/core/view/ui/assign/vw.php on line 166

XenForo_Application::handlePhpError() in /home/farearch/site/vault/core/view/ui/assign/vw.php at line 166
vw_UI_Assign_View->get_results() in /home/farearch/site/vault/core/view/ui/tools/integrate/vw.php at line 33
vw_UI_Tools_Integrate_View->manage() in /home/farearch/site/vault/core/controller/ui/tools/integrate/vw.php at line 100
vw_UI_Tools_Integrate_Controller->manage() in /home/farearch/site/vault/core/controller/ui/tools/integrate/vw.php at line 34
vw_UI_Tools_Integrate_Controller->execute() in /home/farearch/site/wiki_tools.php at line 56

(only happens when you don't have permissions to view area, it seems)

====

Wiki does not show up in the top toolbar/navbar.

For permissions, please please add a Yes to All (or this category) or No to All.... every time I test this out with you I spend ten minutes on this page. That, and a default Wiki Admin, Wiki Moderator and Wiki User role would be fab. I uninstall and reinstall so many times to help with testing, it's really a nightmare re-setting them up each time.

Layout is disorganized and difficult in XF 1.1.3. Give me an email address and I can send you a screenshot.

Issue Details

Issue Number 3156

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.0.0 Beta 2

Fixed Version 4.0.0 Beta 3

Milestone VaultWiki 4 Beta X

Software DependencyAny

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

July 5, 2013 1:14 PM
pegasus

VaultWiki Team
Yes, I'm well aware of the need for Yes-to-All as I reinstall VaultWiki myself several times every time we release an update. See: https://www.vaultwiki.org/issues/3151/

I agree that VaultWiki should attempt to parse moderator and user permissions to create default roles.

For the UI error you see, I believe it occurs when there are no areas or there are no areas with view permissions. In vault/core/view/ui/assign/vw.php, find:

Code:

if ($input['areaids'] != array(-1))

Replace with:

Code:

if (!empty($input['areaids']) AND $input['areaids'] != array(-1))
Reply
July 5, 2013 3:40 PM

rizwank

New Member

During the beta, can you create a test VW_ALL_ENABLED permission group to speed debugging?

Reply
July 6, 2013 1:22 AM

pegasus

VaultWiki Team

Beta 3 will have Yes/No/Not Set/Never to All for each permission group. Leaving this open until default roles are set by the installer.

Reply
July 6, 2013 4:51 PM

rizwank

New Member

Awesome!

Reply
July 12, 2013 6:51 PM

pegasus

VaultWiki Team

Marked as fixed in the next release. Only admin permissions will be set by the installer (all Yes), since most admins I've dealt with don't want their users to access the wiki until they've set everything up and pre-filled some content.

I also made it so the Yes to All option will Never set an HTML-related permission to Yes. The admin must specifically choose to allow HTML. This should prevent admins from accidentally opening security holes on their sites if they click Yes to All and don't read the permissions that were just turned on.

Reply

+ Reply

All times are GMT -4. The time now is 5:02 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: UI and permissions issues in Beta 2

Issue Tools