Issue: Ampersands in titles breaking page

Issue Tools
- View Changes

January 14, 2013 10:47 AM

beernuts

Junior Member

Ampersands in titles breaking page

When we first installed Vaultwiki, we had this issue. Wiki articles that have an ampersand (and probably othe weird characters as well) are broken and will not load.

http://wiki.badgerandblade.com/B_B_S...=social+groups

The title of the above article is B&B Social Groups, and has always worked fine. After this latest upgrade, though, it appears to be broken again.

Issue Details

Issue Number 2923

Issue Type Bug

Project VaultWiki 3.x Series

Category Wiki Pages

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.20

Fixed Version 3.0.20

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

January 14, 2013 1:23 PM
pegasus

VaultWiki Team
Fixed in the current ZIP. This only occurs on forums that don't use the UTF-8 character set. Thanks for finding this.

In vault/wiki/encode.php, find:

Code:

if (isset($this->replacer[$this->test_langid][$match[1]])) { return $text; }

Replace with:

Code:

if (isset($this->replacer[$this->test_langid][$match[0]])) { return $this->replacer[$this->test_langid][$match[0]]; }
Reply
January 14, 2013 1:45 PM

beernuts

Junior Member

Thanks for the update. Implemented the code change but still experiencing this issue.

Reply
January 14, 2013 3:46 PM

pegasus

VaultWiki Team

Edited the replace code above, there were some 1s that should have been 0s.

Reply

January 14, 2013 4:01 PM

beernuts

Junior Member

Still not working. Here is that chunk:

Code:

function replace_test($match)
	{
		if (isset($this->replacer[$this->test_langid][$match[0]]))
		{
			return $this->replacer[$this->test_langid][$match[0]];
		}

		return ' ';
	}

Does that look right? Do I need to clear the cache for this to work?

January 14, 2013 4:17 PM

pegasus

VaultWiki Team

If you rebuilt URLs already when you noticed the problem, then yes, you would need to rebuild them again now that the problem is fixed.

Reply
January 16, 2013 5:38 PM

fj123

Regular Member

After you guys did my upgrade and then I discovered we were missing some entries, I finally tracked the problem to this one with the ampersand. I did the above change and we now have our entries back but some of them are not showing up in our wiki searches. Is there something else I need to do to get those to be in the search results?

Reply
January 23, 2013 3:17 PM

fj123

Regular Member

Hi, I know you guys are up to your ears in the upgrade but I am still having problems with my wiki searches not producing results as it should. This is new since my upgrade.

Reply
January 24, 2013 2:05 PM

pegasus

VaultWiki Team

Are they producing NO results at all, or are only some articles missing? If only some are missing, it would help if you could discern a pattern, how the articles are named, when they were created, etc.

Reply
January 28, 2013 9:34 AM

fj123

Regular Member

just some missing articles....... and no, I have tried to discern a pattern but cannot find one. I have been beating my head on this for what, a week now and just cannot figure out any commonality.

Here is an example.

Boca Raton

Boca Raton Resort

Boca Raton Resort 2

(now, this is with the ampersands completely removed as a test even)

If you search Boca Raton, one would expect that you would get all 3 results. But what you get is that it jumps to the first Boca Raton article and does not show a list at all. So you miss the other two completely.

Now, if you search Boca Raton Resort, you do get a list, but the results only show Boca Raton and Boca Raton Resort 2. The Boca Raton Resort just does not show in the results at all.

Reply
January 28, 2013 2:12 PM

pegasus

VaultWiki Team

When performing a wiki search, if an article matches exactly, it jumps to that article. This is expected behavior. The only way to avoid this is to use a vBulletin common or advanced search.

I'm not sure why Boca Raton Resort is not listed. There is a possibility it is missing from the search index. Unfortunately, the search index is generated and controlled by vBulletin itself so there's not much we can do in this regard. If it's not showing, you can try to edit the article to queue it to be added again.

Reply
February 8, 2013 9:28 AM

fj123

Regular Member

Originally Posted by pegasus

When performing a wiki search, if an article matches exactly, it jumps to that article. This is expected behavior. The only way to avoid this is to use a vBulletin common or advanced search.

I'm not sure why Boca Raton Resort is not listed. There is a possibility it is missing from the search index. Unfortunately, the search index is generated and controlled by vBulletin itself so there's not much we can do in this regard. If it's not showing, you can try to edit the article to queue it to be added again.

It is definitely in the search index because the main VB search brings up the entry. But we tried editing it anyway and that did not help. (and both of these articles were created just a few days of each other, over 4 years ago)

It certainly makes me wonder how many other entires are missing in the search results.

I also have to say I am not sure i see the logic in an exact match jumping directly to the article. A person searching has no way of knowing whether or not there is more than one match and runs the risk of missing other entries.

Reply
February 8, 2013 9:29 AM

fj123

Regular Member

I should also add, this appears to no longer be an ampersand issue being as we took those out, trying to test it. But am still posting in this thread being as it started with the ampersands.

Reply
February 11, 2013 1:12 PM
pegasus

VaultWiki Team
From what I can tell, all the pages are showing up correctly in searches, at least since you renamed them.

As for the exact match jumping, this is an optional item in the search form, but it seems that it is a bug where it jumps even when you select not to. In vault/plugins/search.php, find:

Code:

if (!VAULT_40X_COMPAT) { special_search_goto_article(); }

Replace with:

Code:

if (VAULT_40X_COMPAT) { if (isset($_POST['titleonly'])) { $_POST['gotoarticle'] = $_POST['titleonly'] == 2; } } else { special_search_goto_article(); }
Reply
February 18, 2013 9:46 AM

fj123

Regular Member

Are you using the search form on my actually wiki page or the search that is linked at the top of the main forum?

Thanks, I will replace that in my search.php file, thanks for that fix!

Reply

+ Reply

All times are GMT -4. The time now is 5:13 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Ampersands in titles breaking page

Issue Tools