Issue: AJAX Responses Cut Short

Issue Tools
- View Changes

October 12, 2012 3:13 PM

pegasus

VaultWiki Team

AJAX Responses Cut Short

This took a while to figure out, but there was a problem with AJAX responses where the values of some tags were being truncated. This was especially problematic for long post content, editors, etc retrieved using AJAX. Specifically, this can lead to data loss when performing AJAX edits when all of the section content was not loaded into the editor due to this issue.

The cause: apparently under Firefox, the firstChild.nodeValue property of an XML node is limited to a maximum of 4096 characters. See: http://www.coderholic.com/firefox-4k-xml-node-limit/

This problem exists for all versions of VaultWiki (and vBulletin). This has been fixed in VaultWiki 4 using a wrapper for fetching the node value that attempts to build the full value from other properties. Backporting the fix to VaultWiki 3 now. Will issue a 3.0.20 release this weekend to address with the issue.

Issue Details

Issue Number 2878

Issue Type Bug

Project VaultWiki 3.x Series

Category Text Editor (WYSIWYG, etc)

Status Fixed

Priority 1 - Security / Login / Data Loss

Affected Version 3.0.19

Fixed Version (none)

Milestone VaultWiki 4.0.0 Alpha 1

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 12, 2012 3:38 PM

pegasus

VaultWiki Team

Fixed in VaultWiki 3.0.20 for the AJAX actions controlled directly by VaultWiki.

For vBulletin page actions or default vBulletin AJAX actions that are called in VaultWiki, any code issues that may lead to data loss are the responsibility of vBulletin devs to correct.

Reply
October 12, 2012 4:52 PM

pegasus

VaultWiki Team

Apparently this bug only occurs if the node value is of a text node that is not wrapped in a CDATA section. So this only applied to some responses in VaultWiki 4 under XenForo, but these are now wrapped in CDATA sections. Either way, all references to firstChild.nodeValue are now wrapped, in case behavior changes due to a fix, or CDATA doesn't save it in other browsers with the issue: Opera has a 32KB limit and Safari has a 64KB limit, albeit better than Firefox's 4KB but attainable nonetheless, and I haven't read any tests confirming or denying the CDATA workaround for these other browsers.

Reply

+ Reply

All times are GMT -4. The time now is 9:13 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: AJAX Responses Cut Short

Issue Tools