Issue: H2 tag in template: vault_article_usage and vault_article_chapterlist

Issue Tools
- View Changes

October 24, 2011 9:53 AM

Lord Doys

Junior Member

H2 tag in template: vault_article_usage and vault_article_chapterlist

Today i was playing around with Cufón and changing ALL my H1 and H2 into some nice looking font.. (just for testing cufon)

But then i noticed the SHOW - TOP - EDIT were changesd as well..

then i looked at the two in the title mentioned templates and noticed they are indeed placed between the <h2> and </h2> tags...

Code:

<h2 class="vw-head"><span class="top_link"><a id="collapseimg_{vb:raw post.postid}_template_usage" href="{vb:var relpath}#top" onclick="return vB_Section.toggle({vb:raw post.postid}, 'template_usage')" title="" style="display: none">{vb:rawphrase special_hide}</a><a href="{vb:var relpath}#top" onclick="return Toc_Jump('top')">{vb:rawphrase special_top}</a></span>{vb:rawphrase vault_usage_in}</h2>

and

Code:

<h2 class="vw-head">
	<span class="top_link"><vb:if condition="$show['popups']"><a id="collapseimg_{vb:raw post.postid}_chapters" href="{vb:var relpath}#top" onclick="return vB_Section.toggle({vb:raw post.postid}, 'chapters')" title="" style="display:none">{vb:rawphrase special_hide}</a></vb:if><a href="{vb:var relpath}#top">{vb:rawphrase special_top}</a></span>
	<a name="table_of_contents"></a>
	{vb:rawphrase vault_toc}
	<vb:if condition="$show['add_new_chapter']">
	<a class="chapter_ctrl" href="{vb:raw threadinfo.url_s}do=book&amp;action=newchapter" title="{vb:rawphrase vault_new_chapter_ctrl}">
		<img border="0" src="{vb:stylevar imgdir_misc}/add.png" alt="" width="16" height="16" />
	</a>
	</vb:if>
</h2>

Is this intentional? or should they be outside the H2 as i would suspect?
..this is also the case with the H1 tags btw

Issue Details

Issue Number 2515

Issue Type Bug

Project VaultWiki 3.x Series

Category Headlines / Sections

Status Fixed

Priority 8 - Major Features / Enhancements

Affected Version 3.0.14

Fixed Version 4.0.0 Alpha 1

Milestone VaultWiki 4.0.0 Alpha 1

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 24, 2011 4:12 PM

pegasus

VaultWiki Team

This is intentional. This is the way all headline tags are designed in VaultWiki 3. Also, the hide link relies that there is a parent h2,3,4,etc tag present in order for the show/hide effect to work properly.

If you want to style them differently, you can always add more classes to the headline (keep vw-head intact), and style the headline using your extra CSS classes. This has the added benefit (over template edits) of being less likely to break during a VaultWiki upgrade.

Reply
October 24, 2011 5:11 PM

Lord Doys

Junior Member

meh.. everything got tags, classes or IDs... EXCEPT the text that actually IS the H1 or H2 (since its between the H tags) i simply cannot reach the text solely without affecting the span..

i dont like editing templates indeed, i try to overwrite everything in additional.css

what is the main template for the H2 for a wiki article..
i found a bunch changed some code, but none of them affected the wiki article display

Reply

October 24, 2011 5:38 PM

Lord Doys

Junior Member

i see what you mean... this part is not template based.
Its that piece of code in headline.php

Code:

	$class = 'vw-head';
	$id = 'vw-head-' . $parser->edit_heading;

	if ($noedit)
	{
		$class .= ' ignore';
	}

	$html = $break;
	$html .= "<h$option class=\"$class2\" id=\"$id\">";
	$html .= '<span class="$class top_link"><!-- vault[floaty] --></span>';
	$html .= "<a name=\"$anchor_name\"></a>$text</h$option>";

October 24, 2011 5:50 PM

Lord Doys

Junior Member

guess the only way is to place a span around $text

then let cufon replace like: 'h2.vw-head span.wikihead, h3.vw-head span.wikihead'

Reply
October 25, 2011 12:40 AM

pegasus

VaultWiki Team

Moved to an improvement request. Will look into adjusting this code when we re-template everything in 4.0.0 Beta 1.

Reply
October 25, 2011 9:48 AM

Lord Doys

Junior Member

cheers

Reply
February 14, 2012 6:40 PM
pegasus

VaultWiki Team
Updated for 4.0.0 Alpha 1. Will be wrapped in span.vw-head-text

In the mean time, you can already do the following in CSS:

Code:

.vw-head { /*css-stuff*/ } .vw-head .top_link { /*undo that stuff for the edit-top-hide links*/ }
Reply

+ Reply

All times are GMT -4. The time now is 9:11 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: H2 tag in template: vault_article_usage and vault_article_chapterlist

Issue Tools