Issue: vb 4.1.7 and tables problem

Issue Tools
- View Changes

October 10, 2011 11:12 AM

Feathers&Photos

New Member

vb 4.1.7 and tables problem

I've just upgraded to vb 4.1.7 and have now found all tables created are shown with a full grid regardless of what code is used in the table. Running VW 3.0.14 build 002.

Issue Details

Issue Number 2488

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 3.0.14

Fixed Version 3.0.15

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags Table

October 10, 2011 5:55 PM

pegasus

VaultWiki Team

Not sure what you mean. Do you have a picture or link?

Reply
October 11, 2011 1:26 AM

Feathers&Photos

New Member

If I create a table and choose for example, 'no border' the table appears correctly in the editor. However once posted the table always appears with a full grid. Example here.

No border in editor

With outer border in editor

All tables appear with a full grid once posted

Reply
October 11, 2011 11:58 AM

pegasus

VaultWiki Team

The HTML output for the example you posted suggests that you are using the table BB-Code that came with vB 4.1.4+, and not the table BB-Code that came with VaultWiki. Is this correct? I'm afraid my knowledge only extends to the VaultWiki table code, but it looks like the appropriate no-border class is not being applied to your table.

Reply
October 11, 2011 10:29 PM
Feathers&Photos

New Member
I thought I was using VW code? When I insert a table using the editor buttons the code I have for that table is:

Code:

[TABLE] |- | 1 | 2 |- | 3 | 4 |- | 5 | 6 |- [/TABLE]

When I disable VW and use tables the code resembles the following and appears correctly in a post.

Code:

[TABLE="class: outer_border"] [TR] [TD]1[/TD] [TD]2[/TD] [/TR] [TR] [TD]3[/TD] [TD]4[/TD] [/TR] [TR] [TD]5[/TD] [TD]6[/TD] [/TR] [/TABLE]

I've updated the post with more table examples HERE.
Reply
October 12, 2011 2:18 AM

pegasus

VaultWiki Team

This is now fixed for the next release. Existing tables will still be styled incorrectly because they were already saved with an invalid style.

Reply
October 17, 2011 3:44 AM
Feathers&Photos

New Member
Hi Pegasus,

I've upgraded to 3.0.14 build 003 and I'm still experiencing problems when creating tables as they still have a full grid no matter what settings I use. Has build 003 got a fix in it, or is there something else I need to do to fix this issue?

When I use the editor to insert a table with no borders the code looks like the following, but I still get a full grid on the table...

Code:

[TABLE] |- | 1 | 2 |- | 3 | 4 |- | 5 | 6 |- [/TABLE]
Reply
October 17, 2011 3:54 AM

pegasus

VaultWiki Team

Build 003 does not include this fix, as it was released before this fix. This requires changes (some complex) to a number of different files in order to fix, so it has not been posted here.

Some info: the issue is that the classes for tables shown in the WYSIWYG editor are not the same classes that should be applied to a saved version of the table. A two-way conversion needs to take place, and this is not something that's supported by the current attribute cleaner that VaultWiki uses in 3.0.14.

Reply
November 20, 2011 9:19 PM

Feathers&Photos

New Member

I've upgraded to 3.0.15 and I still get full borders around any tables I create when I turn on and use vaultwiki's table code. Am I doing something wrong here?

Reply
November 21, 2011 4:42 AM
pegasus

VaultWiki Team
If the table was already created before the upgrade or was created before turning VaultWiki's table code on, you will still get borders because the tables were saved with the wrong classes.

Also, if the table is edited again after it gets the correct class, it will lose the class again. Fix by modifying vault/class/bbcode/cleaner.php. Find:

Code:

$classbit = substr_replace($classbit, 'wysiwyg_', 0, 10);

Replace with:

Code:

$classbit = 'wysiwyg_' . $classbit;

This is working correctly in TestArjan
Reply
November 21, 2011 5:55 AM

Feathers&Photos

New Member

Thanks Pegasus, I've made the change to cleaner.php. Is there anything else I need to do? I'm still getting borders around all the tables.

Reply

+ Reply

All times are GMT -4. The time now is 11:06 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: vb 4.1.7 and tables problem

Issue Tools