not being converted to proper bb code

Issue Tools
- View Changes

October 1, 2011 5:30 PM

Lord Doys

Junior Member

<noinclude> and <includeonly> not being converted to proper bb code

<noinclude> and <includeonly> not being converted to proper bb code

I have noticed after the conversion from mediawiki that the <noinclude> and <includeonly> tags are not converted to the proper BB code

more then 100 templates of my wiki are affected by this

Code:

<noinclude>[category]Article Type Templates|[var]PAGENAME[/var[/category]]
</noinclude>[template]articletype
|type=a [wiki="WotC Article"][span] style="color:#999999;" |
WotC Article
[/span][/wiki]
|text=The contents herein are entirely [wiki]copyright[/wiki]ed to Wizards of the Coast and represent official [wiki="Birthright"]<font style="color:#aaaaaa;">Birthright</font>[/wiki] lore.
<small>©1996-2010 [wiki]Wizards of the Coast[/wiki], Inc.</small>
|icon=[image]wizards.gif[/image]
|page=Wizards of the Coast
|icontext=Wizards of the Coast
[/template]
<includeonly>[category]WotC[/category]</includeonly>
<includeonly>[category]Birthright publication[/category]</includeonly>

Issue Details

Issue Number 2473

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.14

Fixed Version 3.0.15

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags Import

October 1, 2011 9:50 PM

pegasus

VaultWiki Team

Fixed for the next release. In vault/class/bbcode/convert.php, find and delete:

Code:

			}
			else if (TEMPLATE_SPACE AND $this->recursion['level'] > 1)
			{
				if (!$this->template_parser)
				{
					require_once(DIR . '/vault/class/bbcode/template.php');
					$this->template_parser = new vB_TemplateCodeParser($this);
				}

October 1, 2011 9:54 PM

pegasus

VaultWiki Team

Keep in mind that you can always turn on global MediaWiki Syntax support in the mod's settings if you don't have enough time to update them all right away. Just also remember to edit and write pages like it's turned off, because as you've seen, not all conversions work 100% of the time.

Reply
October 7, 2011 2:31 PM

Lord Doys

Junior Member

removing the code didnt solve the issue

Reply
October 7, 2011 3:33 PM

pegasus

VaultWiki Team

Okay fixed. Different parts of the parser didn't use a standard method of determining if conversion was taking place or legacy code was active. This is now handled by a $do_legacy property in the parser. Since this involves changes to a large number of files, I won't be posting the changes here. Instead, I'll be merging the changes into Build 003 later today.

Reply
October 7, 2011 5:07 PM

Lord Doys

Junior Member

cheers

a quick and dirty find and replace all in a sql dump did the job as well

Reply

+ Reply

All times are GMT -4. The time now is 11:42 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: <noinclude> and <includeonly> not being converted to proper bb code

Issue Tools