Issue: Reported edit does not show which edit is reported.

Issue Tools
- View Changes

September 29, 2011 1:55 PM

Alfa1

Distinguished Member

Reported edit does not show which edit is reported.

If a user reports a wiki edit, then the report in the post report forum does not mention which edit was reported. If there are a lot of edits, then its almost impossible to find what the report was about.

This may not necessarily be a bug, but would be nice to see this fixed none the less.

Issue Details

Issue Number 2472

Issue Type Bug

Project VaultWiki 3.x Series

Category History / Revisions

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.14

Fixed Version 3.0.15

Milestone (none)

Software DependencyvBulletin 3.8

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 29, 2011 2:40 PM

pegasus

VaultWiki Team

Can you paste an example post, or link to one? Everything looks fine on the code side.

Reply
September 30, 2011 2:51 PM

Alfa1

Distinguished Member

http://awesomescreenshot.com/047lhxa85

or go to showthread.php?t=168740

Reply
October 1, 2011 4:44 AM

pegasus

VaultWiki Team

First, let me clarify: it is possible to report the page as a whole, or individual edits.

This depends if you used the Report link from the main tab, or from a history action. If a page is reported, it doesn't refer to a particular edit, because the entire page (or the current version) needs to be reviewed. This is working as designed.

When I report a page here, and separately report an edit here, I see that the message for both reported pages and reported edits use the word "page" - however, the link the message includes for review is correct. If an edit was reported, the link points to the specific edit.

Reply
October 1, 2011 7:58 PM

Alfa1

Distinguished Member

I reported a specific edit (from the revisions tab), but it shows as a report for the page.

Reply
October 1, 2011 9:29 PM

pegasus

VaultWiki Team

As I mentioned, the post erroneously uses the word "page", but the link for review actually points to the reported revision. I have tested this a number of times here since you reported the issue.

Reply
October 2, 2011 12:11 AM

Alfa1

Distinguished Member

showthread.php?p=1035016#post1035016

This is a post report generated from a specific edit. Yet it links to showwiki.php?title=Member_groups

Reply

October 2, 2011 8:02 AM

pegasus

VaultWiki Team

Okay it looks like the plugin in the vBulletin 3 XML is wrong. In your Plugin Manager, edit the VaultWiki plugin for hook report_start. The code should be as follows:

Code:

if ($_REQUEST['oldid'])
{
	$vbulletin->input->clean_gpc('r', 'oldid', TYPE_UINT);

	$revision = $db->query_first("
		SELECT *
		FROM " . TABLE_PREFIX . "vault_revision
		WHERE revisionid = " . intval($vbulletin->GPC['oldid']) . "
	");
}

if ($foruminfo['vault_type'] > 0 AND $threadinfo['firstpostid'] == $postinfo['postid'])
{
	require_once(DIR . '/vault/class/reportitem.php');
	$reportobj = new vB_ReportItem_Vault_Article($vbulletin);

	// re-set info, already passed floodcheck
	$reportobj->set_extrainfo('forum', $foruminfo);
	$reportobj->set_extrainfo('thread', $threadinfo);

	if ($revision)
	{
		$reportobj->set_extrainfo('revision', $revision);
	}
}

Update if needed.

October 2, 2011 4:38 PM

Alfa1

Distinguished Member

It was this:

Code:

if ($foruminfo['vault_type'] > 0 AND $threadinfo['firstpostid'] == $postinfo['postid'])
{
	require_once(DIR . '/vault/class/reportitem.php');
	$reportobj =& new vB_ReportItem_Vault_Article($vbulletin);

	// re-set info, already passed floodcheck
	$reportobj->set_extrainfo('forum', $foruminfo);
	$reportobj->set_extrainfo('thread', $threadinfo);
}

October 2, 2011 4:49 PM

Alfa1

Distinguished Member

After changing the plugin content, the link goes to:
showwiki.php?title=Member_groups&do=history&actio n=revision&oldid=5436
However, that does not show what was edited.

Reply

+ Reply

All times are GMT -4. The time now is 3:04 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Reported edit does not show which edit is reported.

Issue Tools