Issue: After MediaWiki Import <div> tags

Issue Tools
- View Changes

June 29, 2011 2:07 PM

MGP_Tech

New Member

After MediaWiki Import <div> tags

We have a large number of excess <div> tags

After a successful import of our MediaWiki data, the only issue on pages I am seeing now is that they all contain excess <div> tags instead of line breaks. I don't want to have to manually edit every page to remove these, is there a better way?

Issue Details

Issue Number 2388

Issue Type Bug

Project VaultWiki 3.x Series

Category Wiki Pages

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 3.0.12

Fixed Version 3.0.13

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

June 29, 2011 2:51 PM

pegasus

VaultWiki Team

This is intentional and working as designed. Line breaks are left as line breaks. <br> tags are replaced with [div] tags, since most vB installs have HTML disabled. If the [ DIV ] tags are showing in your output, they may be disabled in AdminCP > VaultWiki > Wiki Code Manager. Turn them on to get them to parse.

EDIT: If you're allowing HTML in your wiki forums, this may cause issues now that I think about it. I've adjusted the code so that it leaves <br> tags alone if HTML is enabled.

In vault/class/bbcode/legacy/mediawiki.php, find:

Code:

	function parse_line_breaks($text)
	{
		if ($this->do_html())
		{
			$pattern = '#\&lt;br([^\&gt;]*)/?\&gt;#sU';
		}
		else
		{
			$pattern = '#&amp;lt;br(.*)/?&amp;gt;#sU';
		}

		if ($this->parser->fake_tags)
		{
			return $this->parse_fake($pattern, $text);
		}

		if (preg_match_all($pattern, $text, $matches))
		{
			foreach ($matches[0] AS $key => $search)
			{
				$replacement = '[div] ';
				$attrs = trim($matches[1]["$key"]);

				if ($attrs)
				{
					$replacement .= $attrs . ' | ';
				}

				$replacement .= '[/div]';

				$text = str_replace($search, $this->noedit($replacement), $text);
			}
		}

		$text = preg_replace('#(?:\r\n+|\r+|\n+)#s', "\r\n", $text);

		return $text;
	}

Replace with:

Code:

	function parse_line_breaks($text)
	{
		if ($this->do_html())
		{
			$pattern = '';
		}
		else
		{
			$pattern = '#&amp;lt;br(.*)/?&amp;gt;#sU';
		}

		if ($pattern)
		{
			if ($this->parser->fake_tags)
			{
				return $this->parse_fake($pattern, $text);
			}

			if (preg_match_all($pattern, $text, $matches))
			{
				foreach ($matches[0] AS $key => $search)
				{
					$replacement = '[div] ';
					$attrs = trim($matches[1]["$key"]);

					if ($attrs)
					{
						$replacement .= $attrs . ' | ';
					}

					$replacement .= '[/div]';

					$text = str_replace($search, $this->noedit($replacement), $text);
				}
			}
		}
		else if ($this->parser->fake_tags)
		{
			return $text;
		}

		$text = preg_replace('#(?:\r\n+|\r+|\n+)#s', "\r\n", $text);

		return $text;
	}

June 29, 2011 3:04 PM

MGP_Tech

New Member

Thank you! Enabling them did the trick, they are no longer showing up on the pages.

edit: I made the change you suggested as well.

Reply

+ Reply

All times are GMT -4. The time now is 5:48 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: After MediaWiki Import <div> tags

Issue Tools