Issue: Approving edit, deletes it

Issue Tools
- View Changes

May 3, 2011 2:18 PM

Alfa1

Distinguished Member

Approving edit, deletes it

Edits that are approved by a moderator get deleted instead.

Please see threadid: 158044

Issue Details

Issue Number 2289

Issue Type Bug

Project VaultWiki 3.x Series

Category Inline Moderation

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 3.0.11

Fixed Version 3.0.12

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

May 3, 2011 2:22 PM

pegasus

VaultWiki Team

Deleted or un-approved? I can't see how a delete would take place as a dm->save() is called.
I also can't see how the mod might accidentally choose "purge" instead since there is a bug in vBulletin 3 where calling purge only executes a rollback.

Reply
May 3, 2011 2:25 PM

Alfa1

Distinguished Member

The edit is gone afterwards.

Reply
May 3, 2011 2:51 PM
pegasus

VaultWiki Team
I see it now. In vault/tab/inlinemod.php, find:

Code:

$db->query_write(" DELETE FROM " . TABLE_PREFIX . "vault_revision WHERE revisionid = " . intval($revision['revisionid']) . " "); $rolldata->save();

Replace with:

Code:

$rolldata->save();

This DELETE query was originally here because the approval process created a new edit with the same information, so the old unapproved version needed to be removed. However, a few versions back we optimized this using a flag to tell the DM to use an UPDATE instead of an INSERT. It seems we forgot to remove the DELETE when we made that change.
Reply
May 3, 2011 2:58 PM

Alfa1

Distinguished Member

Thanks!

Reply

+ Reply

All times are GMT -4. The time now is 11:56 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Approving edit, deletes it

Issue Tools