• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 3.x Series
    • Bug
    • Approving edit, deletes it

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: Approving edit, deletes it

    • Issue Tools
      • View Changes
    1. issueid=2289 May 3, 2011 2:18 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Approving edit, deletes it

      Edits that are approved by a moderator get deleted instead.

      Please see threadid: 158044
    Issue Details
    Issue Number 2289
    Issue Type Bug
    Project VaultWiki 3.x Series
    Category Inline Moderation
    Status Fixed
    Priority 5 - Minor Bugs / Small Tweaks
    Affected Version 3.0.11
    Fixed Version 3.0.12
    Milestone (none)
    Software DependencyAny
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. May 3, 2011 2:22 PM
      pegasus pegasus is offline
      VaultWiki Team
      Deleted or un-approved? I can't see how a delete would take place as a dm->save() is called.
      I also can't see how the mod might accidentally choose "purge" instead since there is a bug in vBulletin 3 where calling purge only executes a rollback.
      Reply Reply  
    2. May 3, 2011 2:25 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      The edit is gone afterwards.
      Reply Reply  
    3. May 3, 2011 2:51 PM
      pegasus pegasus is offline
      VaultWiki Team
      I see it now. In vault/tab/inlinemod.php, find:
      Code:
      			$db->query_write("
      				DELETE FROM " . TABLE_PREFIX . "vault_revision
      				WHERE revisionid = " . intval($revision['revisionid']) . "
      			");
      
      			$rolldata->save();
      Replace with:
      Code:
      			$rolldata->save();
      This DELETE query was originally here because the approval process created a new edit with the same information, so the old unapproved version needed to be removed. However, a few versions back we optimized this using a flag to tell the DM to use an UPDATE instead of an INSERT. It seems we forgot to remove the DELETE when we made that change.
      Reply Reply  
    4. May 3, 2011 2:58 PM
      Alfa1 Alfa1 is offline
      Distinguished Member
      Thanks!
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 11:56 AM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2023 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2023 DragonByte Technologies Ltd.
    Copyright © 2008 - 2013 VaultWiki Team, Cracked Egg Studios, LLC.