redirect=no This does not exist and results in a 404.

Issue Tools
- View Changes

March 12, 2011 3:12 PM

Alfa1

Distinguished Member

After reverting an edit VW redirects to: /forum/redirect=no This does not exist and results in a 404.

After reverting an edit VW redirects to: /forum/redirect=no

This does not exist and results in a 404.

Issue Details

Issue Number 2258

Issue Type Bug

Project VaultWiki 3.x Series

Category History / Revisions

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 3.0.11

Fixed Version 3.0.12

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

March 13, 2011 2:42 PM
pegasus

VaultWiki Team
In vault/tab/history.php, find:

Code:

if ( $rolldata->fetch_field('title') != $rolldata->existing['title'] OR $rolldata->fetch_field('prefixid') != $rolldata->existing['prefixid'] ) { $vault->fetch_instance('url'); $vault->url->generate($threadinfo); }

Replace with:

Code:

$vault->fetch_instance('url'); $vault->url->generate($threadinfo);

This happens because although the URL for the current thread was already generated, a rollback is performed with the is_automated flag, which re-gets $threadinfo from the $threadcache (pre-URL) before performing the rollback (this is a feature for mass- handling). Since the $threadcache didn't have the URL, we ended up sending an empty value to the redirect.
Reply

+ Reply

All times are GMT -4. The time now is 6:04 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: After reverting an edit VW redirects to: /forum/redirect=no This does not exist and results in a 404.

Issue Tools