Issue: Malformed Compare URL Leads to DB Error

Issue Tools
- View Changes

February 18, 2011 12:58 PM
pegasus

VaultWiki Team
Malformed Compare URL Leads to DB Error

When comparing versions of an article, editing the URL so that:

both oldid and oldid2 are strings
one of oldid or oldid2 is missing
one of oldid or oldid2 is a string other than "next" or "prev"

A database error will occur, or a generic revision not found message will appear.

Instead, the logic should be improved such that:

If both are strings, the current revision is compared with the previous revision.
If one is missing, the specified revision is compared with the previous revision.
Other strings will fail without a database error.

Fixed for the next build.

Issue Details

Issue Number 2240

Issue Type Bug

Project VaultWiki 3.x Series

Category History / Revisions

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 3.0.10

Fixed Version 3.0.11

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 8, 2015 6:36 PM

pegasus

VaultWiki Team

This was incorrectly flagged, announced, and patched as a cross-site scripting error. It was a regular old database error.

Reply

+ Reply

All times are GMT -4. The time now is 6:26 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Malformed Compare URL Leads to DB Error

Issue Tools