Issue: Edits awaiting moderation are not there

Issue Tools
- View Changes

November 15, 2010 6:59 PM

Alfa1

Distinguished Member

Edits awaiting moderation are not there

In my adminCP I see there is an edit waiting to be moderated. However when arriving at the article history page, there is no edit waiting to be approved.

Issue Details

Issue Number 2082

Issue Type Bug

Project VaultWiki 3.x Series

Category Inline Moderation

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 3.0.5

Fixed Version 3.0.6

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

November 16, 2010 12:23 AM
pegasus

VaultWiki Team
This happens if you edit the article, your edit goes into the moderation queue, and you proceed to import edits after that.
This can also occur if you import edits, delete them from the database manually, and your database is set up to fill in un-used auto_increment values.
Your edits will also not appear in chronological order if they were imported.

The following changes to vault/functions/history.php should restore the "approve" option for the affected revisions, and fix the sort order. Find:

Code:

LEFT JOIN " . TABLE_PREFIX . "vault_revision AS previous ON (previous.revisionid < revision.revisionid AND previous.threadid = revision.threadid)

Replace with:

Code:

LEFT JOIN " . TABLE_PREFIX . "vault_revision AS previous ON (previous.dateline < revision.dateline AND previous.threadid = revision.threadid)

Find:

Code:

GROUP BY revision.revisionid ORDER BY revision.revisionid DESC

Replace with:

Code:

GROUP BY revision.revisionid ORDER BY revision.dateline DESC

Find (x2):

Code:

ORDER BY revisionid

Replace with:

Code:

ORDER BY dateline
Reply
November 16, 2010 12:04 PM

Alfa1

Distinguished Member

Im 100% sure that no article was edited while importing. I did not delete anything from the DB.
The sort order is correct.

Reply
November 16, 2010 12:12 PM

pegasus

VaultWiki Team

Not WHILE importing, just needed to be edited BEFORE importing. Technically this is possible in a NuWiki import because you set up the wiki forums before importing. If the article was already edited, but you performed the import afterwards, the most recent edit would actually be pushed to the bottom of the edit list behind the imported ones, and resulting in this issue. The file edits above should fix it without having to import again.

Reply
November 16, 2010 12:18 PM

Alfa1

Distinguished Member

All articles where edited some weeks or more, before the import, as its an wiki category active since 2007.
The most recent edit is at the top of the edit list. The bottom of the edit list has the oldest edit.
Does that mean that there is another issue, or am i misunderstanding?

Reply
November 16, 2010 12:30 PM
pegasus

VaultWiki Team
Okay, this is unique to your installation now because it is a side effect of the errors during the edit imports you reported several days ago. Because the 'lastrevisionid' field is missing for each revision, your pending edit is being interpreted by the History tab as the only edit, and thus, it believes that it cannot be pending.

In vault/functions/history.php, find:

Code:

if ($revision['pending'] AND $revision['current_revisionid'] > 0)

And replace with:

Code:

if ($revision['pending'])

Once you approve that edit, you will want to change this back since it can have other bad effects.
Reply
November 16, 2010 12:45 PM

Alfa1

Distinguished Member

That does not solve it yet. Is there anything I need to do?

Reply

+ Reply

All times are GMT -4. The time now is 9:03 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Edits awaiting moderation are not there

Issue Tools