• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 3.x Series
    • Bug
    • Table Row Style Ignored

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: Table Row Style Ignored

    • Issue Tools
      • View Changes
    1. issueid=2048 October 26, 2010 5:10 AM
      Moses Moses is offline
      Junior Member
      Table Row Style Ignored

      I just ran this upgrade, having a few issues.

      Autolinks no longer show the pop-up preview.
      Navbar no longer contains wiki specific context
      Table CSS is no longer working at the table row level, so the following table (and hundreds like it) are now plain.

      Code:
      [table] border-color: #e7edbe;
      |- style="background: #728557; color: #e9e375;"
      | colspan="5" | [B]Props[/B]
      
      |- style="text-align: center;"
      | [IMAGE]James Slipper.jpg|thumb|right|150px[/IMAGE]
      [WIKI]James Slipper[/WIKI]
      113kg
      Tighthead / Loosehead
      | [IMAGE]Greg Holmes.jpg|thumb|right|150px[/IMAGE]
      [WIKI]Greg Holmes[/WIKI]
      112kg
      Loosehead
      | [IMAGE]Guy Shepherdson - Wallaby.jpg|thumb|right|150px[/IMAGE]
      [WIKI]Guy Shepherdson[/WIKI]
      119kg
      Tighthead
      | [IMAGE]Ben Daley.jpg|thumb|right|150px[/IMAGE]
      [WIKI]Ben Daley[/WIKI]
      111kg
      Loosehead / Tighthead
      | [IMAGE]Albert Anae - Bench Press.PNG|150px|thumb|right[/IMAGE]
      [WIKI]Albert Anae[/WIKI]
      Prop / Hooker
      105kg
      [/table]
    Issue Details
    Issue Number 2048
    Issue Type Bug
    Project VaultWiki 3.x Series
    Category BB-Code Parsing
    Status Fixed
    Priority 3 - Loss of Functionality
    Affected Version 3.0.5
    Fixed Version 3.0.6
    Milestone (none)
    Software DependencyAny
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 1
    Assigned Users (none)
    Tags (none)




    1. October 26, 2010 12:15 PM
      pegasus pegasus is offline
      VaultWiki Team
      In vault/class/bbcode/table.php, find:
      Code:
      				$this->close_td();
      				$this->close_tr();
      				$this->open_tr();
      Replace with:
      Code:
      				$this->close_td();
      				$this->close_tr();
      				$this->open_tr($line);
      Find:
      Code:
      	function open_tr()
      	{
      		if (empty($this->open['tr']))
      		{
      			if ($this->buffer)
      			{
      				$this->output .= $this->buffer;
      				$this->buffer = '';
      			}
      
      			$this->open['tr'] = '<tr>';
      		}
      	}
      Replace with:
      Code:
      	function open_tr($line = '')
      	{
      		if (empty($this->open['tr']))
      		{
      			if ($this->buffer)
      			{
      				$this->output .= $this->buffer;
      				$this->buffer = '';
      			}
      
      			if (is_class_type($this->parser, 'plaintext'))
      			{
      				$this->open['tr'] = "\n|";
      			}
      			else
      			{
      				$this->init_cleaner();
      				$attributes .= $this->parser->cleaner->accept_attributes($line, 'tr');
      				$this->open['tr'] = "<tr$attributes>";
      			}
      		}
      	}
      Reply Reply  
    2. October 26, 2010 12:34 PM
      pegasus pegasus is offline
      VaultWiki Team
      As for the navbar missing the wiki stuff, if you modified your navbar template make sure you didn't remove any of the following:
      Code:
      {vb:raw template_hook.navtab_start}
      {vb:raw template_hook.navtab_middle}
      {vb:raw template_hook.navtab_end}
      Reply Reply  
    3. October 26, 2010 7:05 PM
      Moses Moses is offline
      Junior Member
      Thanks for the quick reply once again pegasus, unfortunately it is now pushing the entire table into a single row!

      Screenshot attached for the above example
      Reply Reply  
    4. October 26, 2010 7:11 PM
      Moses Moses is offline
      Junior Member
      I copied the table.php back from 3.0.2 and it's working for the moment.

      I can continue to test on my dev installation if you like, I'm quite excited by the possibility of sortable tables!
      Reply Reply  
    5. October 30, 2010 10:38 AM
      Mokonzi Mokonzi is offline
      Senior Member
      Did this prove to be the fix ni the end Moses?
      Reply Reply  
    6. October 30, 2010 8:30 PM
      Moses Moses is offline
      Junior Member
      Not yet Mokonzi, issue is still open as far as I'm aware.
      I copied the table.php file from 3.0.2 back, which has the formatting working correctly but you don't get the new sortable tables unfortunately.
      Reply Reply  
    7. This petition for a change to In Progress was accepted
      October 30, 2010 8:31 PM
      Moses Moses is offline
      Junior Member
      Just realised I can petition a status change, so doing that..
       
    8. October 31, 2010 4:31 AM
      pegasus pegasus is offline
      VaultWiki Team
      Sorry the HTML included in my post for the second edit was removed by some security code on the site. I've gone ahead and fixed the post so it shows the correct find/replace pair.
      Reply Reply  
    9. November 1, 2010 8:21 AM
      Moses Moses is offline
      Junior Member
      Is this in build 004?
      Reply Reply  
    10. November 1, 2010 11:39 AM
      pegasus pegasus is offline
      VaultWiki Team
      Yes this has been in since Build 002.
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 12:20 AM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2023 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2023 DragonByte Technologies Ltd.
    Copyright © 2008 - 2013 VaultWiki Team, Cracked Egg Studios, LLC.