Issue: Hourly Cleanup Error

Issue Tools
- View Changes

September 23, 2010 12:30 PM
dvsDave

Regular Member
Hourly Cleanup Error

I manually ran the Hourly Cleanup cron job and I get an error on \vault\plugins\data\thread.php

When I run the hourly cleanup I get an error message:

Code:

Fatal error: Call to a member function query_read() on a non-object in /home/controlb/public_html/vault/plugins/data/thread.php on line 146

Issue Details

Issue Number 2001

Issue Type Bug

Project VaultWiki 3.x Series

Category Admin Panel

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 3.0.4

Fixed Version 3.0.5

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 23, 2010 1:43 PM

pegasus

VaultWiki Team

This will require significant changes to a great many files, since it's possible that any number of them can be loaded during a cron process (like clean-up). The fact that $vbulletin->db is not used consistently throughout vBulletin, yet they destroy $db in cron processing to "force" use of an object they don't even use elsewhere, is a very annoying aspect of vBulletin.

Reply
September 23, 2010 2:27 PM

dvsDave

Regular Member

So, what can I do in the meantime? The hourly cleanup is still important and this job seems to be hindering the other parts of that cron job from running.

Reply
October 11, 2010 4:39 PM

dvsDave

Regular Member

Bumping this issue.

Reply
October 12, 2010 9:39 AM

dvsDave

Regular Member

Can I disable this vaultwiki's part of the cron job? This is still keeping me from running my hourly cron and now it's causing issues with my usergroup promotions.

Reply
October 12, 2010 11:10 AM
pegasus

VaultWiki Team
As far as I can tell, this error will only occur if the cleanup task has any thread-redirects that are about to expire. In the process of deleting the redirect, VaultWiki checks if the thread has any wiki links that need to be removed from the database. This VaultWiki code is actually agnostic of the cron process; all it cares about is that a thread is being deleted.

For the time being, you can modify vault/plugins/data/thread.php to bypass this issue. Find:

Code:

$posts = $db->query_read("

Replace with:

Code:

$posts = $vbulletin->db->query_read("

Find:

Code:

while ($post = $db->fetch_array($posts))

Replace with:

Code:

while ($post = $vbulletin->db->fetch_array($posts))

Find:

Code:

$db->free_result($posts);

Replace with:

Code:

$vbulletin->db->free_result($posts);
Reply
October 12, 2010 11:26 AM
pegasus

VaultWiki Team
In vault/functions/data.php, find:

Code:

$db->query_write("

Replace with:

Code:

$GLOBALS['vbulletin']->db->query_write("

Find:

Code:

$postid = $db->query_first("

Replace with:

Code:

$postid = $GLOBALS['vbulletin']->db->query_first("

If the attempted delete is actually of a wiki article, there are quite a bit more changes that need to be made. I'm still looking for them all, but rest assured this is the highest priority issue to address for the next release.
Reply
October 12, 2010 11:44 AM

pegasus

VaultWiki Team

Fixed all the problematic instances of $db (in data handlers, cache updates, bbcode parsing) for the next build. For the time being, Special pages do not yet need to be fixed because of #1459, but that can be addressed when that issue is closed.

Reply

+ Reply

All times are GMT -4. The time now is 12:46 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Hourly Cleanup Error

Issue Tools