Issue: Redirects not being marked as read

Issue Tools
- View Changes

September 8, 2010 6:21 PM

DChapman

Junior Member

Redirects not being marked as read

When a new redirect is created on an unread article, the article is not marked as read when visited. You can see that in action here: http://www.crohnsforum.com/forumdisplay.php?f=56 Tylenol, Paracetamol, Acetominophen etc

Issue Details

Issue Number 1972

Issue Type Bug

Project VaultWiki 3.x Series

Category Redirects

Status Fixed

Priority 6 - Dev-Related Tasks

Affected Version 3.0.3

Fixed Version 3.0.4

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 10, 2010 2:35 PM

DChapman

Junior Member

Did this get overlooked by chance?

Reply
September 10, 2010 3:48 PM

pegasus

VaultWiki Team

For clarification, what ISN'T being marked read: the redirect, or the target?

Reply
September 10, 2010 5:12 PM

DChapman

Junior Member

The redirect. If you look here: http://www.crohnsforum.com/forumdisplay.php?f=56 you will see that Tylenol, Paracetamol, Acetominophen are not marked as read. If you visit them, they redirect to another article but Tylenol, Paracetamol, Acetominophen always remain bolded even after visiting them.

Reply
This petition for a change to Confirmed was accepted
September 13, 2010 11:18 AM

DChapman

Junior Member

Was that enough clarification? Thanks
September 13, 2010 1:29 PM

pegasus

VaultWiki Team

Fixed for the next build.

Reply
September 13, 2010 1:32 PM

DChapman

Junior Member

Is it a fix that I can apply now?

Thanks

Reply

September 13, 2010 1:37 PM

pegasus

VaultWiki Team

In vault/functions/cache.php, find:

Code:

        $postobj->thread = fetch_threadinfo($temp_cache['threadid']);

Add before:

Code:

		if (wiki_only_bbcode())
		{
			global $threadview;

			if ($postobj->thread['lastpost'] > $displayed_dateline)
			{
				$displayed_dateline = $postobj->thread['lastpost'];
				$checkthreadcookie = true;
			}

			if ($postobj->thread['lastmodified'] > $displayed_dateline)
			{
				$displayed_dateline = $postobj->thread['lastmodified'];
				$checkthreadcookie = true;
			}

			if ($checkthreadcookie AND $displayed_dateline <= $threadview)
			{
				$updatethreadcookie = true;
			}

			if (
				(!$postobj->registry->GPC['posted'] OR $updatethreadcookie) AND
				$displayed_dateline AND
				$displayed_dateline > $threadview
			)
			{
				mark_thread_read($postobj->thread, $postobj->forum, $postobj->registry->userinfo['userid'], $displayed_dateline);
			}
		}

In vault/class/bbcode/redirect.php, find:

Code:

        global $vbphrase, $post, $threadinfo, $foruminfo, $forumperms, $firstpermid, $vault, $vaultperms;

Replace with:

Code:

        global $vbphrase, $post, $threadinfo, $foruminfo, $forumperms, $firstpermid, $vault, $vaultperms, $threadview;

        if ($threadinfo['lastpost'] > $displayed_dateline)
        {
            $displayed_dateline = $threadinfo['lastpost'];
            $checkthreadcookie = true;
        }

        if ($threadinfo['lastmodified'] > $displayed_dateline)
        {
            $displayed_dateline = $threadinfo['lastmodified'];
            $checkthreadcookie = true;
        }

        if ($checkthreadcookie AND $displayed_dateline <= $threadview)
        {
            $updatethreadcookie = true;
        }

        if (
            (!$this->parser->registry->GPC['posted'] OR $updatethreadcookie) AND
            $displayed_dateline AND
            $displayed_dateline > $threadview
        )
        {
            mark_thread_read($threadinfo, $foruminfo, $this->parser->registry->userinfo['userid'], $displayed_dateline);
        }

September 13, 2010 6:16 PM

DChapman

Junior Member

Good stuff, thanks!

Reply

+ Reply

All times are GMT -4. The time now is 11:46 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Redirects not being marked as read

Issue Tools