Issue: Redirect bug

Issue Tools
- View Changes

September 7, 2010 1:17 AM

DChapman

Junior Member

Redirect bug

Redirect only works once

I created a redirect from one article to another. The first time after you save the article, the redirect works. But any subsequent time you visit that article, it just shows the raw bb code and the redirect no longer works.

Any ideas?

Thanks.

Issue Details

Issue Number 1966

Issue Type Bug

Project VaultWiki 3.x Series

Category Redirects

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.3

Fixed Version 3.0.4

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 7, 2010 6:19 PM

pegasus

VaultWiki Team

Fixed for the next build. In vault/tab/article.php, find:

Code:

		$wikipost_factory->bbcode_parser = new vB_WikiCodeParser($vbulletin, special_tag_list('', true));

Add after:

Code:

		$wikipost_obj->bbcode_parser =& $wikipost_factory->bbcode_parser;
		$wikipost_obj->post_cache =& $wikipost_factory->bbcode_parser->cached;

In vault/factory/postbit.php, find:

Code:

		$out->post_cache =& $this->post_cache;

Replace with:

Code:

		$out->post_cache =& $this->bbcode_parser->cached;

This petition for a change to Confirmed was accepted
September 7, 2010 6:33 PM

DChapman

Junior Member

I'm afraid that doesn't fix the issue on my end. The redirect continues to work once then when you go to the page again, it's unparsed BB code.

http://www.crohnsforum.com/wiki/Prednisolone
September 8, 2010 12:52 AM

pegasus

VaultWiki Team

It will continue to show the same behavior as before for articles created before the fix was implemented until the cache times out. You can clear the cache manually by going to AdminCP > VaultWiki > Wiki Maintenance Tools > Clean Article Post Cache.

Reply
September 8, 2010 1:49 AM

DChapman

Junior Member

I cleaned the cache and the problem persists

Reply

September 8, 2010 3:42 AM

pegasus

VaultWiki Team

In vault/factory/postbit.php, find:

Code:

		$out->post_cache =& $this->bbcode_parser->cached;
		$out->cachable =& $this->cachable;
		$out->bbcode_parser =& $this->bbcode_parser;

Replace with:

Code:

		$out->bbcode_parser =& $this->bbcode_parser;
		$out->post_cache =& $this->bbcode_parser->cached;
		$out->cachable =& $this->cachable;

September 8, 2010 4:25 AM

DChapman

Junior Member

The issues remains I did clean the cache.

If you need access to my site, I'm willing to provide it if you can't recreate the problem on your end.

Reply
September 8, 2010 5:17 PM
pegasus

VaultWiki Team
This only occurs for wikis that are set to display the comments below the article. On the first time it parses, you will notice a comment below the article that contains the raw code of the article. This comment even being there is a bug, and when it caches it overwrites the cache for the article. The comment disappears on subsequent page loads because there is no longer an id mismatch, because the cache prevented the redirect from taking place.

The problem is that when the article changes during the redirect, the value of $threadid is not also changed because it is not a reference to $threadinfo['threadid'].

In vault/class/bbcode/redirect.php, find:

Code:

$threadinfo = fetch_threadinfo($targetid);

Add after:

Code:

$GLOBALS['threadid'] =& $threadinfo['threadid'];

And in vault/functions/cache.php, find:

Code:

$postobj->thread = fetch_threadinfo($temp_cache['threadid']);

Add after:

Code:

$GLOBALS['threadid'] =& $postobj->thread['threadid'];
Reply
This petition for a change to Confirmed was rejected
September 8, 2010 5:30 PM

DChapman

Junior Member

I appreciate your continued support on this. It looks like the redirect is working now, however, the comments below the page are doing something weirder now. See: http://www.crohnsforum.com/wiki/Ibd

Thanks.
September 8, 2010 5:40 PM

pegasus

VaultWiki Team

That is a separate (yet related) bug: http://www.vaultwiki.org/issues/1970/

The fix has already been added to my previous post in this thread.

Reply
September 8, 2010 5:56 PM

DChapman

Junior Member

I think you got it all fixed. Well done! Thank you

Reply
This petition for a change to Confirmed was rejected
September 8, 2010 6:34 PM

DChapman

Junior Member

Another associated issue I'm afraid. When a redirect is created for a new article that hasn't been read, when visiting that article, it is not marked as read on forumdisplay. You can see it here: http://www.crohnsforum.com/forumdisplay.php?f=56 Tylenol, acetomephotin, etc.
September 8, 2010 7:03 PM

pegasus

VaultWiki Team

Please open a new thread for that issue, as it's a different problem than the OP.

Reply

+ Reply

All times are GMT -4. The time now is 5:27 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Redirect bug

Issue Tools