Issue: Missing Phrase vault_title_change_error?

Issue Tools
- View Changes

September 1, 2010 4:31 PM

Mokonzi

Senior Member

Missing Phrase vault_title_change_error?

Missing Phrase vault_title_change_error?

One of my users has reported some difficulties in being able to process an edit on a page, but I'm waiting on more details. What he did point out is that there was a message that a phrase was missing: vault_title_change_error. I can't find it in the phrases.

For reference, all I know is that he was trying to edit a page which would add some TOC commands in. Nothing else atm.

Issue Details

Issue Number 1958

Issue Type Bug

Project VaultWiki 3.x Series

Category Language / Phrasing

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 3.0.3

Fixed Version 3.0.5

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 3, 2010 1:49 AM

Mokonzi

Senior Member

Details I've got from the wiki users experiencing this problem seem to suggest that it's user related.

They find it only happens with articles that have < and > in them, using the WYSIWYG editor. I personally haven't had this with the extra controls standard editor.

Reply
September 7, 2010 2:59 AM

Mokonzi

Senior Member

Any news?

Reply
September 10, 2010 6:05 AM

Mokonzi

Senior Member

Any news on this bug before it gets lost down the list...

Reply
September 10, 2010 12:52 PM
pegasus

VaultWiki Team
Fixed for the next build. This bug was two-fold:

The encoding of the existing title did not match the encoding of the form input. When certain characters were included in the title, this resulted in a mismatch.
The error phrase telling users they don't have permission to change titles was missing. This message would never be seen in normal use anyway unless a permission was changed while the user was already editing.
Reply
September 11, 2010 1:30 PM

Mokonzi

Senior Member

Thanks pegasus.

Reply
This petition for a change to Confirmed was accepted
September 24, 2010 4:46 AM

Mokonzi

Senior Member

I've still got the issue with the < and > in 3.0.4. Atm when I edit an article title and add the <> in, then it substitutes them for the shorthand ascii abbreviation, or uses gt lt instead.

When you view the page, it shows no content on the page... yet redediting the title back to what it was rescues the article content.

September 24, 2010 11:07 AM

pegasus

VaultWiki Team

In vault/dm/revision.php, find:

Code:

$existing['title'] = htmlspecialchars_uni($existing['title']);

Remove that line.
Now find:

Code:

                                $change = true;
                                $threadman->set('title', unhtmlspecialchars($this->fetch_field('title'), true));
                            }
                            else
                            {
                                $change = false;
                                $this->set('title', unhtmlspecialchars($this->existing['title']));
                                $threadman->set('title', unhtmlspecialchars($this->existing['title']));
                            }
                        }
                        else
                        {
                            $change = false;
                            $this->set('title', unhtmlspecialchars($this->existing['title']));
                            $threadman->set('title', unhtmlspecialchars($this->existing['title']));

Replace with:

Code:

                                $change = true;
                                $threadman->set('title', unhtmlspecialchars($this->fetch_field('title'), true));
                            }
                            else
                            {
                                $change = false;
                                $this->set('title', $this->existing['title']);
                                $threadman->set('title', unhtmlspecialchars($this->existing['title'], true));
                            }
                        }
                        else
                        {
                            $change = false;
                            $this->set('title', $this->existing['title']);
                            $threadman->set('title', unhtmlspecialchars($this->existing['title'], true));

In vault/tab/edit.php, find:

Code:

                $dataman->setr('title', $edit['title']);

Replace with:

Code:

                $dataman->set('title', $edit['title']);

+ Reply

All times are GMT -4. The time now is 1:51 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Missing Phrase vault_title_change_error?

Issue Tools