Issue: Double Line Returns in Templates

Issue Tools
- View Changes

August 19, 2010 11:53 AM

Mokonzi

Senior Member

Double Line Returns in Templates

Double Line Returns in Templates

I seem to be getting double line returns in some of the templates on the site, especially preceding the templates insertion (noticed primarily on tables).

Some may need my template structure editing slightly (as it seems to be including line returns around the if commands that aren't parsing as they aren't meeting certain criteria), but some may be integral to VW as at least one template has no conditional before the table starts.

Issue Details

Issue Number 1936

Issue Type Bug

Project VaultWiki 3.x Series

Category Templates

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.3

Fixed Version 3.0.4

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 19, 2010 2:54 PM

pegasus

VaultWiki Team

Use [comment] tags around the white-space near your IF commands.

Can you give an example where a template that doesn't use IF commands has this problem?

Reply
August 20, 2010 12:15 PM

Mokonzi

Senior Member

An article with the issues:

http://www.thexuniverse.com/showwiki/Barracuda

Template with [if] commands that are't likely interfering:

http://www.thexuniverse.com/showwiki/Template:About

Template without [if] commands, seemingly adding whitespace:

http://www.thexuniverse.com/showwiki...box+Ship+Stats

Reply
August 20, 2010 12:29 PM

pegasus

VaultWiki Team

This is an issue with the [mention] BB-Code from the DB-Tech mod. We were only able to handle the conflict where templates were not involved. While VaultWiki's order of line-break parsing is non-standard and not something DB-Tech could have anticipated, as I mentioned in another report, the mod should be rewritten so it doesn't call the parser recursively. Instead it could easily have a parser callback function that does what it's trying to do. This would save performance on every board, and would eliminate this conflict.

For reference, I am referring to the plugin at bbcode_parse_complete_precache.

Reply
August 20, 2010 12:33 PM

Mokonzi

Senior Member

Thanks, that reminds me of the older report... lol, getting forgetful. I'll raise this suggestion to the DBTech team.

Reply

September 2, 2010 11:47 AM

pegasus

VaultWiki Team

Try this. In vault/class/bbcode.php, find:

Code:

			$text = $this->parse_bbcode($text, $do_smilies, $do_html);

Replace with:

Code:

			$text = $this->exec_cycles($text, $do_smilies, $do_html);

Find:

Code:

$this->recursion['all'] < 2 OR $this->recursion['level']

Replace with:

Code:

$this->recursion['all'] < 2 OR $this->recursion['level'] > 1

September 3, 2010 2:02 AM

Mokonzi

Senior Member

Works perfect, no more line breaks.

Reply
September 3, 2010 3:08 AM

Trekkan

Junior Member

I had this same issue. No idea it was related to the DBTech mod. Anyway, the suggested fix posted above worked for me as well, thanks!

Reply

+ Reply

All times are GMT -4. The time now is 1:05 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Double Line Returns in Templates

Issue Tools