Issue: Templates with Spaces are Missing

Issue Tools
- View Changes

August 18, 2010 2:04 PM

pegasus

VaultWiki Team

Templates with Spaces are Missing

When a Template that has a space in the name is used in a page, and the space-encoding is +, and there is a URL replacement like ( Plus ) for that character, the template will not be found and instead a link to Template+Plus+Name will be added.

Fixed in the current ZIP. In vault/class/bbcode/template.php, find:

Code:

				$id = $vault->article->fetch($templatename, TEMPLATE_SPACE, VAULT_LANGUAGEID, 'threadid');

Replace with:

Code:

				$id = $vault->article->fetch(urldecode($templatename), TEMPLATE_SPACE, VAULT_LANGUAGEID, 'threadid');

Find:

Code:

				$fetch['title'] = $vault->string->tolower($vault->encode->encode($fetch['title'], TEMPLATE_SPACE));

Replace with:

Code:

				$fetch['title_enc'] = $vault->string->tolower($vault->encode->encode($fetch['title'], TEMPLATE_SPACE));

Find:

Code:

			$title = $template_cache[$threadids["$t"]]['title'];

Replace with:

Code:

			$title = $template_cache[$threadids["$t"]]['title_enc'];
			$title_orig = $template_cache[$threadids["$t"]]['title'];

Find:

Code:

					'[' . $tag . '=' . $title . ']' . $args . '[/' . $tag . ']',

Replace with:

Code:

					'[' . $tag . '=' . $title_orig . ']' . $args . '[/' . $tag . ']',

Find:

Code:

					$text = str_replace(
						"&lt;!-- TEMPLATE $title|$instance -->",

Replace with:

Code:

					$find = "&lt;!-- TEMPLATE $title|$instance -->";
					$title = $vault->url->decode($title);

					$text = str_replace(
						$find,

Issue Details

Issue Number 1929

Issue Type Bug

Project VaultWiki 3.x Series

Category Templates

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.3

Fixed Version 3.0.4

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 18, 2010 2:19 PM

pegasus

VaultWiki Team

I think there is still an issue with double-encoding involving URL replacements: http://www.vaultwiki.org/issues/1930/
But that is a somewhat complex issue that won't be solved until after the re-write now.

Reply
August 19, 2010 1:43 AM

Mokonzi

Senior Member

That fixed the issues I've been having, though still got excess whitespace on some templates and noticed that when editing an article, the only templates listed as being part of the article are the single word templates, multi-word named templates aren't listed.

Thanks for the hard work peg.

Reply
August 19, 2010 3:21 AM

pegasus

VaultWiki Team

Please be sure to post the remaining issues as separate reports. Can't move/copy posts in PT yet.

Reply
August 19, 2010 11:49 AM

Mokonzi

Senior Member

Reporting them now...

Reply

+ Reply

All times are GMT -4. The time now is 12:02 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Templates with Spaces are Missing

Issue Tools