Issue: Section Edit fails on non-BBCode headings

Issue Tools
- View Changes

August 14, 2010 10:09 AM

dfidler

New Member

Section Edit fails on non-BBCode headings

When using "=" signs for headings, section edit comes up blank

Issue:

Per the summary, the section editor comes up blank if you're using the '=' sign to denote headings.

Workaround:

Change all of the articles in your wiki from '=' based markup to [H] based markup. The problem is that the section editor used to work with these kinds of headers.

Discussion:

The Media Wiki header markup are infintitely more readable than the BBCode header markup, especially for long wiki articles. And nearly all of my pages use this format because of that reason. With the upgrade to 3.0.2, that markup is still honoured by the parsing engine, but the section editor now breaks completely on those tags.

Issue Details

Issue Number 1915

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 3.0.2

Fixed Version 3.0.3

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

August 14, 2010 12:11 PM
pegasus

VaultWiki Team
In vault/functions/postbit.php, find:

Code:

$htmlRegEx = '|(?:^|\v)(?:[ |\t]*)(={1,6})[^\s=]+\3';

Replace with:

Code:

$htmlRegEx = '|(?:^|\r|\n|\v)\s*(={1,7})[^\r\n\v=]+\3';

Keep in mind that you still will not be able to edit sections that contain an = as part of the heading itself. This includes if it contains a BB-Code with an option code. Example:

Code:

== Heading with a [size="2"]Size 2[/size] Word ==

Until the section parser is rewritten, this limitation will prevent the heading from being indentified as follows:

Code:

= Heading with a [size
Reply
August 14, 2010 3:48 PM

dfidler

New Member

Thanks. However, I would go the other way and say that compound markup in headings is really bad form. Headings serve the purpose of providing referential meta data as well as a standard look-and-feel of the document. Adding things like italics and sizes into a heading violates unified document style ethos of a wiki.

But then, that's just me.

Reply

+ Reply

All times are GMT -4. The time now is 8:43 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Section Edit fails on non-BBCode headings

Issue Tools