Issue: Article names in image namespace cannot contain separator character

Issue Tools
- View Changes

July 1, 2010 8:09 PM

ctrlbrk

Junior Member

Article names in image namespace cannot contain separator character

vb 3.8.5
vw 3.0.0

It seems an article title (image title) in the Image namespace cannot contain the VaultWiki separator character. For instance, on my forum the separator is - (dash). If I name an article "test-photo.jpg" and attach the file "test-photo.jpg" to the article, no error is thrown - it just doesn't work (article not created).

My users won't understand this limitation, and using dash in a filename is fairly common so a solution is needed.

Mike

Issue Details

Issue Number 1752

Issue Type Bug

Project VaultWiki 3.x Series

Category Images

Status Fixed

Priority 7 - Minor Features / Enhancements

Affected Version 3.0.0

Fixed Version 3.0.3

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

July 4, 2010 11:13 AM
pegasus

VaultWiki Team
I can only get this to occur if the case of the filename and article name do not match. Try editing vault/plugins/data/post.php. Find (x2):

Code:

$vault->url->generate($test);

Add after each:

Code:

$test['encshort'] = $vault->string->tolower($test['encshort']);

Also this would occur if a prefix is selected, and that prefix is not a part of the filename as follows:
filename-prefix.jpg
Reply
July 16, 2010 5:56 PM

pegasus

VaultWiki Team

Was this your issue?

Reply
October 19, 2010 1:54 AM

pegasus

VaultWiki Team

Another thing you have to be careful about is how you went about "naming" the article.

If you entered it as a URL, the page didn't exist, and clicked Edit, "test-photo.jpg" from the URL would be decoded in the form Title field as "test photo.jpg". Since it does not have the dash, the image filename no longer matches exactly with the title. This would pass validation, however, because "test-photo.jpg" and "test photo.jpg" resolve to the same location. However, using the image BB-Code would not show the appropriate image, and the image would not be displayed on its page after creation - the page would APPEAR empty, even though it exists (no "There is no text in this page" message).

Over the last several builds we made some improvements to title-attachment matching so that the image would show for this specific case.

However, these have just been theoretical fixes because we noticed the possibility existing in the code. We have not been able to duplicate this particular error without more information on the exact process of image creation that ended up failing.

Closing this as Fixed for now. I do not anticipate there being an issue once VaultWiki 4 comes out, because images will be stored with additional information over regular attachments.

Reply

+ Reply

All times are GMT -4. The time now is 7:58 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Article names in image namespace cannot contain separator character

Issue Tools