Issue: Wiki Does Not Default To "Can Edit Own Posts?" when "Can Edit Wiki Articles?" Is Disabled

Issue Tools
- View Changes

June 22, 2010 10:04 PM

CedricFP

Junior Member

Wiki Does Not Default To "Can Edit Own Posts?" when "Can Edit Wiki Articles?" Is Disabled

Wiki Does Not Default To "Can Edit Own Posts?" when "Can Edit Wiki Articles?" Is Disabled

Wiki Does Not Default To "Can Edit Own Posts?" when "Can Edit Wiki Articles?" Is Disabled.

That is, when I disable "Can Edit Wiki Articles?" (so that only the article creator can edit it, as per your instructions here), the edit button no longer appears even for the article creator.

Issue Details

Issue Number 1727

Issue Type Bug

Project VaultWiki 3.x Series

Category Editing / Posting Articles

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.0

Fixed Version 3.0.1

Milestone VaultWiki 3.0.5

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

June 22, 2010 11:08 PM

pegasus

VaultWiki Team

Fixed for the next build. In vault/factory/postbit.php, find:

Code:

									$this->thread['postuserid'] == $this->registry->userinfo['userid'] AND
									!$this->registry->userinfo['userid'] AND

Replace with:

Code:

									$this->thread['postuserid'] == $this->registry->userinfo['userid'] AND
									$this->registry->userinfo['userid'] AND

In vault/tab/edit.php, find:

Code:

	if (!can_moderate($threadinfo['forumid'], 'caneditposts'))
	{
		if (!$threadinfo['open'])
		{
			$vbulletin->url = $threadinfo['url_s'] . "redirect=no";
			eval(standard_error(fetch_error('threadclosed')));
		}

		if (!($vaultperms & $vbulletin->bf_ugp_vault_permissions['caneditwiki']))
		{
			// check user owns this post
			print_no_permission();
		}
	}

Replace with:

Code:

	if (can_moderate($threadinfo['forumid'], 'caneditposts'))
	{
		if (
			$threadinfo['protection'] == $vault->misc['protectoptions']['full'] AND
			!is_member_of($vbulletin->userinfo, 6)
		)
		{
			print_no_permission();
		}
	}
	else
	{
		if (!$threadinfo['open'])
		{
			$vbulletin->url = $threadinfo['url_s'] . "redirect=no";
			eval(standard_error(fetch_error('threadclosed')));
		}

		if (
			!($vaultperms & $vbulletin->bf_ugp_vault_permissions['caneditwiki']) AND
			(
				$threadinfo['postuserid'] != $vbulletin->userinfo['userid'] OR
				!$vbulletin->userinfo['userid'] OR
				!($forumperms & $vbulletin->bf_ugp_forumpermissions['caneditpost'])
			)
		)
		{
			// check user owns this post
			print_no_permission();
		}

		if (
			(
				$threadinfo['protection'] == $vault->misc['protectoptions']['edit'] AND
				!($vaultperms & $vbulletin->bf_ugp_vault_permissions['canprotect'])
			) OR
			(
				$threadinfo['protection'] == $vault->misc['protectoptions']['coll'] AND
				(
					!($forumperms & $vbulletin->bf_ugp_forumpermissions['caneditpost']) OR
					$vbulletin->userinfo['userid'] != $threadinfo['postuserid'] OR
					!$vbulletin->userinfo['userid']
				)
			)
		)
		{
			print_no_permission();
		}
	}

June 24, 2010 12:25 AM

CedricFP

Junior Member

Thank you!

But on line 2780 of postbit.php I had to remove a ) after $show['protectall']

Reply

June 24, 2010 1:56 PM

pegasus

VaultWiki Team

Okay, in the same file, now find:

Code:

			!($vaultperms & $vbulletin->bf_ugp_vault_permissions['caneditwiki']) OR
			$threadinfo['postuserid'] != $vbulletin->userinfo['userid'] OR
			!$vbulletin->userinfo['userid'] OR
			!($forumperms & $vbulletin->bf_ugp_forumpermissions['caneditpost'])

Replace with:

Code:

			!($vaultperms & $vbulletin->bf_ugp_vault_permissions['caneditwiki']) AND
			(
				$threadinfo['postuserid'] != $vbulletin->userinfo['userid'] OR
				!$vbulletin->userinfo['userid'] OR
				!($forumperms & $vbulletin->bf_ugp_forumpermissions['caneditpost'])
			)

+ Reply

All times are GMT -4. The time now is 12:15 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Wiki Does Not Default To "Can Edit Own Posts?" when "Can Edit Wiki Articles?" Is Disabled

Issue Tools