Issue: New Post/Thread Subscription with Wrong URL

Issue Tools
- View Changes

May 18, 2010 1:22 AM

Mokonzi

Senior Member

New Post/Thread Subscription with Wrong URL

New Post/Thread Subscription with Wrong URL

When getting a New Post/Thread Subscription the URL is wrong, for example, my Mods custom namespace has this in the notification:

This thread is located at http://www.thexuniverse.com/http://w...erse.com//Mods

It's doubling the domain URL atm.

Issue Details

Issue Number 1577

Issue Type Bug

Project VaultWiki 3.x Series

Category Subscriptions

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 3.0.3

Fixed Version 3.0.0

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

May 18, 2010 1:50 PM

pegasus

VaultWiki Team

Are these instant notifications (emails sent as soon as the post is made), or were they sent by scheduled task (daily or weekly subscription)? The code for each of these are very different, so knowing which could narrow down the search.

Reply
May 18, 2010 3:19 PM

Mokonzi

Senior Member

Instant notifications.

Reply

May 18, 2010 11:18 PM

pegasus

VaultWiki Team

Fixed for the next build. In vault/plugins/notify.php, find:

Code:

		if ($vault->fetch_namespaceid($threadinfo) < TEMPLATE_SPACE)

Replace with:

Code:

		if ($vault->fetch_namespaceid($threadinfo['forumid']) < TEMPLATE_SPACE)

May 19, 2010 2:59 AM

Mokonzi

Senior Member

I'm still getting this double URL now, but no reference to the mod:

http://www.thexuniverse.com/http://w...universe.com//

Reply
May 19, 2010 9:34 AM
pegasus

VaultWiki Team
Also in AdminCP > Plugins & Products > Plugin Manager > edit the VaultWiki plugin for location newpost_notification_start. Find:

Code:

$GLOBALS['vault']->fetch_namespaceid($threadinfo)

Replace with:

Code:

$GLOBALS['vault']->fetch_namespaceid($threadinfo['forumid'])
Reply
May 19, 2010 4:52 PM

Mokonzi

Senior Member

Still getting this issue, do the plugins get cached for a while?

Reply
May 19, 2010 4:58 PM

pegasus

VaultWiki Team

No, but I think vBulletin sends all subscription notifications to the mail queue, so they aren't sent right away. Not until the cron job runs. I have had several successful tests once I noticed this.

Reply
May 20, 2010 2:16 AM

Mokonzi

Senior Member

Ok, will test this again tonight.

Reply
This petition for a change to Confirmed was accepted
September 3, 2010 3:55 AM

Mokonzi

Senior Member

I'm still getting this issue with notifications. It can't be caching that's causing it still, can it?
September 10, 2010 6:04 AM

Mokonzi

Senior Member

Just to bump this before it gets missed... still an issue for me.

Reply

September 10, 2010 11:59 AM

pegasus

VaultWiki Team

It seems that vBulletin applies replacement variables on the notification before the plugin is executed. In vault/plugins/notify.php, find:

Code:

            $evalemail["$key"] = str_replace('$vboptions[bburl]/$threadlink', $threadinfo['url'], $emailstring);

Replace with:

Code:

            $evalemail["$key"] = str_replace('" . $GLOBALS[\'vbulletin\']->options[\'bburl\'] . "/$threadlink', $threadinfo['url'], $emailstring);

September 11, 2010 1:36 PM

Mokonzi

Senior Member

Will let you know if I have any other problems.

Reply

+ Reply

All times are GMT -4. The time now is 12:25 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: New Post/Thread Subscription with Wrong URL

Issue Tools