Issue: String +-+ Causes Infinite Redirect

Issue Tools
- View Comments

May 15, 2010 1:24 PM

pegasus

VaultWiki Team

String +-+ Causes Infinite Redirect

When a URL contains the string +-+ and the URL format uses + for spaces (there are probably other combinations too), an infinite redirect occurs.

Fixed in the current ZIP. In vault/plugins.php, find:

Code:

	$pathbits = preg_split('#(\/|:|\?|=|\&|\.|-|_)#', $path, -1, PREG_SPLIT_DELIM_CAPTURE);

Replace with:

Code:

	$pathbits = preg_split('#(\/|:|\?|=|\&|\.|-|_|\s)#', $path, -1, PREG_SPLIT_DELIM_CAPTURE);

In vault/wiki.php, find:

Code:

		// shorten strings of SEO replacement
		$text = trim(preg_replace('#(' . preg_quote($badchars['+']) . ')+#', $badchars['+'], $text), $badchars['+']);

Replace with:

Code:

		$text = preg_replace('#(' . preg_quote($badchars['+']) . ')+#', $badchars['+'], $text);

		if (strlen($text) > 1)
		{
			// shorten strings of SEO replacement
			$text = trim($text, $badchars['+']);
		}

Issue Details

Issue Number 1565

Issue Type Bug

Project VaultWiki 3.x Series

Category Infinite Loops

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 3.0.0 RC 3

Fixed Version 3.0.0 RC 3

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

June 2, 2010 10:44 PM
Issue Changed by pegasus
- Category changed from Search Engine Optimization to Infinite Loops

+ Reply

All times are GMT -4. The time now is 7:23 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: String +-+ Causes Infinite Redirect

Issue Tools