Issue: Redirect loop on all pages

Issue Tools
- View Changes

April 26, 2010 11:51 PM

nanabite

New Member

Redirect loop on all pages

Since upgrading from 3.0.0 RC 1 to 3.0.0 RC 2, all pages show a redirect loop error

I upgraded from 3.0.0 RC 1 to 3.0.0 RC 2 yesterday and ever since I have been getting a redirect loop when trying to access any page. I did not change any other settings before this occurred, only performed an upgrade.

Issue Details

Issue Number 1490

Issue Type Bug

Project VaultWiki 3.x Series

Category Infinite Loops

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 3.0.0 RC 2

Fixed Version 3.0.0 RC 2

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 27, 2010 12:40 AM
pegasus

VaultWiki Team
Fixed in the current ZIP. This is a conflict with changes in vB 4.0.3 where vBulletin yet again changed the way it interprets the current URL and only affects setups where the wiki is not below the forum root. In vault/special_plugins.php, find:

Code:

$full_url = VB_URL_BASE_PATH;

Replace with:

Code:

$full_url = VB_URL;
Reply
April 27, 2010 12:55 AM
nanabite

New Member
I tried this change with no luck, also tried downloading the latest zip file.

Currently I have my forum in a /forum directory and use the following in my web root's .htaccess:

Code:

RewriteCond %{REQUEST_FILENAME} !-f RewriteCond %{REQUEST_FILENAME} !-d RewriteRule ^wiki/(.*)?$ forum/showwiki_proxy.php [L,QSA]

I am however not adverse to having the wiki under the forum root rather than the web root. Please advise on what the best solution is.
Reply

April 27, 2010 1:13 AM

pegasus

VaultWiki Team

Download the ZIP again. The function special_fetch_url (in the same file) had to be completely rewritten:

Code:

function special_fetch_url($strip_query = false)
{
	global $vbulletin;
	static $url;

	if ($url)
	{
		return $url;
	}

	$url = '';

	if (VAULT_40X_COMPAT)
	{
		$path = urldecode(VB_URL);
	}
	else
	{
		$basepath = parse_url(create_full_url('/'));
		$url = $basepath['scheme'] . '://' . $basepath['host'];
		$url = $vbulletin->input->xss_clean($url);

		$path = $vbulletin->input->fetch_scriptpath();
	}

	if ($vbulletin->options['vault_spaces'] == 0)
	{
		$path = str_replace(' ', '+', $path);
	}

	if ($strip_query)
	{
		$relpath = explode('?', $path);
		$path = $relpath[0];
	}

	$url .= $path;

	return $url;
}

April 27, 2010 1:23 AM

nanabite

New Member

Perfect! That did the trick. Thanks

Reply
April 27, 2010 1:38 AM

pegasus

VaultWiki Team

While it won't affect you, as the updated ZIP only included a 4.0.3 and vB 3 compatible version of the function, I've gone ahead and updated the current ZIP to also account for the variations needed for 4.0.0, 4.0.1, and 4.0.2 respectively. It's quite annoying that each vB release breaks URL detection.

Also, I noticed on your site that the wiki tabs don't look right. This is not a VaultWiki bug. vBAdvanced is stripping all comments from your HTML, without taking into consideration conditional comments designed to add IE CSS fixes. This means that the IE-only CSS is loading all the time. You should report this problem to vBadvanced so that it can be fixed.

Reply
April 27, 2010 3:10 AM

nanabite

New Member

Thanks - I had already reported this issue at http://www.vbadvanced.com/forum/showthread.php?t=40215

Reply

+ Reply

All times are GMT -4. The time now is 10:26 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Redirect loop on all pages

Issue Tools