Issue: Help with Button for "New Article"

Issue Tools
- View Changes

April 6, 2010 9:02 PM

Kaelon

Regular Member

Help with Button for "New Article"

I am trying to create a graphical button for a "New Article" within one of my Wiki articles (a main portal page that I am creating), but doing so creates the link as if it were an external link. Is there a way that I can suppress the external link graphic (the arrows), or is there a preferred/better way of creating a link to create a new article within the current Wiki namespace? Thank you in advance!

Issue Details

Issue Number 1391

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 1 - Security / Login / Data Loss

Affected Version 3.0.0 RC 1

Fixed Version 3.0.0 RC 2

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

April 6, 2010 10:18 PM

pegasus

VaultWiki Team

This is a bug, and will be fixed for the next build. In vault/special_class_bbcode.php, find:

Code:

		$protocol[7] = substr($rightlink, 0, 7);
		$newslink = false;

		if ($this->registry->options['newshow_filename'])
		{
			$newslink = (strpos($rightlink, $this->registry->options['newshow_filename'] . ".php?t=") !== false);
		}

		if (
			(
				$protocol[7] == "http://" OR
				strpos($rightlink, "gopher://") !== false
			) AND
			!$newslink
		)
		{
			$class = ' class="link-http"';
		}
		else if (strpos($rightlink, "https://") !== false)
		{
			$class = ' class="link-https"';
		}
		else if ($protocol[7] == "news://" OR $newslink)
		{
			$class = ' class="link-news"';
		}
		else
		{
			$protocol[5] = substr($rightlink, 0, 6);

			if ($protocol[5] == "ftp://")
			{
				$class = ' class="link-ftp"';
			}
			else if ($protocol[5] == "irc://")
			{
				$class = ' class="link-irc"';
			}
		}
		unset($protocol, $newslink);

Replace with:

Code:

		$newslink = false;

		if ($this->registry->options['newshow_filename'])
		{
			$newslink = (strpos($rightlink, $this->registry->options['newshow_filename'] . ".php?t=") !== false);
		}

		$protocol5 = substr($rightlink, 0, 6);
		$protocol7 = substr($rightlink, 0, 7);

		if ($protocol5 == 'ftp://')
		{
			$class = ' class="link-ftp"';
		}
		else if ($protocol5 == 'irc://')
		{
			$class = ' class="link-irc"';
		}
		else if ($protocol7 == 'news://' OR $newslink)
		{
			$class = ' class="link-news"';
		}
		else if ($is_external)
		{
			if (strpos($rightlink, 'https://') === 0)
			{
				$class = ' class="link-https"';
			}
			else
			{
				$class = ' class="link-http"';
			}
		}

April 6, 2010 10:41 PM

Kaelon

Regular Member

Thanks so much, pegasus. Awesome fix.

Reply
April 7, 2010 3:25 AM

Mokonzi

Senior Member

That worked for me, thanks Pegasus.

Reply
This petition for a change to Confirmed was accepted
April 8, 2010 5:27 PM

Kaelon

Regular Member

A couple of problems:

1. The external link is simply removed from the first external link; it appears on the second (and all subsequent) external link, without regard to whether or not it is a newthread button.

2. There needs to be a way to exempt links to wiki-forums and links to create posts/replies on wiki forums. These are often used on interface panels.

Thoughts?

April 8, 2010 6:31 PM

pegasus

VaultWiki Team

In vault/special_class_bbcode.php, find:

Code:

				$target_url = preg_replace('#^([a-z0-9]+:(//)?)#', '', $rightlink);

				foreach ($allowed AS $host)
				{
					if (stripos($target_url, $host) !== false)
					{
						$is_external = false;
					}
				}
			}

Replace with:

Code:

			}

			$target_url = preg_replace('#^([a-z0-9]+:(//)?)#', '', $rightlink);

			foreach ($allowed AS $host)
			{
				if (stripos($target_url, $host) !== false)
				{
					$is_external = false;
				}
			}

April 8, 2010 6:37 PM

Kaelon

Regular Member

Thanks. Does this keep external links on non-wiki forum posts? I definitely want to keep the external links on those.

Reply
April 8, 2010 8:04 PM

pegasus

VaultWiki Team

Currently the wiki parser class that we are modifying here is not used in non-wiki forum posts.

Reply
April 8, 2010 8:37 PM

Kaelon

Regular Member

Originally Posted by pegasus

Currently the wiki parser class that we are modifying here is not used in non-wiki forum posts.

Sorry, that's not what I meant.

The modifications we did here only prevents the first "external" link on a wiki post from appearing with the external arrows icon. Any other external links will have the arrows. What I was hoping we would do was exempt links to wiki-type forums and wiki-type forum functions (newthread, newreply, etc.) on qualifying wiki forums and threads. Is this possible?

Reply
April 9, 2010 3:12 PM

Mokonzi

Senior Member

Originally Posted by Kaelon

1. The external link is simply removed from the first external link; it appears on the second (and all subsequent) external link, without regard to whether or not it is a newthread button.

As a note, I'm not getting this problem. I've got a table displaying several links to the Profile page, each one for a different user, none are showing the external link symbol to appear.

Reply
April 9, 2010 3:15 PM

pegasus

VaultWiki Team

In vBulletin 4, the second part of the bug only occurs if Settings > Options > BB Code Settings > Add nofollow attribute to URL BB Code is set to "Yes".

Reply
This petition for a change to Awaiting Feedback was accepted
April 10, 2010 5:54 PM

Kaelon

Regular Member

Pegasus - any chance you've been able to review this?

1. This fix just has any links to to the same domain being considered "internal". I just want links outside of the Wiki being considered external. Can this be fixed?

2. Additionally, can we simply exempt links to wiki-type forums from being considered "external"? This would fix the problem altogether, I think.
April 15, 2010 6:38 PM

pegasus

VaultWiki Team

1. As of the next build, all links are considered external if they use [URL].

2. There is no way to reliably test links to see if they resolve as wiki-type forums without using something like CURL, which from a performance standpoint is a no-no for something as trivial as setting a CSS class.

Instead, the little-known feature of URL-flagging has been extended for the next build. You can force a class by setting the flag: FTP, IRC, NEWS, SECURE. You can also force the link to not gain the external class by setting the INTERNAL flag. All of these flags are translateable phrases.

Reply

+ Reply

All times are GMT -4. The time now is 7:17 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Help with Button for "New Article"

Issue Tools