Issue: Pagination Isn't Working in Mod Re-Write

Issue Tools
- View Changes

March 31, 2010 10:05 AM

Mokonzi

Senior Member

Pagination Isn't Working in Mod Re-Write

Pagination Isn't Working in Mod Re-Write

Noticed yesterday that the pagination links don't work properly in at least mod re-write.

It seems that it doesn't tag the &page=2 onto the end for each new page, though asking it to go to the last post does open the correct page.

I've checked, and can't see a bug report for this in beta 6.

Issue Details

Issue Number 1345

Issue Type Bug

Project VaultWiki 3.x Series

Category Wiki Pages

Status Fixed

Priority 1 - Security / Login / Data Loss

Affected Version 3.0.0 Beta 6

Fixed Version 3.0.0 RC 1

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

March 31, 2010 11:37 AM

pegasus

VaultWiki Team

This is working okay for me in RC 1. Please upgrade and confirm that the problem persists.

Reply
March 31, 2010 11:50 AM

Mokonzi

Senior Member

Will perform the upgrade tonight and let you know.

Reply
This petition for a change to Confirmed was accepted
March 31, 2010 12:22 PM

Mokonzi

Senior Member

Ok, looked it over, and still not working. Uploading a picture to show the problem, the mouse if over the Page 2, (highlighted in the red box) and the result is in the browser window (also highlighted in a red box).
March 31, 2010 3:52 PM

pegasus

VaultWiki Team

Finally tracked this down. This occurs when vBulletin's Friendly URLs are set to anything above "Standard".

Reply
March 31, 2010 3:52 PM

Mokonzi

Senior Member

Cool. Thanks peg

Reply

March 31, 2010 4:27 PM

pegasus

VaultWiki Team

Fixed in the current ZIP. In vault/special_class_friendlyurl.php, find:

Code:

	public function get_url($method_override = false)

Add before:

Code:

	protected function skip_query_var($key, $skip_pageinfo = true)
	{
		return vB_Friendly_Url::skip_query_var($key, $skip_pageinfo);
	}

March 31, 2010 5:11 PM

Mokonzi

Senior Member

Thanks peg. Tried to the manual edit, which didn't work, so then redownloaded and tried it, and it worked great.

Reply

+ Reply

All times are GMT -4. The time now is 12:35 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Pagination Isn't Working in Mod Re-Write

Issue Tools