Issue: DB Error in Setting Forums to Wikis

Issue Tools
- View Changes

March 21, 2010 5:44 AM

Mokonzi

Senior Member

DB Error in Setting Forums to Wikis

DB Error in Setting Forums to Wikis

Since upgrading to beta 6, I'm getting this error when trying to add wikis to forums from the forum manager, seems similar but isn't identical to a similar problem I had in beta 5 that was fixed.

Code:

Database error in vBulletin 4.0.2:

Invalid SQL:

				REPLACE INTO vb3_forumpermission
					(usergroupid, forumid, forumpermissions, vault_permissions)
				VALUES;

MySQL Error   : You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 3
Error Number  : 1064
Request Date  : Sunday, March 21st 2010 @ 12:42:11 PM
Error Date    : Sunday, March 21st 2010 @ 12:42:11 PM
Script        : http://www.mysite.com/admincp/forum.php?do=update
Referrer      : http://www.mysite.com/admincp/forum.php?do=edit&f=257&s=
IP Address    : 
Username      : 
Classname     : vB_Database
MySQL Version : 5.0.89-community

Issue Details

Issue Number 1294

Issue Type Bug

Project VaultWiki 3.x Series

Category Admin Panel

Status Fixed

Priority 1 - Security / Login / Data Loss

Affected Version 3.0.0 Beta 6

Fixed Version 3.0.0 Beta 6

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

March 21, 2010 2:18 PM

pegasus

VaultWiki Team

I think this will only occur if the wiki-forum-to-be is the child forum (somewhere along the lines) of a non-wiki forum that has custom permissions. This query tries to fix inheritance of no wiki-permissions in that case. I will try to figure out what's gone wrong in the code for this.

Reply
March 21, 2010 2:25 PM

Mokonzi

Senior Member

This issue note was made as an issue.

The forum in question was a childforum of the main Book namespace forum, if that helps at all.

Reply

March 21, 2010 3:03 PM

pegasus

VaultWiki Team

Fixed in the current ZIP. It seems that a continue was added to the checks for this in certain cases (like if it ended up NOT being a child of a non-wiki forums), which leads to an empty query. In vault/special_admin_forum.php, find:

Code:

				$data->dbobject->query_write("
					REPLACE INTO " . TABLE_PREFIX . "forumpermission
						(usergroupid, forumid, forumpermissions, vault_permissions)
					VALUES " . implode(",\r\n\t", $permissions) . "
				");

Replace with:

Code:

			if (!empty($permissions))
			{
				$data->dbobject->query_write("
					REPLACE INTO " . TABLE_PREFIX . "forumpermission
						(usergroupid, forumid, forumpermissions, vault_permissions)
					VALUES " . implode(",\r\n\t", $permissions) . "
				");
			}

March 22, 2010 3:54 AM

Mokonzi

Senior Member

Looks to have fixed it

Reply

+ Reply

All times are GMT -4. The time now is 11:36 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: DB Error in Setting Forums to Wikis

Issue Tools