Issue: VaultWiki resets global $styleid

Issue Tools
- View Changes

March 7, 2010 3:00 AM
kmike

Junior Member
VaultWiki resets global $styleid

because of deprecated code?

In the style_fetch hook, VaultWiki does a seemingly duplicate effort to compute $styleid again (it is already set by vBulletin before that). I'm not sure what's that code for, but in the end, this line resets $styleid to zero because $vault->misc['styleid'] isn't set anywhere:

Code:

// use the domain default, but don't save it $styleid = intval($vault->misc['styleid']);

Issue Details

Issue Number 1221

Issue Type Bug

Project VaultWiki 3.x Series

Category Styling / CSS

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 2.5.7

Fixed Version 3.0.0 RC 1

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

March 7, 2010 3:31 AM

pegasus

VaultWiki Team

Because of the way vBulletin computes $styleid and doesn't really explain how it got there, VaultWiki doesn't have an easy reference as to what the existing $styleid means. Thus, the value must be recomputed. This is not deprecated code but a workaround to prevent a caching problem involving multi-domain wikis. $vault->misc['styleid'] is actually set in vault/special_class_wiki.php.

However, it is true that this entire condition does not need to be parsed unless $vault->misc['styleid'] actually has a value.

Fixed for the next build.

Reply
March 9, 2010 11:47 AM

kmike

Junior Member

So the fix is to add !empty($vault->misc['styleid'] ) to the beginning of the conditional in that plugin, right?

Reply
March 9, 2010 11:50 AM

pegasus

VaultWiki Team

Yes.

Reply

+ Reply

All times are GMT -4. The time now is 1:18 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: VaultWiki resets global $styleid

Issue Tools