• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 3.x Series
    • Bug
    • getnew search action runs unnecessary query

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: getnew search action runs unnecessary query

    • Issue Tools
      • View Changes
    1. issueid=1220 March 7, 2010 2:24 AM
      kmike kmike is offline
      Junior Member
      getnew search action runs unnecessary query
      query duplication

      special_search_getnew_process() function that runs during the "getnew" search.php action has a query that is basically a duplicate of the main one for "getnew" in search.php.

      That query could be removed by adding its JOIN clause (LEFT JOIN forum ON ... LEFT JOIN vault_link ON ...) to $marking_read and its WHERE clause (NOT (forum.vault_type > 0 AND link.redirect = 1)) to $lastpost_where hook variables.
    Issue Details
    Issue Number 1220
    Issue Type Bug
    Project VaultWiki 3.x Series
    Category Searching
    Status Duplicate
    Priority 5 - Minor Bugs / Small Tweaks
    Affected Version 2.5.7
    Fixed Version (none)
    Milestone (none)
    Software DependencyAny
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 0
    Assigned Users (none)
    Tags (none)




    1. March 7, 2010 3:06 AM
      pegasus pegasus is offline
      VaultWiki Team
      Currently this has been removed entirely in 3.x because for the required processing, versus the number of threads it would even apply to, versus the fact that it's not even really possible in vBulletin 4, it didn't seem worth it to leave this code in there.
      Reply Reply  
    2. March 7, 2010 3:09 AM
      kmike kmike is offline
      Junior Member
      It doesn't apply to 3.x if the code isn't there. So you aren't going to fix this in 2.x?
      Reply Reply  
    3. March 7, 2010 3:32 AM
      pegasus pegasus is offline
      VaultWiki Team
      There aren't going to be any more updates to 2.x except security patches.
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 7:05 PM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2023 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2023 DragonByte Technologies Ltd.
    Copyright © 2008 - 2013 VaultWiki Team, Cracked Egg Studios, LLC.