Issue: Compare Revisions

Issue Tools
- View Changes

February 23, 2010 8:58 PM
hollosch

Senior Member
Compare Revisions

If i want to compare revisions of a page following error occurs:

Code:

Fatal error: Call to undefined function vbflush() in /.../forum/includes/class_diff.php on line 110

Issue Details

Issue Number 1171

Issue Type Bug

Project VaultWiki 3.x Series

Category History / Revisions

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 3.0.0 Beta 4

Fixed Version 3.0.0 Beta 5

Milestone VaultWiki 3.0.0

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

February 23, 2010 10:20 PM

pegasus

VaultWiki Team

Not sure how you have vbflush references in that file. I checked the default includes/class_diff.php for vB 4.0.2, 4.0.1, and 3.8.4. It doesn't contain any vbflush at line 110.

Reply
February 24, 2010 3:10 AM

hollosch

Senior Member

What to do now ?

Reply
February 24, 2010 3:33 AM

pegasus

VaultWiki Team

Download another ZIP from vbulletin.com and replace your includes/class_diff.php with the default file.

Reply
February 24, 2010 3:43 AM

hollosch

Senior Member

Done.
Don't work. Same Error !!!

Reply
February 24, 2010 1:15 PM

pegasus

VaultWiki Team

What is your vBulletin version?

Reply
February 24, 2010 8:10 PM

hollosch

Senior Member

4.0.2 PL1

Reply
February 25, 2010 12:39 AM
pegasus

VaultWiki Team
Again, I don't know how you are getting this, especially if you replaced it with a fresh copy. Here's lines 109 - 112 in includes/class_diff.php, just downloaded from vB.com for the purposes of this post:

Code:

for ($i = 0; $i < $this->data_old_len; $i++) { $this_row = array('-1' => 0); $data_old_value = $this->data_old[$i];

No vbflush(). Also searching the file for "vbflush" returns no results.

Where do you have a mention of "vbflush" in that file?
Reply

February 25, 2010 1:16 AM

Storyteller Storyteller is offline

Junior Member

It's a known vB-Bug. At least the download-package on vb-germany has the fixed file since yesterday evening.

Manuell edding:
In /includes/class_diff.php search for (4x !)

Code:

			// Send some output to the browser inside this loop so certain hosts
			// don't artificially kill the script. See bug #34585
			echo ' ';
			vbflush();

and replace with

Code:

			if (VB_AREA == 'AdminCP')
			{
				// Send some output to the browser inside this loop so certain hosts
				// don't artificially kill the script. See bug #34585
				echo ' ';
				vbflush();
			}

February 25, 2010 2:13 AM

pegasus

VaultWiki Team

I find it odd that the vb-germany 4.0.2 should be so different from vb.com's... Do you know of a way to detect the German script vs. the vb.com script? While it's good to know this was a problem with vBulletin, I'd like to implement some kind of workaround.

EDIT: I'm not even sure how to download the vb-germany version.

Reply
February 25, 2010 2:53 AM
Storyteller

Junior Member
I agree! It shouldn't be that there are two different file-versions "on the market". The error also exist at trying to compare posts but i can't say if there is a problem with compare posts in the english-vB.
On vB-germany there was one of the alpha-tester who get his zip from vB.com and his file has the version

Code:

* @version $Revision: 32878 $ * @date $Date: 2009-10-28 13:38:49 -0500 (Wed, 28 Oct 2009) $

In the german zip it's

Code:

* @version $Revision: 1419 $ * @date $Date: 2010-02-01 15:44:17 +0100 (Mo, 01 Feb 2010) $

So far as i know you can only download the zip from one place. If a german user want to download from vB.com (for example: because the releases there comes out 1 day earlier) they can switch him over but after that he can't download any longer from vB-germany.
Do you only need this one file or the complete zip?
Reply
February 25, 2010 5:25 AM

hollosch

Senior Member

If one file fix the problem i'll need this file and not the whole zip.
I'll download the zip and compare the class_diff - files.

P.S.: I'll stay at vb germany, because i have the support there in my own language and my english is not so good... ;-)

Reply
February 25, 2010 5:30 AM
hollosch

Senior Member
Actually there is this version in the germman zip file:

Code:

* @version $Revision: 1455 $ * @date $Date: 2010-02-24 18:15:47 +0100 (Mi, 24 Feb 2010) $

It works with this file !!!
Reply
February 25, 2010 5:52 AM

Storyteller

Junior Member

Originally Posted by hollosch

If one file fix the problem i'll need this file and not the whole zip.

I'm not a coder and so i don't know if Pegasus needs just the one file or the complete zip to implement some kind of workaround. Sorry for the stupid question. I will not interfere in future any more.

Reply
February 25, 2010 9:10 AM

hollosch

Senior Member

Originally Posted by Storyteller

I'm not a coder and so i don't know if Pegasus needs just the one file or the complete zip to implement some kind of workaround. Sorry for the stupid question. I will not interfere in future any more.

No problem :-))

Reply
February 25, 2010 12:54 PM
pegasus

VaultWiki Team
For this particular problem, it would be better to have the complete ZIP since I am looking for some constant or variable that may differentiate English from German vB, and this may not be available in the class file. If you have a test board with this version, that works, but don't post the ZIP as an attachment here. If you must, email it to:

Code:

support@vaultwiki.org
Reply

+ Reply

All times are GMT -4. The time now is 7:57 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Compare Revisions

Issue Tools