ValidateAndSavableTrait.php:36

Issue Tools
- View Changes

16 Hours Ago 8:11 PM

Alfa1

Distinguished Member

LogicException: Cannot save with validation errors. Use validate() to ensure there are no errors. (First error: Please enter a valid message.) src/XF/Service/ValidateAndSavableTrait.php:36

#0 src/addons/vw/vw/_core/model/report/xf2.php(109): XF\Service\Report\CommenterService->save()
#1 src/addons/vw/vw/_core/controller/dm/base/vw.php(2985): vw_Report_Model_XF2->delete(1, Array)
#2 src/addons/vw/vw/_core/controller/dm/page/vw.php(2934): vw_DM_Base_Controller->delete_pings(Array)
#3 src/addons/vw/vw/_core/controller/dm/vw.php(174): vw_DM_Page_Controller->delete_multiple(Array)
#4 src/addons/vw/vw/_core/controller/ui/imod/action/delete/vw.php(212): vw_DM_Controller->delete_multiple(Array)
#5 src/addons/vw/vw/_core/controller/ui/imod/action/delete/vw.php(116): vw_UI_iMod_Action_Delete_Controller->process_kill_hard(Array, Array)
#6 src/addons/vw/vw/_core/controller/ui/imod/action/base/vw.php(106): vw_UI_iMod_Action_Delete_Controller->perform_kill()
#7 src/addons/vw/vw/Handler/InlineMod/Base/AbstractAction.php(190): vw_UI_iMod_Action_base_Controller->process('kill')
#8 src/XF/InlineMod/AbstractAction.php(175): vw\vw\Handler\InlineMod\Base\AbstractAction->applyToEntity(Object(vw_DM_Page_Controller_XF2), Array)
#9 src/XF/InlineMod/AbstractAction.php(161): XF\InlineMod\AbstractAction->applyInternal(Object(XF\Mvc\Entity\ArrayCollection), Array)
#10 src/XF/Pub/Controller/InlineModController.php(133): XF\InlineMod\AbstractAction->apply(Object(XF\Mvc\Entity\ArrayCollection), Array)
#11 src/addons/Siropu/AdsManager/XF/Pub/Controller/InlineMod.php(54): XF\Pub\Controller\InlineModController->actionPerform()
#12 src/addons/SV/ConversationSharing/XF/Pub/Controller/InlineMod.php(76): Siropu\AdsManager\XF\Pub\Controller\InlineMod->actionPerform()
#13 src/addons/SV/ConversationSharing/XF/Pub/Controller/InlineMod.php(61): SV\ConversationSharing\XF\Pub\Controller\InlineMod->SV\ConversationSharing\XF\Pub\Controller\{closure}()
#14 src/addons/SV/ConversationSharing/XF/Pub/Controller/InlineMod.php(75): SV\ConversationSharing\XF\Pub\Controller\InlineMod->svShimSharedAction(Object(Closure))
#15 src/addons/vw/vw/XF/Pub/Controller/InlineMod.php(55): SV\ConversationSharing\XF\Pub\Controller\InlineMod->actionPerform()
#16 src/XF/Mvc/Dispatcher.php(362): vw\vw\XF\Pub\Controller\InlineMod->actionPerform(Object(XF\Mvc\ParameterBag))
#17 src/XF/Mvc/Dispatcher.php(264): XF\Mvc\Dispatcher->dispatchClass('XF:InlineMod', 'Perform', Object(XF\Mvc\RouteMatch), Object(vw\vw\XF\Pub\Controller\InlineMod), NULL)
#18 src/XF/Mvc/Dispatcher.php(121): XF\Mvc\Dispatcher->dispatchFromMatch(Object(XF\Mvc\RouteMatch), Object(vw\vw\XF\Pub\Controller\InlineMod), NULL)
#19 src/XF/Mvc/Dispatcher.php(63): XF\Mvc\Dispatcher->dispatchLoop(Object(XF\Mvc\RouteMatch))
#20 src/XF/App.php(2824): XF\Mvc\Dispatcher->run()
#21 src/XF.php(806): XF\App->run()
#22 index.php(23): XF::runApp('XF\\Pub\\App')
#23 {main}

Request state

array(4) {
["url"] => string(19) "/inline-mod/perform"
["referrer"] => string(47) "/wiki/Helpdesk?do=delete"
["_GET"] => array(1) {
["/inline-mod/perform"] => string(0) ""
}
["_POST"] => array(11) {
["_xfToken"] => string(8) "********"
["harddelete"] => string(1) "2"
["returnid"] => string(2) "12"
["returntype"] => string(1) "1"
["ids"] => array(1) {
[10000000001436] => string(14) "10000000001436"
}
["type"] => string(6) "vwpage"
["action"] => string(6) "delete"
["confirmed"] => string(1) "1"
["_xfResponseType"] => string(4) "json"
["_xfWithData"] => string(1) "1"
["_xfRequestUri"] => string(24) "/wiki/Helpdesk?do=delete"
}
}

Issue Details

Issue Number 6498

Issue Type Bug

Project VaultWiki 4.x Series

Category Moderator Tools

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.9

Fixed Version 4.1.10

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

3 Hours Ago 9:27 AM
pegasus

VaultWiki Team
This seems to occur when attempting to delete wiki content that has reports, if those reports were closed in the past without deleting the content. I think this would happen if you decided to take no action on the report when it was made.

When VaultWiki deletes content, it automatically tries to close all reports for that content. But it looks like XenForo throws this error when trying to close a report that is already closed, rather than ignoring it. We can work around it by checking the report status before making any changes.

In src/addons/vw/vw/_core/model/report/xf2.php, find:

Code:

$service = XF::service('XF:Report\Commenter', $report); $service->setReportState('resolved'); $service->save(); unset($service);

Replace with:

Code:

if (!$report->isClosed()) { $service = XF::service('XF:Report\Commenter', $report); $service->setReportState('resolved'); $service->save(); unset($service); }
Reply

+ Reply

All times are GMT -4. The time now is 12:39 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: LogicException: Cannot save with validation errors. Use validate() to ensure there are no errors. (First error: Please enter a valid message.) src/XF/Service/ValidateAndSavableTrait.php:36

Issue Tools