Issue: Certain template usage causes sidebar to move below content + extra line breaks with DIV bb code in template (in 4.1.7, not present in 4.1.2)

Issue Tools
- View Changes

January 5, 2024 11:13 PM
ACL

Regular Member
Certain template usage causes sidebar to move below content + extra line breaks with DIV bb code in template (in 4.1.7, not present in 4.1.2)

Since upgrading from 4.1.2 to 4.1.7, I have noticed some presentation differences on my site when a certain template is embedded on a page (a NavBox template). These differences are:

1. The wiki sidebar drops down to below the content.

On looking at the page source code for pages where the sidebar has dropped down, it appears as though additional nested HTML elements have been closed off. The p-body-sidebar <div> element is unexpectedly a direct descendant of <body>. It should be at the same level as p-body-content.

EXPECTED:

Code:

body > div#top.p-pageWrapper > div.p-body > div.p-body-inner > div.p-body-main > div.p-body-sidebar

ACTUAL:

Code:

body > div.p-body-sidebar

2. MINOR BUG: Using the DIV bb code, an unwanted <br> line break follows the vw-div <div> element. This issue does not occur for the last instance of a line containing DIV bb code in the template. Problem seems resolved with avoiding usage of DIV bb code in this scenario.

I went to experiment with this on the XF demo site but at present the template there isn't rendering correctly because of prior VW TABLE bb code usage - please remind me what this changed to to not interfere with XF's own TABLE bb code and I'll update my testing pages to use the correct BB code tag over on the XF demo site.

P.S. I looked at Special:WikiCodeList for the correct table BB code but it is missing:
https://www.vaultwiki.org/xf-wiki/in...l:WikiCodeList

Issue Details

Issue Number 6404

Issue Type Bug

Project VaultWiki 4.x Series

Category Templates

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.7

Fixed Version 4.1.8

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

January 6, 2024 8:16 PM
pegasus

VaultWiki Team
#1 It looks like this bug has been since at least all of VW 4.x. Specifically, when using the VW TABLE syntax, if the last cell in the table ends with a line skip, but no trailing row start, before the closing tag, the HTML tag for the last cell is not closed properly. Browsers may handle this differently between vendors and from browser version to browser version, but I believe the previous behavior was that a closing HTML table tag tended to assume the closure of all tags within the table. Apparently that isn't the case anymore in current Chrome and the table explodes.

In src/addons/vw/vw/_core/model/parser/handle/table/vw.php, find:

Code:

public function close_tr() {

AFTER it, add:

Code:

$this->close_td();

#2 It is normal behavior for a BR to appear after a DIV if there is more than one line break after the tag, if there are other BB-Codes in between the closing DIV and the line break (such as a COMMENT), or if the DIV is inside a TEMPLATE and the line break is actually after/outside the TEMPLATE. DIV is only designed to strip one line break.

I'm not sure if you did so for readability, but a lot of extra line breaks are added in the example templates you posted on the demo. Many of these line breaks are rendered, as expected. If you need your IF statements, TEMPLATE calls, other tags etc on separate lines for readability, you should always encapsulate the extra whitespace with COMMENT to prevent that whitespace from rendering. So at first glance, I don't see any obvious unexpected whitespace based on what you posted.
Reply

+ Reply

All times are GMT -4. The time now is 2:41 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Certain template usage causes sidebar to move below content + extra line breaks with DIV bb code in template (in 4.1.7, not present in 4.1.2)

Issue Tools