Issue: Error after changing thumbnail sizes

Issue Tools
- View Changes

October 19, 2023 2:20 AM

mazzly

Junior Member

Error after changing thumbnail sizes

Code:

ErrorException: Job vw\vw\Handler\Job\Defer: [E_WARNING] Undefined variable $thumblist

Code:

#0 src/addons/vw/vw/_core/model/cron/deferred/settings/thumbnails/vw.php(81): XF::handlePhpError(2, '[E_WARNING] Und...', '/home/nginx/dom...', 81)
#1 src/addons/vw/vw/_core/model/cron/deferred/settings/vw.php(45): vw_Cron_Deferred_Settings_Thumbnails_Model->rebuild(Array, 600)
#2 src/addons/vw/vw/_core/model/cron/deferred/vw.php(66): vw_Cron_Deferred_Settings_Model->run(Array)
#3 src/addons/vw/vw/Handler/Job/Defer.php(41): vw_Cron_Deferred_Model->exec()
#4 src/XF/Job/Manager.php(260): vw\vw\Handler\Job\Defer->run(8)
#5 src/XF/Job/Manager.php(202): XF\Job\Manager->runJobInternal(Array, 8)
#6 src/XF/Job/Manager.php(86): XF\Job\Manager->runJobEntry(Array, 8)
#7 job.php(43): XF\Job\Manager->runQueue(false, 8)
#8 {main}

Code:

array(4) {
  ["url"] => string(8) "/job.php"
  ["referrer"] => string(76) "https://www.....com/admin.php?options/groups/vw_server_settings/"
  ["_GET"] => array(0) {
  }
  ["_POST"] => array(0) {
  }
}

Also, now our wiki seems to be disabled due to a deferred task, is there some way to see the status of this deferred task? Or e.g. php cmd.php command to run these a bit faster on the server CLI?

Issue Details

Issue Number 6394

Issue Type Bug

Project VaultWiki 4.x Series

Category Attachments

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.1.7

Fixed Version 4.1.8

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 23, 2023 2:57 PM

mazzly

Junior Member

Wouldn't it make more sense to just rebuild the images in a rebuild job that can be triggered from the admin panel instead of doing it "on the fly"?

And on image upload also generate the thumbnail image... Since it is anyway only one size that will always be generated... And if you add the option for allow multiple ?x=X sizes, those can be added to the rebuild job and the "post save"-task

Reply
October 23, 2023 3:06 PM

mazzly

Junior Member

Also, since we aggressively employ cloudflare caching for images on our forum (we override the "cache-control: private" for /wiki-asset since we don't have private images), what would be the way to increase the 5-second timeout to something larger to be able to use Imagick again?

Reply
October 23, 2023 3:19 PM

pegasus

VaultWiki Team

- You can actually have up to 4 or 5 sizes right now, depending on your UHD settings. It comes from the &dpr=M in the asset URL, where M is the device ratio multiplier. For these, we don't like to generate them unless someone actually needs to see it (they are only used in the JS lazy-loader until we add srcset support).
- There's no interface for it, but under the hood, the idea is to allow for arbitrary sizes that can be approved on a case-by-case basis. Generating these for every image would be excessive.
* A rebuild job from the admin panel has the drawback of only rebuilding one image at a time (each one is allowed to take 5 seconds so it could potentially take hours); meanwhile, "on the fly" we can do multiple images at once and focus on the images that people are actually requesting first.

We don't do a post save task in the same request due to resource limitations, but we could definitely add an immediate deferred task on post save that generates the base thumbnail (assuming someone hasn't already tried to view it in that second).

Reply
October 24, 2023 8:49 AM

mazzly

Junior Member

How to increase the 5 second timeout? We understand the attack vector risk..

Reply
October 24, 2023 1:42 PM
pegasus

VaultWiki Team
It's hard-coded in src/addons/vw/vw/_core/model/image/format/vw.php:

Code:

$resource->setResourceLimit(imagick::RESOURCETYPE_TIME, 5);
Reply
October 25, 2023 2:21 PM

mazzly

Junior Member

I tried increasing the timeout to 15, still getting problems/errors about hitting timelimit... Don't understand how that can be related.. Some pages that load many more images don't have problems, another page with just 3 images usually triggers errors...

Reply
October 26, 2023 1:25 AM

mazzly

Junior Member

I tried increasing it to 30 (both places where it is defined) and the error triggers very fast when loading the page after resetting thumbnails, so it doesn't seem to be respected... I would expect it to try for 30s before failing, but it is instant.

Reply

+ Reply

All times are GMT -4. The time now is 1:56 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Error after changing thumbnail sizes

Issue Tools