Issue: Footnote numbering error

Issue Tools
- View Changes

June 20, 2009 11:22 PM

tommythejoat

Regular Member

Footnote numbering error

Footnote reuse does not work correctly.

Footnote references for multiple references to the same footnote are not handled properly. Rather than reusing the original reference number, they generate a new number each time. It should behave as it does on Wikipedia. Also the back references should start with a instead of b for multiples. Although clicking on the numbered link goes to the proper reference, the highlighting does not appear, so it can be difficult to determine exactly what the reference was.

Issue Details

Issue Number 639

Issue Type Bug

Project VaultWiki 3.x Series

Category BB-Code Parsing

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 2.3.1

Fixed Version 2.3.2

Milestone (none)

Software DependencyAny

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 1

Assigned Users (none)

Tags (none)

June 22, 2009 4:21 PM
tommythejoat

Regular Member
On the footnote patch, my code says:

Code:

function handle_bbcode_footnote($value, $option)

Should I just substitute $value for $title wherever it appears?
Reply
June 22, 2009 4:56 PM

pegasus

VaultWiki Team

No. We weren't using the same version of the file. See above again for the correct changes.

Reply
June 22, 2009 5:32 PM

tommythejoat

Regular Member

It looks like the hard part is done, but the links are not being fully formed. The screen snap of the status line from FireFox shows the bad reference when hovering over the footnote. Clicking goes to the top level of the forum as directed.

Reply
June 22, 2009 6:25 PM
pegasus

VaultWiki Team
This is because of an edit I asked you to make a few days ago... which is now unneeded. In vault/special_plugins.php, find:

Code:

if (THIS_SCRIPT == 'showwiki')

Replace with:

Code:

if ( $vbulletin->options['vault_seo'] AND strpos($_SERVER['REQUEST_URI'], '/' . $vbulletin->options['ces_wiki_php'] . '/') !== false )
Reply
June 22, 2009 6:54 PM

tommythejoat

Regular Member

Thanks. I think that took care of it.

By the way, I thought I saw something about highlighting the found text in my reading here, but I can't seem to find it now. Did I just imagine that?

If I want the symbols to be actually readable, what template needs to be changed?

======== later ========================

The class is special_footnote. I suppose I should just look it up myself. I am sure you have more critical things to do.

Reply
June 22, 2009 8:54 PM

pegasus

VaultWiki Team

What symbols?

Reply
June 22, 2009 10:29 PM

tommythejoat

Regular Member

[1]. [2].. etc. in the text and a, b, c... in the footnotes. They are too small for me to read on my normal screen. If you notice on Wikipedia, they are about 2/3rds the normal text size. i.e. if the text is 10 points, they are probably 6 points. I think the ones in Vault Wiki are probably 4 pts but they may be px sized. I did not look at the page dump to see.

===========later==========

Oops! I edited the wrong post in my attempt to not inflate the post count.

I can change special_footnote myself if I need to, I think.

Reply
June 22, 2009 11:26 PM

pegasus

VaultWiki Team

Yup, you should be able to do this with custom CSS on special_footnote or something else.

Reply

+ Reply

All times are GMT -4. The time now is 1:14 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Footnote numbering error

Issue Tools