Issue: [4.1.2] Lazy loaded images not showing up in XF2.2 in subsequent edit previews.

Issue Tools
- View Changes

July 23, 2021 3:42 AM
ACL

Regular Member
[4.1.2] Lazy loaded images not showing up in XF2.2 in subsequent edit previews.

While previewing an edited wiki page, wiki attachment images will sometimes not load. This seems to occur when activating the preview more than once. The initial first preview does show wiki attachment images.

Have a page open to edit something with wiki attachment images.
Preview what you've changed so far. Wiki attachment image included in the edited page loads fine in this first instance.
Return to editing as you might want to make some more changes.
Now preview your changes a second time. - Wiki attachment image included in the edited page no longer loads.

----

A missing javascript file is also recorded in the browser console when activating the preview (including the first preview). This happens regardless of whether the page has wiki attachments embedded with [file] bb code:

Code:

Loading failed for the <script> with source /js/vw/vw/min/lightbox.js.

Issue Details

Issue Number 6238

Issue Type Bug

Project VaultWiki 4.x Series

Category Editing Pages

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.2

Fixed Version 4.1.3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

September 2, 2021 7:57 PM

pegasus

VaultWiki Team

Fixed in the next release. XenForo 2.2's preview runs XF.activate on the preview HTML before that HTML is actually inserted to the document. Because of this, most information needed for initialization of lazy images was not available during XF.activate. We have applied a workaround (polling every 200ms to see if the element has joined the DOM if it has not already upon activation).

Additionally fixed a bug where certain images may not load if you jump to later images without loading prior images, then scroll back. This was most noticeable with lazy images added via AJAX if you were scrolled too far or some images disappeared from the DOM (such as the preview content). An optimization that assumed all images were present in the DOM at the same time had to be removed.

Reply

+ Reply

All times are GMT -4. The time now is 1:22 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1.2] Lazy loaded images not showing up in XF2.2 in subsequent edit previews.

Issue Tools