Issue: [4.1.2] Admin cp: BBcode button manager editor preview sizes all have 100% width

Issue Tools
- View Changes

July 5, 2021 7:59 AM
ACL

Regular Member
[4.1.2] Admin cp: BBcode button manager editor preview sizes all have 100% width

In the admin cp BBcode button manager, all four of VaultWiki's editor sizes render previews with the editor at 100% width. This is different to XenForo's own default four editor size previews where the width gets narrower from large > medium > small > extra small.

Seems this is just a case of some CSS classes not having rules applied:

toolbarWidthLimit--wikiButtons
toolbarWidthLimit--wikiButtonsMD
toolbarWidthLimit--wikiButtonsSM
toolbarWidthLimit--wikiButtonsXS

XenForo's own toolbarWidthLimit classes are declared in the admin template bb_code_button_manager_editor with the widths derived from App.php $container['editorToolbarSizes']:

toolbarWidthLimit--toolbarButtons: 900px
toolbarWidthLimit--toolbarButtonsMD: 575px
toolbarWidthLimit--toolbarButtonsSM: 420px
toolbarWidthLimit--toolbarButtonsXS: 320px

----

Additionally, and this could be my fault, I noticed some issues with the third button group (all easily and quickly fixable by any admin though):

Blank button with empty tooltip in third group. Fixed by dragging back to available buttons block.
Group 3's 'Buttons visible' field is set to (blank), which for some reason results in XF styling all the group buttons as if they will all be visible, with no change to button opacity (this looks like an inconsistency within XF itself and not caused by VW). The editor preview however matches with how the buttons appear on the front end (all buttons for that button group hidden behind 'more'). Fixed by changing visible buttons field to at least 1.

Issue Details

Issue Number 6226

Issue Type Bug

Project VaultWiki 4.x Series

Category Admin Panel

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.1.2

Fixed Version 4.1.3

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

July 8, 2021 2:22 AM

pegasus

VaultWiki Team

Hm... it seems like the blank buttons might be caused by some wiki BB-Codes being imported to XenForo with the Editor icon set to Image, but the image path being blank, when those BB-Codes should have the icon set to None.

Reply
July 16, 2021 12:34 AM

pegasus

VaultWiki Team

Fixed the toolbar preview width for wiki-related toolbars in the next release.

Reply
September 20, 2021 1:41 PM

pegasus

VaultWiki Team

1. I believe you can get a blank in the button manager with no tooltip, if something that was sown in the config before has had the underlying BB-Code entity deleted since it was added to the button config. Deleting a BB-Code does not appear to rebuild the button config. This looks like a bug in XenForo.

Related:
- When editing a custom BB-Code, XenForo lets you set the icon type to Font Awesome or Image even if you don't set which font-awesome icon / image to use. Since this creates blanks in the button manager (these do have tooltips though), this seems like a XenForo bug too.

2. The inconsistency when Visible buttons is not set should be fixed by XenForo. It may be that XenForo never expects the field to be blank, but right after upgrading from XF 2.1=>XF2.2, only moreRich->buttons is set. If the fields are missing, XenForo should consistently assume:
- buttonsVisible: -1
- align: left
- icon: fa-ellipsis-v

Marking this as fixed since the toolbar preview width is already handled. The rest are XenForo bugs and should be reported to them.

Reply

+ Reply

All times are GMT -4. The time now is 11:28 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: [4.1.2] Admin cp: BBcode button manager editor preview sizes all have 100% width

Issue Tools