Issue: Upgrade from 4.0.25 to 4.1.1 (XF1) stalls at Step 69 (27%)

Issue Tools
- View Changes

May 22, 2021 10:24 AM

wolven

New Member

Upgrade from 4.0.25 to 4.1.1 (XF1) stalls at Step 69 (27%)

Upgrade 4.025 -> 4.1.1 on XF 1 fails

Hi Pegasus,
I'm preparing for upgrade to XF2. I thought it's a clever idea to upgrade first on XF1 and then move all to XF2.
Therefore, I cloned the XF1 forum to a test site and followed the upgrade steps as described.
Running the upgrade script frem ACP starts fine but colour changes to red in step 69 (some table creation). 27% have already been done.
Restarting the script let the progress jump to 94% but nothing happens. It remains there. The ACp show as version 4.0.28.

So, please help. What is the reason for failing the upgrade?

Thanks in advance
Knut

Issue Details

Issue Number 6201

Issue Type Bug

Project VaultWiki 4.x Series

Category Install / Upgrade

Status Fixed

Priority 2 - Fatal / Database Errors

Affected Version 4.1.1

Fixed Version 4.1.1

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 4

Assigned Users (none)

Tags upgrade

May 22, 2021 12:33 PM

wolven

New Member

So I have tried to revert the update. Replay of Databasedump, then replay of old files.
When I follow the steps of the manue, the following happens: First comes an error messanng and then the link to the ugrade scipt. BUT: Behind the Update Script link lies the wrong path to the production server!
I have changed the Site Config, of course. I have no idea left.

I stop my attempt now and wait for your repsonse.

Thanks and best wishes

Reply
May 22, 2021 3:02 PM

pegasus

VaultWiki Team

Since you were not getting error messages, it sounds like you were just having problems with PHP timeouts. In this case, the best solution to progress is just to reload and continue (like how you got from 27% to 94%). If you still cannot progress, then some file edits might be needed to tweak the size of some batches so they can finish before your PHP times out. This would vary depending on the step you stall on.

Unfortunately, the % or Step number is not useful to figuring out where you are stuck. Those numbers vary depending on the version you start at and your configuration. To review an upgrade issue, we need the version the upgrade says it's currently working on, the step number, and the step description, all from the progress dialog.

As you reverted both your database and file system, your wiki should be working in the same state as when those backups were taken. If it is not, you probably have some caches which you need to reset. Such as PHP opcache (by restarting PHP), or possibly a file-based datastore.

If the upgrade script is pointing to the production server and not the test server, possibly the test server's XenForo setting for the Board URL is still pointing to the production server.

Reply

May 23, 2021 2:44 AM

wolven

New Member

Thanks for reply.
You are right. After reverting, I missed to set the right path. (remind myself not to work too lang)
So I corrected and started again. Same result. I stops in step 69- creation of vw_integrate_node.

And I found the following errors:

1st:

Code:

Error: Call to undefined function vw_XenForo_Model() - library/vw/_core/view/phrase/xf.php:249
Generiert durch: ....
Stapelverfolgung

#0 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/vw.php(91): vw_Phrase_View_XF->{closure}()
#1 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/vw.php(99): vw_Shutdown_Model->_exec_funcs('middle')
#2 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/xf.php(21): vw_Shutdown_Model->shutdown()
#3 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(72): vw_Shutdown_Model_XF->shutdown()
#4 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(53): vw_Progress_Instance->shutdown()
#5 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(113): vw_Progress_Instance->close()
#6 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/controller/progress/vw.php(235): vw_Progress_Instance->next()
#7 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_install/lib/upgradepath/steps/4/1/0/alpha/1/base/vw.php(2584): vw_Progress_Controller->close()
#8 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/controller/progress/steps/vw.php(85): vw_Install_UpgradePath_Steps_410alpha1_base_Controller->{closure}(Object(vw_Install_UpgradePath_Controller_XF), true)
#9 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/controller/progress/steps/vw.php(56): vw_Progress_Steps_Controller->call(Object(vw_Install_UpgradePath_Controller_XF), Object(Closure))
#10 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_install/lib/upgradepath/vw.php(80): vw_Progress_Steps_Controller->execute(Object(vw_Install_UpgradePath_Controller_XF))
#11 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/controller/progress/vw.php(169): vw_Install_UpgradePath_Controller->exec_script(Array)
#12 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/view/response/progress/vw.php(27): vw_Progress_Controller->execute()
#13 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/view/response/progress/vw.php(63): vw_Response_Progress_View->stream()
#14 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/XenForo/ViewAdmin.php(67): vw_Response_Progress_View->render()
#15 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/XenForo/ViewRenderer/Abstract.php(229): vw_XenForo_ViewAdmin->renderRaw()
#16 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/XenForo/ViewRenderer/Raw.php(53): XenForo_ViewRenderer_Abstract->renderViewObject('vw_XenForo_View...', 'Raw', Array, 'vw_general_view')
#17 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/XenForo/FrontController.php(624): XenForo_ViewRenderer_Raw->renderView('vw_XenForo_View...', Array, 'vw_general_view', NULL)
#18 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/XenForo/FrontController.php(176): XenForo_FrontController->renderView(Object(XenForo_ControllerResponse_View), Object(XenForo_ViewRenderer_Raw), Array)
#19 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/admin.php(13): XenForo_FrontController->run()
#20 {main}

Further:

Code:

ErrorException: Fatal Error: Uncaught Error: Call to undefined function vw_XenForo_Model() in /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/view/phrase/xf.php:249 Stack trace: #0 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/vw.php(91): vw_Phrase_View_XF->{closure}() #1 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/vw.php(99): vw_Shutdown_Model->_exec_funcs('middle') #2 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/xf.php(21): vw_Shutdown_Model->shutdown() #3 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(72): vw_Shutdown_Model_XF->shutdown() #4 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(53): vw_Progress_Instance->shutdown() #5 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(155): vw_Progress_Instance->close() #6 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/view/cp/progress/vw.php(524): vw_Progress_In - library/vw/_core/view/phrase/xf.php:249
Generiert durch: Chief, Vor 4 Minuten
Stapelverfolgung

#0 [internal function]: XenForo_Application::handleFatalError()
#1 {main}

Benötigter Status

array(3) {
  ["url"] => string(64) "https://www.tt-board.eu/xf2dev/admin.php?wiki/upgrade&progress=1"
  ["_GET"] => array(3) {
    ["wiki/upgrade"] => string(0) ""
    ["progress"] => string(1) "1"
    ["panel"] => string(7) "install"
  }
  ["_POST"] => array(4) {
    ["wiki/upgrade"] => string(0) ""
    ["progress"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["panel"] => string(7) "install"
  }
}

3rd:

Code:

ErrorException: Fatal Error: Uncaught Error: Call to undefined function vw_XenForo_Model() in /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/view/phrase/xf.php:249 Stack trace: #0 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/vw.php(91): vw_Phrase_View_XF->{closure}() #1 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/vw.php(99): vw_Shutdown_Model->_exec_funcs('middle') #2 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/model/shutdown/xf.php(21): vw_Shutdown_Model->shutdown() #3 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(72): vw_Shutdown_Model_XF->shutdown() #4 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(53): vw_Progress_Instance->shutdown() #5 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/instance/progress/vw.php(155): vw_Progress_Instance->close() #6 /var/www/vhosts/tt-board.eu/httpdocs/xf2dev/library/vw/_core/view/cp/progress/vw.php(524): vw_Progress_In - library/vw/_core/view/phrase/xf.php:249
Generiert durch: Chief, Vor 6 Minuten
Stapelverfolgung

#0 [internal function]: vw_CP_Progress_View->handle_fatal_error()
#1 {main}

Benötigter Status

array(3) {
  ["url"] => string(64) "https://www.tt-board.eu/xf2dev/admin.php?wiki/upgrade&progress=1"
  ["_GET"] => array(3) {
    ["wiki/upgrade"] => string(0) ""
    ["progress"] => string(1) "1"
    ["panel"] => string(7) "install"
  }
  ["_POST"] => array(4) {
    ["wiki/upgrade"] => string(0) ""
    ["progress"] => string(1) "1"
    ["_xfToken"] => string(8) "********"
    ["panel"] => string(7) "install"
  }
}

Hope that helps.

Thanks in advance...

May 23, 2021 3:04 AM

wolven

New Member

addtional question:
Since I try to upgrade vw in the XF1.5 environment: Would this be your advice?
My idea was: Upgrade vw to the latest in XF1.5 -- upgrade XF to 2.2.5 - update the files for vw - ready.
If you recomment differently e.g. first to upgrade XF and then upgrade vw, pls advice.

Thanks.

Reply
May 24, 2021 10:36 AM
pegasus

VaultWiki Team
In library/vw/_core/view/phrase/xf.php, find:

Code:

vw_XenForo_Model('XenForo_Model_Language')->rebuildLanguageCaches();

Replace with:

Code:

vw_XenForo_Model::fetch('XenForo_Model_Language')->rebuildLanguageCaches();

As for the environment / order-of-upgrade question, VaultWiki is capable of upgrading using either path you mention. However, once you start one path, you must complete it (get the upgrade successful message) and not switch paths, or your database will be in an inconsistent state and could have unexpected errors. As for which path is preferable, I tend to prefer upgrading VaultWiki to the newest version before upgrading XenForo, then updating again after upgrading XenForo. This is because I am less comfortable asking XenForo 2 to reach back and run upgrade scripts for a VaultWiki version that wasn't originally designed for XenForo 2. So I prefer the path you are attempting.
Reply

May 24, 2021 12:10 PM

wolven

New Member

Hi Pegasus,

thanks for reply and advice.
I changed the file and restarted the script. It failed immediately in step 71

Code:

    Upgrading to 4.1.0 Alpha 1
    Step 71
    Updating data in table: xf_report
    An exception occurred: Call to undefined method vw_DB_MySQL_Model_XF::affected_rows() in [vw-platform]/library/vw/_install/lib/upgradepath/steps/4/1/0/alpha/1/C/xf0.php on line 293
        #0: vw_Install_UpgradePath_Steps_410alpha1_C_Controller_XF0->{closure}() in [vw-core]/controller/progress/steps/vw.php at line 85
        #1: vw_Progress_Steps_Controller->call() in [vw-core]/controller/progress/steps/vw.php at line 56
        #2: vw_Progress_Steps_Controller->execute() in [vw-platform]/library/vw/_install/lib/upgradepath/vw.php at line 80
        #3: vw_Install_UpgradePath_Controller->exec_script() in [vw-core]/controller/progress/vw.php at line 169
        #4: vw_Progress_Controller->execute() in [vw-core]/view/response/progress/vw.php at line 27
        #5: vw_Response_Progress_View->stream() in [vw-core]/view/response/progress/vw.php at line 63
        #6: vw_Response_Progress_View->render() in [vw-platform]/library/vw/XenForo/ViewAdmin.php at line 67
        #7: vw_XenForo_ViewAdmin->renderRaw() in [vw-platform]/library/XenForo/ViewRenderer/Abstract.php at line 229
        #8: XenForo_ViewRenderer_Abstract->renderViewObject() in [vw-platform]/library/XenForo/ViewRenderer/Raw.php at line 53
        #9: XenForo_ViewRenderer_Raw->renderView() in [vw-platform]/library/XenForo/FrontController.php at line 624
        #10: XenForo_FrontController->renderView() in [vw-platform]/library/XenForo/FrontController.php at line 176
        #11: XenForo_FrontController->run() in [vw-platform]/admin.php at line 13

any ideas?

Best regards

May 24, 2021 12:59 PM
wolven

New Member
Found this error by myself.

I think in library/vw/_install/lib/upgradepath/steps/4/1/0/alpha/1/C/xf0.php line 293 the code must change from

Code:

$i = count($types) - vw_DB::get()->query()->affected_rows();

to

Code:

$i = count($types) - vw_DB::get()->func()->affected_rows();

This helps a bit but later on it stops without errors. I started it again, then it runs a bit and stops a lot.
I was able to start it again and again. We have definetly a timing problem.
I changed the php values of max_execution_time to rediculous 300s. But it doesn't help. It always stops in database actions like Step 43 in 4.1.0 RC 2 - altering vw_redirect.

Any advice for php params to change (I used the php-fpm)?
Reply
May 24, 2021 1:19 PM

wolven

New Member

After quick checking I have noticed that I have lost content by this update. Puhh, this is not good.
I have lost more than one article. I assume this happend during some converting jobs.
---
Edit: I checked this again. I suspect that all content containing umlauts in the title (äüö) are not be displayed anymore. Pretty hard for Germans ( :-) )

Please advice again.

Thanks.

Reply
May 25, 2021 10:26 AM
pegasus

VaultWiki Team
I am surprised that altering vw_redirect is timing out. Possibly the table is very large. Anyway, you are almost done with the RC 2 changes and there are only a handful of scripts left. If you try to make some changes manually, maybe by phpmyadmin, or by command line, then the upgrade will realize it can skip them.

MySQL queries:

Code:

ALTER TABLE vw_redirect DROP ipaddress

Code:

ALTER TABLE vw_revision DROP ipaddress

Once these changes are made, the upgrade should continue.

As for umlaut content not loading, I would not try to diagnose anything until the upgrade completely finishes. It is possible some things are unavailable due to the in-between state. If it is still like that after the upgrade, we can look into it.
Reply
May 25, 2021 12:04 PM

wolven

New Member

The upgrade was done yesterday. I have access to the wiki. Than I found the umlaut problem.
There should be no in-between state. Control center says everything is fine.

How can the umlaut prob be resolved?

BTW the feeds show some errors in the headlines, too

Cheers
Knut

Reply
May 25, 2021 12:18 PM

wolven

New Member

I send some pictures of the umlaut and feed problem.
See attachments.

Reply
May 26, 2021 1:20 PM
pegasus

VaultWiki Team
Fixed the umlaut problem in the next release. The problem occurred in XenForo 1.x when URLs were rebuilt (editing a page normally would not typically cause it).

In library/vw/_core/controller/dm/xf.php, find:

Code:

$this->instance->setExistingData($existing, true); foreach ($existing AS $field => $value) { if (!$this->get_valid_field($field))

Replace with:

Code:

$this->instance->setExistingData($existing, true); foreach ($existing AS $field => $value) { if (!$this->get_valid_field($field) AND $this->get_info($field) === null)

Further research is needed to determine if a similar problem exists under other platforms.

The problem with "the feeds [showing] some errors in the headlines" appears, at least in the case of the phrase vw_feed_index, to be due to translations made from the default language to your custom language. In some cases, the translations are incorrect or outdated. Since we do not provide translations ourselves, you should reach out to your language pack maintainer for an updated language pack for your version. You will notice that there have been a lot of changes to the default language since your previous version. There are several hundred completely new phrases. For existing phrases, you can find a list of translations on your site that need to be reviewed here: admin.php?phrases/outdated
Reply
May 26, 2021 1:27 PM

pegasus

VaultWiki Team

If you have issues converting VaultWiki from XF 1.x to XF 2.x, please let me know and I will keep working on your ticket. You will notice another user had issues as discussed in this thread: https://www.vaultwiki.org/issues/6197/
The user eventually got stuck near the end and we asked to open a ticket, but that never happened. If it happens to you, hopefully we can resolve it quickly since you already have an open ticket. If you are successful, I will see about pushing out a new version quickly for you to use in your final migration.

Reply
May 27, 2021 3:12 AM

wolven

New Member

Thank you very much.

I will check all of this. First, I see all the content again.
As for the feeds: Is it sufficient to download the product phrases from ACP in order to translate this?
I would translate it in German and send the xml back to you for checking. If ok, you can use it. I have no knowledge of any German language pack of vault wiki.

If I have all fine at XF1 Test site, I do a test upgrade to XF2. I will post the result here.
Thanks for your support.

Reply
May 27, 2021 9:30 AM

pegasus

VaultWiki Team

Yes, the typical way to deal with translations is to download / share an XML that was downloaded from the AdminCP that contains only the phrases in the add-on. In VaultWiki on XF 1.x, you can also find the default language XML at library/vw/_install/lib/db/xml/language/xf.xml.

Reply

+ Reply

All times are GMT -4. The time now is 11:29 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Upgrade from 4.0.25 to 4.1.1 (XF1) stalls at Step 69 (27%)

Issue Tools