Issue: Can't approve an edit for wiki content

Issue Tools
- View Changes

December 2, 2020 12:04 PM

mazzly

Junior Member

Can't approve an edit for wiki content

A user has made an edit to a wiki content and it shows up in the Approval queue.

Try to perform any task (approve/deny/nothing) nothing happens, some message flashes and page reloads with same pending approval still there..

Opening the "compare revision"-page I can then choose from the tools button -> approve, which sends me to another page with the text: "Are you sure you want to approve the 1 selected items?"

Clicking yes it gives the error:
"Oops! We ran into some problems. Please try again later. More error details may be in the browser console."
or
"Another user is performing a similar action at the moment. Please try again in a few seconds."

Nothing shows up in the error log..

A bit bad that we cannot approve edits by a user..

Issue Details

Issue Number 6131

Issue Type Bug

Project VaultWiki 4.x Series

Category Moderator Tools

Status Fixed

Priority 3 - Loss of Functionality

Affected Version 4.1.1

Fixed Version 4.1.1

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

December 2, 2020 5:41 PM
pegasus

VaultWiki Team
When approving an edit, this is behavior I see:

A message flashes very quickly "Oops! We ran into some problems. Please try again later."
The page reloads.
The pending approval is no longer there. If I visit the page, I see that the edit was approved.

I will look into the erroneous message flashing, but as my edit is successfully approved, I cannot reproduce the worst part of your issue.
If you are still experiencing this issue, I recommend opening a ticket here: https://www.vaultwiki.org/members/?do=tickets
Please add my user "vaultwiki" as a wiki moderator so I can see the approval queue.
Reply
December 3, 2020 12:28 PM

mazzly

Junior Member

Tried again now and see this in JS console:

Fatal Error: attempted to instantiate non-existent class vw_OptList_Model 
[vw-core]/model/optlist/vw.php does not exist or does not contain the specified class. 
 
#0: vw_Hard_Core::fetch_object() in [vw-platform]/src/addons/vw/vw/_hard/core.php at line 766 
#1: vw_Hard_Core::model() in [vw-core]/controller/dm/page/vw.php at line 850 
#2: vw_DM_Page_Controller->process_revision() in [vw-core]/controller/dm/page/vw.php at line 811 
#3: vw_DM_Page_Controller->pre_save() in [vw-platform]/src/addons/vw/vw/XF/Entity/EntityBase.php at line 485 
#4: vw\vw\XF\Entity\EntityBase->_preSave() in [vw-platform]/src/XF/Mvc/Entity/Entity.php at line 1355 
#5: XF\Mvc\Entity\Entity->preSave() in [vw-platform]/src/addons/vw/vw/XF/Entity/EntityBase.php at line 476 
#6: vw\vw\XF\Entity\EntityBase->vwPreSave() in [vw-platform]/src/addons/vw/vw/XF/Entity/EntityBase.php at line 531 
#7: vw\vw\XF\Entity\EntityBase->vwSave() in [vw-core]/controller/dm/xf2.php at line 382 
#8: vw_DM_Controller_XF2->save() in [vw-core]/controller/dm/revision/vw.php at line 683 
#9: vw_DM_Revision_Controller->post_save_each() in [vw-platform]/src/addons/vw/vw/XF/Entity/EntityBase.php at line 628 
#10: vw\vw\XF\Entity\EntityBase->_postSave() in [vw-platform]/src/XF/Mvc/Entity/Entity.php at line 1266 
#11: XF\Mvc\Entity\Entity->save() in [vw-platform]/src/addons/vw/vw/XF/Entity/EntityBase.php at line 551 
#12: vw\vw\XF\Entity\EntityBase->vwSave() in [vw-core]/controller/dm/xf2.php at line 382 
#13: vw_DM_Controller_XF2->save() in [vw-core]/controller/ui/imod/action/approve/vw.php at line 217 
#14: vw_UI_iMod_Action_Approve_Controller->process_approve_generic() in [vw-core]/controller/ui/imod/action/approve/vw.php at line 164 
#15: vw_UI_iMod_Action_Approve_Controller->perform_doapprove() in [vw-core]/controller/ui/imod/action/base/vw.php at line 106 
#16: vw_UI_iMod_Action_base_Controller->process() in [vw-platform]/src/addons/vw/vw/Handler/InlineMod/Base/AbstractAction.php at line 183 
#17: vw\vw\Handler\InlineMod\Base\AbstractAction->applyToEntity() in [vw-platform]/src/XF/InlineMod/AbstractAction.php at line 87 
#18: XF\InlineMod\AbstractAction->applyInternal() in [vw-platform]/src/XF/InlineMod/AbstractAction.php at line 80 
#19: XF\InlineMod\AbstractAction->apply() in [vw-platform]/src/XF/Pub/Controller/InlineMod.php at line 131 
#20: XF\Pub\Controller\InlineMod->actionPerform() in [vw-platform]/src/addons/vw/vw/XF/Pub/Controller/InlineMod.php at line 41 
#21: vw\vw\XF\Pub\Controller\InlineMod->actionPerform() in [vw-platform]/src/XF/Mvc/Dispatcher.php at line 350 
#22: XF\Mvc\Dispatcher->dispatchClass() in [vw-platform]/src/XF/Mvc/Dispatcher.php at line 257 
#23: XF\Mvc\Dispatcher->dispatchFromMatch() in [vw-platform]/src/XF/Mvc/Dispatcher.php at line 113 
#24: XF\Mvc\Dispatcher->dispatchLoop() in [vw-platform]/src/XF/Mvc/Dispatcher.php at line 55 
#25: XF\Mvc\Dispatcher->run() in [vw-platform]/src/XF/App.php at line 2300 
#26: XF\App->run() in [vw-platform]/src/XF.php at line 465 
#27: XF::runApp() in [vw-platform]/index.php at line 20 
 
Please forward this error to VaultWiki technical support at <a href="https://www.vaultwiki.org/support/4X/">https://www.vaultwiki.org/support/4X/</a> or email <a href="mailto:support@vaultwiki.org">support@vaultwiki.org </a>

Reply
December 3, 2020 1:13 PM
pegasus

VaultWiki Team
It seems like portions of a 4.2.x file were inadvertently merged with the 4.1.1 package. In src/addons/vw/vw/_core/controller/dm/page/vw.php, find:

Code:

$gzipped = ($revision['flags'] & vw_Hard_Core::model('OptList')->bit('revision_flags', 'gzip'));

Replace with:

Code:

$gzipped = ($revision['flags'] & vw_Hard_Core::model('Bitfield')->get_bit('misc', 'vw_revision_flags', 'gzip'));

A new build of the package has been issued to include this change.
Reply

+ Reply

All times are GMT -4. The time now is 7:41 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Can't approve an edit for wiki content

Issue Tools