Issue: VW 2.2 styling issues

Issue Tools
- View Changes

October 12, 2020 9:46 AM

expanserpb

Junior Member

VW 2.2 styling issues

Please see image. Post Xf 2.2 test migration

Cannot access suggested templates
Icons for wiki specific BBcode not working

Issue Details

Issue Number 6102

Issue Type Bug

Project VaultWiki 4.x Series

Category Unknown

Status Fixed

Priority 4 - Warnings / Script Errors

Affected Version 4.1.0

Fixed Version 4.1.1

Milestone (none)

Software DependencyXenForo 2.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

October 12, 2020 12:04 PM

expanserpb

Junior Member

Swapped out the icons for FA choices anyway

Reply
October 12, 2020 2:31 PM

pegasus

VaultWiki Team

Looks like you have Javascript errors in the console, since a number of Javascript things in the screen shot are not working. Please post the error message. I cannot reproduce this specific problem on this page of your test site.

Reply
October 12, 2020 3:16 PM

expanserpb

Junior Member

Now I can't replicate!

Reply
October 12, 2020 3:24 PM
pegasus

VaultWiki Team
I believe there was an unintended reversion in the master style template for the editor. On some of your custom styles, it is possible that a custom edit has prevented the reversion from occurring. Anyway, I have noticed on my test board that on styles without the reversion, or with the reversion fixed, I can get an editor that looks like yours.

To fix the issue I had to add a method to the class in js/vw/vw/xf2/editor.js (there is a scrollbar here):

Code:

toggle: function(editor, config) { var scope = this; var fn = function() { vw_Editor_Abstract.prototype.toggle.call(scope, editor, config); }; if (editor.$target) { fn(); } else { // editor not inited yet $(document).on("editor:init", function(a, ed, sc) { fn(); }); } },

You may have difficulty making this change if you are not using the non-minified Javascript files.

The problem occurs because the wiki's area chooser wants to refresh the editor on startup. However, since XenForo 2.2, the timing for editor startup has changed.
Reply
October 12, 2020 6:31 PM

pegasus

VaultWiki Team

Also fixed a bug switching the editor from a regular area to an area that forces content to be exactly a template, when the new area only has 1 template pack, and that template pack only has 1 template. After switching, the editor was removed, but the template parameter inputs were not loaded.

Reply

+ Reply

All times are GMT -4. The time now is 10:40 AM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: VW 2.2 styling issues

Issue Tools