Issue: [4.1.0 RC2 Build 001] Upgrade Error

Error: Class 'vw\vw\Handler\Search\Data\vw_Hard_Core' not found src/addons/vw/vw/Handler/Search/Data/Base.php:277

Generated by: gerryvz Mar 20, 2020 at 4:26 PM

Stack trace

#0 src/XF/Search/Data/AbstractData.php(31): vw\vw\Handler\Search\Data\Base->setupMetadataStructure()
#1 src/addons/vw/vw/Handler/Search/Data/Base.php(255): XF\Search\Data\AbstractData->getMetadataStructure()
#2 src/addons/vw/vw/Handler/Search/Data/Base.php(140): vw\vw\Handler\Search\Data\Base->_getMetaDataFromSearchMeta()
#3 src/addons/vw/vw/Handler/Search/Data/Base.php(66): vw\vw\Handler\Search\Data\Base->getMetaData()
#4 src/XF/Search/Search.php(37): vw\vw\Handler\Search\Data\Base->getIndexData()
#5 src/XF/Search/Search.php(59): XF\Search\Search->index()
#6 src/XF/Search/Search.php(85): XF\Search\Search->indexEntities()
#7 src/XF/Job/SearchRebuild.php(57): XF\Search\Search->indexRange()
#8 src/XF/Job/Manager.php(253): XF\Job\SearchRebuild->run()
#9 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal()
#10 src/addons/vw/vw/_install/lib/upgradepath/steps/4/1/0/rc/2/XFES/xf2.php(47): XF\Job\Manager->runJobEntry()
#11 src/addons/vw/vw/Setup.php(300): vw_Install_UpgradePath_Steps_410rc2_XFES_Controller_XF2->{closure}()
#12 src/addons/vw/vw/Setup.php(967): vw\vw\Setup->vwRunStep()
#13 src/XF/Admin/Controller/AddOn.php(576): vw\vw\Setup->upgrade()
#14 src/XF/Mvc/Dispatcher.php(350): XF\Admin\Controller\AddOn->actionUpgrade()
#15 src/XF/Mvc/Dispatcher.php(257): XF\Mvc\Dispatcher->dispatchClass()
#16 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch()
#17 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop()
#18 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#19 src/XF.php(391): XF\App->run()
#20 admin.php(13): XF::runApp()
#21 {main}

Request state

array(4) {
["url"] => string(39) "/forums/admin.php?add-ons/vw-vw/upgrade"
["referrer"] => string(63) "https://www.500eboard.co/forums/admin.php?add-ons/vw-vw/upgrade"
["_GET"] => array(1) {
["add-ons/vw-vw/upgrade"] => string(0) ""
}
["_POST"] => array(7) {
["_xfProcessing"] => string(1) "1"
["continue"] => string(1) "1"
["confirm"] => string(1) "1"
["params"] => string(32) "{"step":20,"version_id":4010072}"
["count"] => string(2) "21"
["finished"] => string(1) "0"
["_xfToken"] => string(8) "********"
}
}

The upgrade was unable to complete, despite two tries, so I am still using RC1.

This occurs when upgrading to RC 2 if you also have XenForo Enhanced Search installed (related to a recent issue you reported).

In src/addons/vw/vw/Handler/Search/Data/Base.php, find:
Replace with:
This change has been applied to the current build.

I'll re-download the build and re-upload and install, and report back in the next hour or two.

Second error received after attempting to upgrade, with newly downloaded version.

XF\Db\InvalidQueryException: MySQL statement prepare error [1064]: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND `revisionid` NOT IN () GROUP BY field_value_id LIMIT 0' at line 1 in src/XF/Db/AbstractStatement.php at line 228

XF\Db\AbstractStatement->getException() in src/XF/Db/Mysqli/Statement.php at line 196
XF\Db\Mysqli\Statement->getException() in src/XF/Db/Mysqli/Statement.php at line 39
XF\Db\Mysqli\Statement->prepare() in src/XF/Db/Mysqli/Statement.php at line 54
XF\Db\Mysqli\Statement->execute() in src/XF/Db/AbstractAdapter.php at line 94
XF\Db\AbstractAdapter->query() in src/addons/vw/vw/_core/controller/db/xf2.php at line 148
vw_DB_Controller_XF2->query_read() in src/addons/vw/vw/_core/model/db/mysql/vw.php at line 25
vw_DB_MySQL_Model->select() in src/addons/vw/vw/_core/controller/dm/fieldrevision/vw.php at line 320
vw_DM_FieldRevision_Controller->delete_multiple() in src/addons/vw/vw/_core/controller/dm/vw.php at line 147
vw_DM_Controller->delete_multiple() in src/addons/vw/vw/_core/controller/dm/revision/vw.php at line 2290
vw_DM_Revision_Controller->delete_multiple() in src/addons/vw/vw/_core/controller/dm/vw.php at line 147
vw_DM_Controller->delete_multiple() in src/addons/vw/vw/_core/model/cron/deferred/node/vw.php at line 161
vw_Cron_Deferred_Node_Model->delete() in src/addons/vw/vw/_core/model/cron/deferred/node/vw.php at line 115
vw_Cron_Deferred_Node_Model->run() in src/addons/vw/vw/_core/model/cron/deferred/vw.php at line 64
vw_Cron_Deferred_Model->exec() in src/addons/vw/vw/Handler/Job/Defer.php at line 30
vw\vw\Handler\Job\Defer->run() in src/XF/Job/Manager.php at line 253
XF\Job\Manager->runJobInternal() in src/XF/Job/Manager.php at line 195
XF\Job\Manager->runJobEntry() in src/XF/Job/Manager.php at line 111
XF\Job\Manager->runByIds() in src/XF/Admin/Controller/Tools.php at line 120
XF\Admin\Controller\Tools->actionRunJob() in src/XF/Mvc/Dispatcher.php at line 350
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 257
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 113
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 55
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2184
XF\App->run() in src/XF.php at line 391
XF::runApp() in admin.php at line 13

XF\Db\InvalidQueryException: MySQL statement prepare error [1064]: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ') AND `revisionid` NOT IN () GROUP BY field_value_id LIMIT 0' at line 1 src/XF/Db/AbstractStatement.php:228

Generated by: gerryvz Mar 20, 2020 at 6:22 PM

Stack trace

SELECT * FROM `vw_field_revision` WHERE `field_value_id` IN () AND `revisionid` NOT IN () GROUP BY field_value_id LIMIT 0
------------

#0 src/XF/Db/Mysqli/Statement.php(196): XF\Db\AbstractStatement->getException()
#1 src/XF/Db/Mysqli/Statement.php(39): XF\Db\Mysqli\Statement->getException()
#2 src/XF/Db/Mysqli/Statement.php(54): XF\Db\Mysqli\Statement->prepare()
#3 src/XF/Db/AbstractAdapter.php(94): XF\Db\Mysqli\Statement->execute()
#4 src/addons/vw/vw/_core/controller/db/xf2.php(148): XF\Db\AbstractAdapter->query()
#5 src/addons/vw/vw/_core/model/db/mysql/vw.php(25): vw_DB_Controller_XF2->query_read()
#6 src/addons/vw/vw/_core/controller/dm/fieldrevision/vw.php(320): vw_DB_MySQL_Model->select()
#7 src/addons/vw/vw/_core/controller/dm/vw.php(147): vw_DM_FieldRevision_Controller->delete_multiple()
#8 src/addons/vw/vw/_core/controller/dm/revision/vw.php(2290): vw_DM_Controller->delete_multiple()
#9 src/addons/vw/vw/_core/controller/dm/vw.php(147): vw_DM_Revision_Controller->delete_multiple()
#10 src/addons/vw/vw/_core/model/cron/deferred/node/vw.php(161): vw_DM_Controller->delete_multiple()
#11 src/addons/vw/vw/_core/model/cron/deferred/node/vw.php(115): vw_Cron_Deferred_Node_Model->delete()
#12 src/addons/vw/vw/_core/model/cron/deferred/vw.php(64): vw_Cron_Deferred_Node_Model->run()
#13 src/addons/vw/vw/Handler/Job/Defer.php(30): vw_Cron_Deferred_Model->exec()
#14 src/XF/Job/Manager.php(253): vw\vw\Handler\Job\Defer->run()
#15 src/XF/Job/Manager.php(195): XF\Job\Manager->runJobInternal()
#16 src/XF/Job/Manager.php(111): XF\Job\Manager->runJobEntry()
#17 src/XF/Admin/Controller/Tools.php(120): XF\Job\Manager->runByIds()
#18 src/XF/Mvc/Dispatcher.php(350): XF\Admin\Controller\Tools->actionRunJob()
#19 src/XF/Mvc/Dispatcher.php(257): XF\Mvc\Dispatcher->dispatchClass()
#20 src/XF/Mvc/Dispatcher.php(113): XF\Mvc\Dispatcher->dispatchFromMatch()
#21 src/XF/Mvc/Dispatcher.php(55): XF\Mvc\Dispatcher->dispatchLoop()
#22 src/XF/App.php(2184): XF\Mvc\Dispatcher->run()
#23 src/XF.php(391): XF\App->run()
#24 admin.php(13): XF::runApp()
#25 {main}

Request state

array(4) {
["url"] => string(31) "/forums/admin.php?tools/run-job"
["referrer"] => string(145) "https://www.500eboard.co/forums/admin.php?tools/run-job&only_ids=814&_xfRedirect=https%3A%2F%2Fwww.500eboard. co%2Fforums%2Fadmin.php%3Fadd-ons%2F"
["_GET"] => array(1) {
["tools/run-job"] => string(0) ""
}
["_POST"] => array(3) {
["_xfRedirect"] => string(50) "https://www.500eboard.co/forums/admin.php?add-ons/"
["_xfToken"] => string(8) "********"
["only_ids"] => string(3) "814"
}
}

This is not actually part of the upgrade. After every upgrade, deferred tasks that failed before the upgrade at any time during a previous version are attempted again in case those tasks were fixed.

This error is due to a deferred task that failed while deleting old edits but managed to successfully deleted those edits already anyway. When reattempting, the edits are already gone and a database error occurs due to the missing IDs. This is due to a bug in the task where it trusts the data to exist when sending it to the delete manager, even though it should not make that assumption. This is a rare situation, and it will be fixed in the next build. The bug has existed, leaving open the potential for errors like this, since 4.0.0 RC 1 in 2014.

Note that each task is only attempted once and if it still fails, reloading the page simply bypasses it.

I have not received any further errors since uploading and updating the modified version of the RC2 code. Thanks.