• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 4.x Series
    • Bug
    • [4.1 Beta 3] Styling tweaks: Miscellaneous minor issues for area and content lists, tab-less mode

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: [4.1 Beta 3] Styling tweaks: Miscellaneous minor issues for area and content lists, tab-less mode

    • Issue Tools
      • View Changes
    1. issueid=5866 September 20, 2019 8:22 AM
      ACL ACL is offline
      Regular Member
      [4.1 Beta 3] Styling tweaks: Miscellaneous minor issues for area and content lists, tab-less mode

      This issue covers a few really minor styling-related issues for your consideration.

      1) Sub-areas in Area block: Empty node-statsMeta and whitespace.

      On my test site, the .node-statsMeta element (shown for narrower responsive width) contains a <dl></dl> element with nothing within it. This causes unnecessary whitespace on narrow displays. Whether or not the lack of any dt/dd child elements is expected, it might be worth implementing an XF content check for this section of vw_area_bit. For example, find:
      Code:
      				<div class="vw-area-stats-contain node-statsMeta">
      					<dl class="vw-content-list-stats">
      						<xf:foreach loop="{$statistics}" value="{$stat}">
      							<dt>{$stat.label|raw}:</dt>
      							<dd>{$stat.stat|raw}</dd>
      						</xf:foreach>
      					</dl>
      				</div>
      Replace with:
      Code:
      				<div class="vw-area-stats-contain node-statsMeta">
      					<xf:if contentcheck="true">
      						<dl class="vw-content-list-stats">
      							<xf:contentcheck>
      								<xf:foreach loop="{$statistics}" value="{$stat}">
      									<dt>{$stat.label|raw}:</dt>
      									<dd>{$stat.stat|raw}</dd>
      								</xf:foreach>
      							</xf:contentcheck>
      						</dl>
      					</xf:if>
      				</div>

      Attachment 1697


      2) Area content list block: Latest wrapping to new line.

      In the default XF style, the last change timestamp in area page lists (vw-content-list-update structItem-cell structItem-cell--latest) can sometimes wrap onto a new line when the printed time is long, e.g. Wednesday at x:xx PM. It seems that the width is a few pixels too small in order to fit the status icon and time. Lowering the right padding for .vw-content-list-update dt helps to an extent when the timestamp is x:xx PM, but not for xx:xx PM e.g. Wednesday 10:01 PM.


      Attachment 1696


      3) Tab-less 'controls' button: Shown despite zero menu items, border-radius not applied.

      Navigating to a red link (uncreated page) with an account that lacks the relevant permission to create new pages reveals a scenario where the 'controls' menu is displayed without any visible menu options. In this scenario, it'd make sense to not display this button.

      In the XF default style, this button lacks the border-radius on the top right and bottom right corners because it isn't the last element in the button group. As soon as this button is clicked, the menu element is relocated within in the DOM structure and this border-radius styling is resolved. XFMG seems to workaround this by wrapping the "..." button and menu in a containing .buttonGroup-buttonWrapper element, i.e.:
      Code:
      <xf:if is="$menuTabs is not empty">
      	<div class="buttonGroup-buttonWrapper">
      		<xf:button class="button--link menuTrigger" data-xf-click="menu" aria-expanded="false" aria-haspopup="true" title="{{ phrase('vw_controls')|for_attr }}">•••</xf:button>
      		<div class="menu" data-menu="menu" aria-hidden="true">
      			<div class="menu-content">
      				<h4 class="menu-header">{{ vw_phrase('vw_controls') }}</h4>
      				<div class="menu-scroller">
      					{$menuTabs|raw}
      				</div>
      			</div>
      		</div>
      	</div>
      </xf:if>
      4) Tab-less watch button icon: Use fa-eye instead of fa-bell. Update 08/2020: No longer applicable due to changes in XF 2.2.

      In XenForo 2.0/2.1, the bell icon represents the 'Alerts' menu in the main navigation, while the eye icon is utilised in structured lists to show the watched status of content (e.g. threads in forum view). For this reason I think that fa-eye might be more appropriate for this VaultWiki feature. Update 08/2020: I take back this concern. Due to XF2.2 changes, fa-bell has replaced fa-eye in watched lists.


      5) Tab-less 'main' button: fa-undo icon.

      In certain scenarios, e.g. editing a page or viewing revision history, this button could be ambiguous to people not already familiar with its purpose. These people might think it means 'undo this revision'. But as for an alternative icon, I don't have a solid answer. Perhaps fa-file-alt could work. Or even the default icon for each page content type, e.g. template page would use fa-puzzle-piece category fa-sitemap, and so on.


      6) Area-tree top border and responsive medium/narrow widths.

      The existing CSS border-top: none; for :nth-child(2), :nth-child(3) could be adjusted when window width crosses responsiveMedium and responsiveNarrow breakpoints. The suggestion I offered in issue 5730 didn't cater for borders. The below CSS edit to vw_area.less seems to do the trick:

      Find:
      Code:
      .vw-area-tree:first-child, .vw-area-tree:nth-child(2), .vw-area-tree:nth-child(3) {
      	border-top: none;
      }
      Replace with:
      Code:
      .vw-area-tree:first-child {
      	border-top: none;
      }
      
      @media (min-width: @xf-responsiveMedium) {
      	.vw-area-tree:nth-child(3) {
      		border-top: none;
      	}
      }
      
      @media (min-width: @xf-responsiveNarrow) {
      	.vw-area-tree:nth-child(2) {
      		border-top: none;
      	}
      }
      This works backwards to a lot of the XF media queries, with min-width instead of max-width. I figured that this method might be more compatible with custom styles as it does not require re-adding borders from node_list.less (which may be different from style to style). Or you might have a different approach/idea .


      ----

      Comments, thoughts, etc on any/all of these tweaks?
    Issue Details
    Issue Number 5866
    Issue Type Bug
    Project VaultWiki 4.x Series
    Category Styling / CSS
    Status Fixed
    Priority 7 - Minor Features / Enhancements
    Affected Version 4.1.0 Beta 3
    Fixed Version (none)
    Milestone (none)
    Software DependencyXenForo 2.x
    License TypePaid
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 2
    Assigned Users (none)
    Tags (none)




    1. January 1, 2020 2:24 PM
      pegasus pegasus is offline
      VaultWiki Team
      1) I was struggling to find this part of the template. It looks like the offending part was changed in 4.1.0 Alpha 3. This suggests you may need to revert your vw_area_bit template.

      2) While the expected behavior is for long times to wrap to a new name, this has been improved slightly in wiki lists by moving the update-icon to the same position as update-avatars in thread lists (after the update-text). This change is effective in the next release.

      3) It looks like this was fixed in a subsequent build of 4.1.0 Beta 3.

      4) There is a discrepancy in XF2 where different icons are used for this. In thread lists, there is an eye as an indicator, showing that it is currently watched, however in some watch-related forms, the icon for the submit button is bell-related. The bell related icons are named internally for "notifications". Since the tabless button is not an indicator alone, but leads to a watch-related form where one would manage notifications for the wiki content, the bell icon was chosen. This may come down to personal preference. I don't know if we would change this without more upvotes for it. If you really want this and don't want to just edit your vw_tab.less locally, I would suggest a separate request.

      5) In the tab-less style, changed the main button on non-main actions to the default icon for the page's content-type, sub-type, or prefix, where applicable, in the next release.

      6) Tweaked in the next release.

      Marking this as fixed in the next release.
      Reply Reply  
    2. August 13, 2020 9:46 AM
      ACL ACL is offline
      Regular Member
      Quote Originally Posted by ACL
      4) Tab-less watch button icon: Use fa-eye instead of fa-bell.

      In XenForo 2.x, the bell icon represents the 'Alerts' menu in the main navigation, while the eye icon is utilised in structured lists to show the watched status of content (e.g. threads in forum view). For this reason I think that fa-eye might be more appropriate for this VaultWiki feature.
      Quote Originally Posted by pegasus
      4) There is a discrepancy in XF2 where different icons are used for this. In thread lists, there is an eye as an indicator, showing that it is currently watched, however in some watch-related forms, the icon for the submit button is bell-related. The bell related icons are named internally for "notifications". Since the tabless button is not an indicator alone, but leads to a watch-related form where one would manage notifications for the wiki content, the bell icon was chosen
      A small update for anyone who reads this issue at a later date: XenForo has made some changes in their 2.2 branch, resulting in the bell icon now being used as the 'Thread watched' indicator in structured lists. Leaving VW's tab-less watch button as-is without changing its icon was the right move after all!
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 1:26 PM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2025 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2025 DragonByte Technologies Ltd.
    Copyright © 2008 - 2024 VaultWiki Team, Cracked Egg Studios, LLC.