• Register
    • Help

    striker  0 Items
    Currently Supporting
    • Home
    • News
    • Forum
    • Wiki
    • Support
      • Manage Subscriptions
      • FAQ
      • Support For
        • VaultWiki 4.x Series
        • VaultWiki.org Site
    • What's New?
    • Buy Now
    • Manual
    • 
    • Support
    • VaultWiki 4.x Series
    • Bug
    • [4.1 Beta 3] CSS: Tab-less page action button icons are duplicated, tabbed watched icon positioning (suggestion: change to phrase)

    1. Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

      VaultWiki allows your existing forum users to collaborate on creating and managing a site's content pages. VaultWiki is a fully-featured and fully-supported wiki solution for vBulletin and XenForo.

      The VaultWiki Team encourages you to join our community of forum administrators and check out VaultWiki for yourself.

    Issue: [4.1 Beta 3] CSS: Tab-less page action button icons are duplicated, tabbed watched icon positioning (suggestion: change to phrase)

    • Issue Tools
      • View Changes
    1. issueid=5843 September 6, 2019 2:46 PM
      ACL ACL is offline
      Regular Member
      [4.1 Beta 3] CSS: Tab-less page action button icons are duplicated, tabbed watched icon positioning (suggestion: change to phrase)

      In VW 4.1 Beta 3 and XF2.1, I'm experiencing a few styling-related quirks with the new tab-less page layout (implemented in report #1834). I'll include a couple of screenshots to assist with showing the issue.

      1) Icons for selected buttons are duplicated in page action area, such as watch, list and main. Bookmark and the '...' menu trigger are not affected.


      Attachment 1691

      Looking at the CSS with the browser inspector, the FA icon is being declared once for the a.button element, and then again for the child element span.button-text. Examples:

      Code:
      .vw-tab-flat-watch:before {
          content: "\f0f3";
          font-weight: 900;
      }
      Code:
      .vw-tab-flat-watch .button-text:before {
          content: "\f0f3";
      }
      and

      Code:
      .vw-tab-flat-list:before, .vw-tab-flat-listing:before, .vw-tab-flat-contents:before {
          content: "\f03a";
          font-weight: 900;
      }
      Code:
      .vw-tab-flat-list .button-text:before, .vw-tab-flat-contents .button-text:before, .vw-tab-flat-listing .button-text:before {
          content: "\f03a";
          font-weight: 900;
      }
      and

      Code:
      .vw-tab-flat-main:before {
          content: "\f2ea";
          font-weight: 900;
      }
      Code:
      .vw-tab-flat-main .button-text:before {
          content: "\f0e2";
          font-weight: 900;
      }
      My suggestion would be to remove the first, third and fifth code blocks above, leaving just the rules that where .button-text:before is part of the selector.

      2) The following CSS specifying the FA5 font seems unnecessary in XF2.1 and causes the icons to slightly fall out of vertical alignment:
      Code:
      .vw-tab-flat-button {
          font-family: 'Font Awesome 5 Pro';/
      }
      The button--icon class is all that is required and then XF2.1's core CSS handles the rest. With 1) and 2) applied this is how the tab-less page action buttons could look:


      Attachment 1690

      ----

      3) With older 'tabbed' page display, the new watched indicated icon gets positioned at the right edge of the entire tabs block. To be honest, as nice as the icon might be (if positioned correctly), I'd prefer it if the "Watch" text could be toggled. XenForo uses "Unwatch" (and clicking that link brings up an Unwatch overlay). Perhaps VW could toggle between "Watch" and "Watched"?

      Currently:

      Attachment 1689

      Suggestion:

      Attachment 1688

      XF Thread (for reference):

      Attachment 1687
    Issue Details
    Issue Number 5843
    Issue Type Bug
    Project VaultWiki 4.x Series
    Category Styling / CSS
    Status Fixed
    Priority 5 - Minor Bugs / Small Tweaks
    Affected Version 4.1.0 Beta 3
    Fixed Version 4.1.0 Beta 3
    Milestone (none)
    Software DependencyXenForo 2.x
    License TypePaid
    Users able to reproduce bug 0
    Users unable to reproduce bug 0
    Attachments 5
    Assigned Users (none)
    Tags (none)




    1. September 6, 2019 5:05 PM
      pegasus pegasus is offline
      VaultWiki Team
      Fixed duplicated icons and incorrect indicator positions in the next build.
      Reply Reply  
    2. September 24, 2019 12:34 PM
      ACL ACL is offline
      Regular Member
      Edit: moved to site issue 5872.
      Reply Reply  
    + Reply

    Assigned Users
    Loading Please Wait
    Tags
    Loading Please Wait
    • Contact Us
    • License Agreement
    • Privacy
    • Terms
    • Top
    All times are GMT -4. The time now is 7:16 PM.
    This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
    By continuing to use this site, you are consenting to our use of cookies.
    Learn more… Accept Remind me later
  • striker
    Powered by vBulletin® Version 4.2.5 Beta 2
    Copyright © 2025 vBulletin Solutions Inc. All rights reserved.
    Search Engine Optimisation provided by DragonByte SEO (Pro) - vBulletin Mods & Addons Copyright © 2025 DragonByte Technologies Ltd.
    Copyright © 2008 - 2024 VaultWiki Team, Cracked Egg Studios, LLC.