[4.1 Beta 3] addon.json version_id and version_string unchanged from Beta 2 ... unable to upgrade 'as-is'
The upload\src\addons\vw\vwaddon.json file in the XF2.1 Beta 3 zip archive has the same contents as XF2.1 Beta 2 b002, even the version id and sting:
Code:
"version_string": "4.1.0 Beta 2",
"version_id": 1214010022,
This means that it is not possible to 'upgrade' the addon within XF. I believe that these should be:
Code:
"version_string": "4.1.0 Beta 3",
"version_id": 1214010023,
I've made the above changes to addon.json on my offline test site and was then able to start the upgrade. If this were a public site then I wouldn't have made edits to this file (in case I were to hypothetically enter an incorrect version_id and somehow end up skipping future upgrade steps due to my error).
------
Additionally, the URL in the upgrade blockMessage is not quite right as it is currently missing the 'admin.php?' part.
I'm thinking that this could be because
vw_general_upgrade is a public template. This template's link is:
Code:
<a href="{{ link('add-ons/vw-vw/upgrade') }}" rel="nofollow">{{ phrase('complete_upgrade') }}</a>
In the standard XenForo public template
notice_board_closed, an admin cp link is formatted with a special kind of template function. Perhaps this would address the wrong VW addon upgrade link? E.g.:
Code:
<a href="{{ link_type('admin', 'add-ons/vw-vw/upgrade') }}">
N.B. I have not tested whether this template code would fix the VW addon upgrade link. As I've performed the Beta 3 upgrade already, I no longer see the upgrade notice.