[4.1 Alpha 3] 1) Edit access mask LogicException, 2) New access mask form is-selected not updating, 3) XF2.1 approval queue missing username & avatar for new pages
1)
Admin cp: User access masks - editing mask
A LogicException is generated when trying to save an access mask with all settings set as "Not Set"
LogicException: Cannot delete an entity that has been partially updated in src/addons/vw/vw/XF/Entity/Entity.php at line 814
Code:
vw\vw\XF\Entity\Entity->vwDelete() in src/addons/vw/vw/_core/controller/dm/xf2.php at line 391
vw_DM_Controller_XF2->delete() in src/addons/vw/vw/_core/controller/cp/permission/vw.php at line 431
vw_CP_Permission_Controller->save() in src/addons/vw/vw/_core/controller/cp/mask/vw.php at line 82
vw_CP_Mask_Controller->save() in src/addons/vw/vw/_core/controller/cp/mask/vw.php at line 46
vw_CP_Mask_Controller->execute() in src/addons/vw/vw/Admin/Controller/Wiki.php at line 90
vw\vw\Admin\Controller\Wiki->_actionIndex() in src/addons/vw/vw/Mvc/Dispatcher.php at line 30
vw\vw\Mvc\Dispatcher::dispatch() in src/addons/vw/vw/Admin/Controller/Wiki.php at line 51
vw\vw\Admin\Controller\Wiki->actionIndex() in src/XF/Mvc/Dispatcher.php at line 321
XF\Mvc\Dispatcher->dispatchClass() in src/XF/Mvc/Dispatcher.php at line 248
XF\Mvc\Dispatcher->dispatchFromMatch() in src/XF/Mvc/Dispatcher.php at line 100
XF\Mvc\Dispatcher->dispatchLoop() in src/XF/Mvc/Dispatcher.php at line 50
XF\Mvc\Dispatcher->run() in src/XF/App.php at line 2177
XF\App->run() in src/XF.php at line 390
XF::runApp() in admin.php at line 13
2)
Admin cp: User access masks - add mask for new user
CSS/Styling: When creating a new access mask permission, the overlay form does not update the "is-selected" class when an option is changed.
3)
Approval queue
When a new page is created and placed into the approval queue, there is no user information for who created this page. Instead, the default forum avatar is used ('?' when dynamic avatars are enabled). A lack of user information Could wiki pages in the queue fetch this information from the most recent wiki edit?