Issue: Heading tags being parsed within code tags

Issue Tools
- View Changes

March 6, 2019 1:06 PM

expanserpb

Junior Member

Heading tags being parsed within code tags

https://chroniclesrp.net/Folklore/Sa...acter-creation

The heading tags are being parsed and turned into headings within the code box (under spoiler=detailed template)

This is slightly undermining teaching people to use the heading tags.

This definitely used to work

Issue Details

Issue Number 5664

Issue Type Bug

Project VaultWiki 4.x Series

Category Unknown

Status Fixed

Priority 5 - Minor Bugs / Small Tweaks

Affected Version 4.0.25

Fixed Version 4.1.0 Beta 1

Milestone (none)

Software DependencyXenForo 1.x

License TypePaid

Users able to reproduce bug 0

Users unable to reproduce bug 0

Attachments 0

Assigned Users (none)

Tags (none)

March 6, 2019 5:48 PM
pegasus

VaultWiki Team
The behavior you are experiencing is the correct behavior when CODE=rich (cannot tell whether you are using this); this behavior is actually bugged in all versions and it does not always render as expected.

When not using CODE=rich, the problem you are seeing is not limited to the H BB-Code. It will occur with any BB-Code wrapped in CODE/HTML/etc tags, provided it is not the first BB-Code inside the CODE tags. The problem has occurred in all versions since 4.0.0 RC 5, released in November 2014. It can be reproduced with the following simple test:

PHP Code:

[CODE]Testing code block [b]Unparsed bb-code[/b] [b]Parsed bb-code[/b][/CODE]

Where (as commented), the first B will display its raw code, but the second B will render as HTML.

In library/vw/XenForo/BbCode/Parser.php, find:

Code:

if (!$retval) { if (empty($this->_parserStates['plainText'])) { $this->_parserStates['plainText'] = $origPlainTextState; } return false; } if (empty($this->_parserStates['plainText'])) { $this->_parserStates['origPlainTextState'][] = $origPlainTextState; }

Replace with:

Code:

$this->_parserStates['origPlainTextState'][] = $origPlainTextState; if (!$retval) { $this->_parserStates['plainText'] = $origPlainTextState; return false; }

Both issues will be fixed in 4.0.26 and 4.1.0 Alpha 3.
Reply

+ Reply

All times are GMT -4. The time now is 1:46 PM.

This site uses cookies to help personalize content, to tailor your experience, and to keep you logged in if you register.
By continuing to use this site, you are consenting to our use of cookies.

Learn more… Accept Remind me later

Welcome to VaultWiki.org, home of the wiki add-on for vBulletin and XenForo!

Issue: Heading tags being parsed within code tags

Issue Tools